Store git repository information in ebuild [SOLVED]

[Zucca]

I've faced some problems with git and ebuild creation.
I have written my own git-extra.eclass. It inherits git-r3.eclass and then adds a function which runs few git commands to retrieve commit hash and tag (if any) and put that information in the package doc directory. I've made this because it's then easy to create new ebuild from installed -9999 live version.

However something has changed and running git commands to query the information will error out:

Code: Select all

fatal: detected dubious ownership in repository at '/var/tmp/portage/dev-games/eureka-1.27-r1/work/eureka-1.27'                                                                                                                                
To add an exception for this directory, call:                                                                                                                                                                                                  
                                                                                                                                                                                                                                               
        git config --global --add safe.directory /var/tmp/portage/dev-games/eureka-1.27-r1/work/eureka-1.27

... if I run the command above (but without --global, for obvious reasons) I get:

Code: Select all

fatal: not in a git directory

The function inside my eclass for the curious ones:

Code: Select all

git_nfo() {
        local git_nfo_file="${T%/}/git_version.nfo"
        local TAG CNUM

        [[ ! -f "$git_nfo_file" ]] && {
                TAG="$(git tag --list --sort=-version:refname | head -n 1)"
                echo "tag: ${TAG:-"[notag]"}"
                CNUM="$(git rev-list --count ${TAG:+${TAG}..}HEAD)"
                echo "commit number (since tag): ${CNUM}"
                echo "commit: $(git rev-parse HEAD)"
                echo "PF: ${PN}-${TAG}_p${CNUM}"
        } > "$git_nfo_file"

        case "$1" in
                install)
                        if [[ "$2" ]]
                        then
                                newdoc "$git_nfo_file" "$2"
                        else
                                dodoc "$git_nfo_file"
                        fi
                ;;
                *)
                        cat "$git_nfo_file"
                ;;
        esac
}

Any tips to get git commands work again, or alternatively how to get the information what the function above used to retrieve?

[hdcg]

Hi Zucca,

since a few updates git warns and rejects to work if (at least) the root user tries to execute a git command within a repository not owned by the running user.
I guess emerge runs the install phase as root and everything else as the portage user.

The message

Code: Select all

fatal: not in a git directory

indicates git is running outside a git repository, but needs a repository for the requested command. In your case omitting the --global flag, instructs git to change the repository settings, hence the error.

I suggest to move the extract part from install to prepare or compile phase. Then it should work again.

Best Regards,
Holger

[Zucca]

I guess emerge runs the install phase as root and everything else as the portage user.

Yes. That's the probable cause of the error. Thanks.

The message

Code: Select all

fatal: not in a git directory

indicates git is running outside a git repository, but needs a repository for the requested command. In your case omitting the --global flag, instructs git to change the repository settings, hence the error.

I specifically made sure to pass the right directory (even an absolute path) for the command. Do you suspect that the current working directory needs to be also inside the repository directory?

I'll try to adjust my eclass...

[Hu]

I specifically made sure to pass the right directory (even an absolute path) for the command. Do you suspect that the current working directory needs to be also inside the repository directory?

Yes. The command as shown tells git what to trust. It does not tell it where to store that trust, so we follow the standard git rules. If none of the location flags are specified, git defaults to storing in the local git repository. If the current working directory is not a repository and you have not otherwise told it how to find a repository, then it fails saying you are not in a local git repository.

Also, for this particular git configuration, I expect putting it in the local repository will be ignored. Per the documentation, git is refusing to work with a repository owned by a foreign user. If that user could mark the repository as safe, then what would stop every malicious repository from flagging itself as safe?

[Zucca]

I added pushd "${S}" and popd in the beginning and the end of the function and it does now work.
Thanks for you both!