Once more Con's patch makes it impossible for me to compile love-sources. I think I'll stick to WOLK until this is fixed on AMD64.
I noticed it complains about a redundant definition of VM_STACK_DEFAULT_FLAGS.
Code: Select all
# grep -ri 'vm_stack_default' ./*
./include/asm/page.h:#define VM_STACK_DEFAULT_FLAGS \
./include/linux/mm.h: #ifndef VM_STACK_DEFAULT_FLAGS
./include/linux/mm.h: #define VM_STACK_DEFAULT_FLAGS (0x00000033 | __VM_STACK_FLAGS)
./include/linux/mm.h:#ifndef VM_STACK_DEFAULT_FLAGS /* arch can override this */
./include/linux/mm.h:#define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS
./include/linux/mm.h:#define VM_STACK_FLAGS (VM_GROWSUP | VM_STACK_DEFAULT_FLAGS | VM_ACCOUNT)
./include/linux/mm.h:#define VM_STACK_FLAGS (VM_GROWSDOWN | VM_STACK_DEFAULT_FLAGS | VM_ACCOUNT)
./include/asm-x86_64/page.h:#define VM_STACK_DEFAULT_FLAGS \
I wrote a patch to override the definition in page.h (i.e. adding #undef) and it seemed safe to me. Does anybody has a suggestion whether this is a good idea? Or should I dismiss the definition in mm.h?