[SOLVED] fix ebuild ( -Wimplicit-function-declaration )

[sdauth]

Hello,
I need help to solve a compilation issue for this little tool: https://github.com/Network-BEncode-inside/torrentcheck

With gcc 14.3.0, here is the error :

Code: Select all

~ make
cc -c -O -DICONV_IMPLEMENTATION src/torrentcheck.c -o src/torrentcheck.o
src/torrentcheck.c: In function 'beFindInDict':
src/torrentcheck.c:207:28: error: implicit declaration of function 'beStepOver' [-Wimplicit-function-declaration]
  207 |             benstrOffset = beStepOver(benstr,benstrLen,benstrOffset);
      |                            ^~~~~~~~~~
make: *** [Makefile:12: src/torrentcheck.o] Error 1

I don't have gcc 12 anymore installed on my system and it's a bit overkill to emerge it
so I tried to compile this tool in a debian bookworm chroot (it uses gcc 12)
And it compiles just fine with gcc 12 (and works fine too)

Is there a way to compile it (maybe a patch is needed ?) with gcc 14 so I can write a little ebuild for it ?
Thanks!

[Anon-E-moose]

Code: Select all

--- a/src/torrentcheck.c        2025-06-24 12:04:13.158083308 -0500
+++ b/src/torrentcheck.c        2025-06-24 12:03:33.332535609 -0500
@@ -40,6 +40,8 @@
 #define SHA1_LEN 20
 // End required for SHA1

+int beStepOver(BYTE* benstr,int benstrLen,int benstrOffset);
+
 // For filter mode only, torrent buffer length depends on the torrent
 #define inputBufLen 262144

[grknight]

If you don't want to fix the source, add -std=gnu90 to the gcc call. Newer standards need explicit function definitions and this was the old gcc default.

[sdauth]

Code: Select all

--- a/src/torrentcheck.c        2025-06-24 12:04:13.158083308 -0500
+++ b/src/torrentcheck.c        2025-06-24 12:03:33.332535609 -0500
@@ -40,6 +40,8 @@
 #define SHA1_LEN 20
 // End required for SHA1

+int beStepOver(BYTE* benstr,int benstrLen,int benstrOffset);
+
 // For filter mode only, torrent buffer length depends on the torrent
 #define inputBufLen 262144

Perfect, thank you very much Anon-E-moose!

I leave the ebuild here for others :

app-misc/torrentcheck-1.20_p20230129.ebuild

Code: Select all

# Copyright 1999-2025 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=8

DESCRIPTION="Command line torrent viewer and hash checker"
HOMEPAGE="
	https://sourceforge.net/projects/torrentcheck
	https://github.com/Network-BEncode-inside/torrentcheck"

if [[ "${PV}" == "9999" ]]; then
	inherit git-r3
	EGIT_REPO_URI="https://github.com/Network-BEncode-inside/${PN}.git"
else
	COMMIT="50d11d401476fff9c1745e8d76dd0da0c4484422"
	SRC_URI="https://github.com/Network-BEncode-inside/${PN}/archive/${COMMIT}.tar.gz -> ${P}.tar.gz"
	KEYWORDS="~amd64"
	S="${WORKDIR}/${PN}-${COMMIT}"
fi

LICENSE="GPL-3"
SLOT="0"
PATCHES=( "${FILESDIR}/implicit_function.patch" )

src_install() {
	dobin "${PN}"
}