[SOLVED] firefox 65 fails to compile

Message

pourpier · Post by **pourpier** » Tue Jan 29, 2019 7:39 pm

Hello,
In the last world update there was firefox 65 which fails to compile due to this error:

In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/include/immintrin.h:85:0,
from /var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/gfx/skia/skia/src/opts/SkBitmapFilter_opts.h:14,
from /var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/gfx/skia/skia/src/core/SkOpts.cpp:39:
 /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/include/fmaintrin.h: In function 'avx2::F avx2::mad(avx2::F, avx2::F, avx2::F)':
 /usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/include/fmaintrin.h:55:1: error: inlining failed in call to always_inline '__m128 _mm_fmadd_ps(__m128, __m128, __m128)': target specific option mismatch
  _mm_fmadd_ps (__m128 __A, __m128 __B, __m128 __C)
gmake[4]: *** [/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/config/rules.mk:1133: SkOpts.o] Error 1
gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/ff/gfx/skia'
gmake[3]: *** [/var/tmp/portage/www-client/firefox-65.0/work/firefox-65.0/config/recurse.mk:74: gfx/skia/target] Error 2

[Moderator edit: added [code] tags to preserve output layout. -Hu]

Post by **fedeliallalinea** » Tue Jan 29, 2019 7:58 pm

You can post your emerge --info and emerge -pvq =firefox-65.0?

pourpier · Post by **pourpier** » Tue Jan 29, 2019 8:18 pm

fedeliallalinea wrote:You can post your emerge --info and emerge -pvq =firefox-65.0?

Code: Select all

Portage 2.3.51 (python 3.6.5-final-0, default/linux/amd64/17.0/desktop, gcc-7.3.0, glibc-2.27-r6, 4.19.18-gentoo x86_64)
=================================================================
System uname: Linux-4.19.18-gentoo-x86_64-Intel-R-_Core-TM-_i5-4690_CPU_@_3.50GHz-with-gentoo-2.6
KiB Mem:     8174980 total,   7277304 free
KiB Swap:    1048572 total,   1048572 free
Timestamp of repository gentoo: Tue, 29 Jan 2019 18:00:01 +0000
Head commit of repository gentoo: 2d482527931eac0ffafbb082b1fba48b94d6e55b
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.30 p5) 2.30.0
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.38.3-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r4::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.14-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts:

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.leaseweb.com/gentoo/ rsync://mirror.leaseweb.com/gentoo/"
LANG="fr_BE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="fr"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam flac fortran gdbm gif glamor gpm gtk iconv ipv6 jpeg lcms ldap libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds pulseaudio python qt5 readline sdl seccomp spell ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" L10N="fr" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Code: Select all

[ebuild     U ] www-client/firefox-65.0 [64.0.2] USE="dbus gmp-autoupdate pulseaudio screenshot startup-notification system-harfbuzz* system-icu* system-jpeg* system-libevent* system-libvpx* system-sqlite* system-webp%* -bindist -clang -custom-cflags -custom-optimization -debug -eme-free -geckodriver -hardened -hwaccel -jack -lto (-neon) -pgo% (-selinux) -test -wayland% -wifi" L10N="fr -ach -af -an -ar -as -ast -az -bg -bn-BD -bn-IN -br -bs -ca -cak -cs -cy -da -de -dsb -el -en-GB -en-ZA -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mai -mk -ml -mr -ms -nb -nl -nn -or -pa -pl -pt-BR -pt-PT -rm -ro -ru -si -sk -sl -son -sq -sr -sv -ta -te -th -tr -uk -uz -vi -xh -zh-CN -zh-TW"

Cheers,
pourpier

[Moderator edit: added [code] tags to preserve output layout. -Hu]

Post by **fedeliallalinea** » Tue Jan 29, 2019 8:43 pm

What return gcc -march=native -E -v - </dev/null 2>&1 | grep cc1 command?

pourpier · Post by **pourpier** » Tue Jan 29, 2019 8:48 pm

fedeliallalinea wrote:What return gcc -march=native -E -v - </dev/null 2>&1 | grep cc1 command?

Code: Select all

/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/cc1 -E -quiet -v - -march=haswell -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mno-sse4a -mcx16 -msahf -mmovbe -maes -mno-sha -mpclmul -mpopcnt -mabm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-sgx -mno-bmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mno-rtm -mno-hle -mrdrnd -mno-f16c -mfsgsbase -mno-rdseed -mno-prfchw -mno-adx -mfxsr -mxsave -mno-xsaveopt -mno-avx512f -mno-avx512er -mno-avx512cd -mno-avx512pf -mno-prefetchwt1 -mno-clflushopt -mno-xsavec -mno-xsaves -mno-avx512dq -mno-avx512bw -mno-avx512vl -mno-avx512ifma -mno-avx512vbmi -mno-avx5124fmaps -mno-avx5124vnniw -mno-clwb -mno-mwaitx -mno-clzero -mno-pku -mno-rdpid --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=6144 -mtune=haswell

[Moderator edit: added [code] tags to preserve output layout. -Hu]

jhon987 · Post by **jhon987** » Tue Jan 29, 2019 9:10 pm

Mine failed to compile too and I disabled system-libvpx (based on prior experience) and then it compiled.
I don't know if it'll work for you too though, in my case I recalled it happened before due to this specific use flag

pourpier · Post by **pourpier** » Tue Jan 29, 2019 9:47 pm

jhon987 wrote:Mine failed to compile too and I disabled system-libvpx (based on prior experience) and then it compiled.
I don't know if it'll work for you too though, in my case I recalled it happened before due to this specific use flag

It gives me exactly the same error.

jhon987 · Post by **jhon987** » Wed Jan 30, 2019 1:52 am

pourpier wrote: It gives me exactly the same error.

Ok, Sorry for wasting your time.

Post by **fedeliallalinea** » Wed Jan 30, 2019 6:43 am

The issue seems related to avx2 instruction set, but your compile active it (I thought native hadn't activated it).
You have some special /etc/portage/env/ set for firefox?

pourpier · Post by **pourpier** » Wed Jan 30, 2019 7:02 am

pourpier wrote:

fedeliallalinea wrote:What return gcc -march=native -E -v - </dev/null 2>&1 | grep cc1 command?

Code: Select all

/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/cc1 -E -quiet -v - -march=haswell -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mno-sse4a -mcx16 -msahf -mmovbe -maes -mno-sha -mpclmul -mpopcnt -mabm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-sgx -mno-bmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mno-rtm -mno-hle -mrdrnd -mno-f16c -mfsgsbase -mno-rdseed -mno-prfchw -mno-adx -mfxsr -mxsave -mno-xsaveopt -mno-avx512f -mno-avx512er -mno-avx512cd -mno-avx512pf -mno-prefetchwt1 -mno-clflushopt -mno-xsavec -mno-xsaves -mno-avx512dq -mno-avx512bw -mno-avx512vl -mno-avx512ifma -mno-avx512vbmi -mno-avx5124fmaps -mno-avx5124vnniw -mno-clwb -mno-mwaitx -mno-clzero -mno-pku -mno-rdpid --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=6144 -mtune=haswell

[Moderator edit: added [code] tags to preserve output layout. -Hu]

Do you think disabling avx2 in the CPU_FLAGS_X86 for this specific package would help? Or is it a total waste of time trying it?

Post by **fedeliallalinea** » Wed Jan 30, 2019 7:18 am

pourpier wrote:Do you think disabling avx2 in the CPU_FLAGS_X86 for this specific package would help? Or is it a total waste of time trying it?

No, I thought he needed to be enabled

pourpier · Post by **pourpier** » Wed Jan 30, 2019 7:41 am

fedeliallalinea wrote:
pourpier wrote:Do you think disabling avx2 in the CPU_FLAGS_X86 for this specific package would help? Or is it a total waste of time trying it?
No, I thought he needed to be enabled

Could you tell me if the function which causes the problem is also used for the version 64.0.2 as that one didn't fail to compile?
Cheers

Post by **fedeliallalinea** » Wed Jan 30, 2019 7:53 am

pourpier wrote:Could you tell me if the function which causes the problem is also used for the version 64.0.2 as that one didn't fail to compile?

The function isn't present in <firefox-65.
The function that cause problem is in the file gfx/skia/skia/src/opts/SkRasterPipeline_opts.h (line 499) called by gfx/skia/skia/src/opts/SkOpts_avx.cpp

Code: Select all

...
#elif defined(JUMPER_IS_SSE2) || defined(JUMPER_IS_SSE41)
    template <typename T> using V = SK_VECTORTYPE(T, 4);
    using F   = V<float   >;
    using I32 = V< int32_t>;
    using U64 = V<uint64_t>;
    using U32 = V<uint32_t>;
    using U16 = V<uint16_t>;
    using U8  = V<uint8_t >;

    #ifndef __clang__
        template <typename T, typename P> SI T unaligned_load_SkNx(const P* p) { return T::Load(p); }
        template <typename T, typename P> SI void unaligned_store_SkNx(P* p, T v) { v.store(p); }
        #define unaligned_load unaligned_load_SkNx
        #define unaligned_store unaligned_store_SkNx
        template <typename Dst> SI __m128i widen_cast(const U16& src) { static_assert(sizeof(Dst) == sizeof(__m128i), ""); return src.fVec; }
    #endif

    SI F mad(F f, F m, F a)  {
    #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_AVX2
        return _mm_fmadd_ps(f,m,a); <-- this line
    #else
        return f*m+a;
    #endif
    }
....

pourpier · Post by **pourpier** » Wed Jan 30, 2019 9:01 am

fedeliallalinea wrote:

pourpier wrote:Could you tell me if the function which causes the problem is also used for the version 64.0.2 as that one didn't fail to compile?

The function isn't present in <firefox-65.
The function that cause problem is in the file gfx/skia/skia/src/opts/SkRasterPipeline_opts.h (line 499) called by gfx/skia/skia/src/opts/SkOpts_avx.cpp

Code: Select all

...
#elif defined(JUMPER_IS_SSE2) || defined(JUMPER_IS_SSE41)
    template <typename T> using V = SK_VECTORTYPE(T, 4);
    using F   = V<float   >;
    using I32 = V< int32_t>;
    using U64 = V<uint64_t>;
    using U32 = V<uint32_t>;
    using U16 = V<uint16_t>;
    using U8  = V<uint8_t >;

    #ifndef __clang__
        template <typename T, typename P> SI T unaligned_load_SkNx(const P* p) { return T::Load(p); }
        template <typename T, typename P> SI void unaligned_store_SkNx(P* p, T v) { v.store(p); }
        #define unaligned_load unaligned_load_SkNx
        #define unaligned_store unaligned_store_SkNx
        template <typename Dst> SI __m128i widen_cast(const U16& src) { static_assert(sizeof(Dst) == sizeof(__m128i), ""); return src.fVec; }
    #endif

    SI F mad(F f, F m, F a)  {
    #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_AVX2
        return _mm_fmadd_ps(f,m,a); <-- this line
    #else
        return f*m+a;
    #endif
    }
....

Do I need to file a bug or do I have to manually write some line in that file so that FF 65 compiles without that issue?

Post by **fedeliallalinea** » Wed Jan 30, 2019 9:04 am

pourpier wrote:Do I need to file a bug or do I have to manually write some line in that file so that FF 65 compiles without that issue?

Fill a bug also because I can't tell you what to do.

pourpier · Post by **pourpier** » Wed Jan 30, 2019 9:17 am

fedeliallalinea wrote:
pourpier wrote:Do I need to file a bug or do I have to manually write some line in that file so that FF 65 compiles without that issue?
Fill a bug also because I can't tell you what to do.

I filed the bug: https://bugs.gentoo.org/676894
Thanks for your help.
Best regards,
pourpier

pourpier · Post by **pourpier** » Mon Feb 04, 2019 9:44 am

fedeliallalinea wrote:The issue seems related to avx2 instruction set, but your compile active it (I thought native hadn't activated it).
You have some special /etc/portage/env/ set for firefox?

I decided finally to create the env directory and I put a file named firefox.conf under it with these lines:
CFLAGS="{CFLAGS} -mno-avx2"
CXXFLAGS="{CXXFLAGS} -mno-avx2"

Then I created the file package.env with this line in it: www-client/firefox firefox.conf

As libvpx has avx and avx2 as USE flags I had to disable system-linvpx in package.use for Firefox
Then Firefox 65 did compile correctly but I think Thomas Deuthschmann should try to get in touch with the Mozilla team and Intel to find a patch for the issue.
I will edit this as solved.
Cheers

Whissi · Post by **Whissi** » Tue Feb 05, 2019 6:14 pm

Can you please undo your changes and also remove

mozconfig_annotate '' --enable-rust-simd

from ebuild (=revert of https://gitweb.gentoo.org/repo/gentoo.g ... 3d2efea648) and try again?

pourpier · Post by **pourpier** » Tue Feb 05, 2019 7:44 pm

Whissi wrote:Can you please undo your changes and also remove
mozconfig_annotate '' --enable-rust-simd
from ebuild (=revert of https://gitweb.gentoo.org/repo/gentoo.g ... 3d2efea648) and try again?

I'll do it when 65.0.1 comes out as I did compile Firefox 65.0 several times and it takes a long time.
Best regards,
pourpier