Can Libreoffice add USE pdf to make poppler dep optional?

Message

jeffk · Post by **jeffk** » Wed May 25, 2016 2:57 am

Question for those familiar with libreoffice build system: would the libreoffice configure system support a USE pdf so that the dependency on poppler can be made optional?

Code: Select all

!!! existing preserved libs:
>>> package: app-text/poppler-0.44.0
 *  - /usr/lib64/libpoppler.so.60
 *  - /usr/lib64/libpoppler.so.60.0.0
 *      used by /usr/lib64/libreoffice/program/xpdfimport (app-office/libreoffice-5.1.2.2)
Use emerge @preserved-rebuild to rebuild packages using these libraries

Here are some grep matches for pdf in the libreoffice unpacked source. No matches exist in temp/.

Code: Select all

# grep -i pdf /var/tmp/portage/app-office/libreoffice-5.1.2.2/work/libreoffice-5.1.2.2/config*
config_host.mk:export ENABLE_PDFIMPORT=TRUE
config_host.mk.in:export ENABLE_PDFIMPORT=@ENABLE_PDFIMPORT@
config.log:configure:36761: checking whether to build the PDF import feature
config.log:configure:36769: checking which PDF import backend to use
config.log:ENABLE_PDFIMPORT='TRUE'
config.log:pdfdir='${docdir}'
config.log:#define ENABLE_PDFIMPORT 1
grep: configmgr: Is a directory
config.status:S["ENABLE_PDFIMPORT"]="TRUE"
config.status:S["pdfdir"]="${docdir}"
config.status:D["ENABLE_PDFIMPORT"]=" 1"
configure:ENABLE_PDFIMPORT
configure:pdfdir
configure:enable_pdfimport
configure:pdfdir='${docdir}'
configure:  -pdfdir | --pdfdir | --pdfdi | --pdfd | --pdf | --pd)
configure:    ac_prev=pdfdir ;;
configure:  -pdfdir=* | --pdfdir=* | --pdfdi=* | --pdfd=* | --pdf=* | --pd=*)
configure:    pdfdir=$ac_optarg ;;
configure:              oldincludedir docdir infodir htmldir dvidir pdfdir psdir \
configure:  --pdfdir=DIR            pdf documentation [DOCDIR]
configure:  --disable-pdfimport     Disable building the PDF import feature.
configure:  --with-system-poppler   Use system poppler (only needed for PDF import).
configure:# Check whether --enable-pdfimport was given.
configure:if test "${enable_pdfimport+set}" = set; then :
configure:  enableval=$enable_pdfimport;
configure:        --disable-pdfimport \
configure:# pdf import?
configure:{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether to build the PDF import feature" >&5
configure:$as_echo_n "checking whether to build the PDF import feature... " >&6; }
configure:ENABLE_PDFIMPORT=
configure:if test $_os != Android -a $_os != iOS -a \( -z "$enable_pdfimport" -o "$enable_pdfimport" = yes \); then
configure:    ENABLE_PDFIMPORT=TRUE
configure:                { $as_echo "$as_me:${as_lineno-$LINENO}: checking which PDF import backend to use" >&5
configure:$as_echo_n "checking which PDF import backend to use... " >&6; }
configure:    $as_echo "#define ENABLE_PDFIMPORT 1" >>confdefs.h
configure:    if test -n "$ENABLE_PDFIMPORT"; then
configure:            as_fn_error $? "need to disable PDF import via poppler or use system library" "$LINENO" 5
configure.ac:AC_ARG_ENABLE(pdfimport,
configure.ac:    AS_HELP_STRING([--disable-pdfimport],
configure.ac:        [Disable building the PDF import feature.])
configure.ac:        [Use system poppler (only needed for PDF import).]),,
configure.ac:        --disable-pdfimport \
configure.ac:# pdf import?
configure.ac:AC_MSG_CHECKING([whether to build the PDF import feature])
configure.ac:ENABLE_PDFIMPORT=
configure.ac:if test $_os != Android -a $_os != iOS -a \( -z "$enable_pdfimport" -o "$enable_pdfimport" = yes \); then
configure.ac:    ENABLE_PDFIMPORT=TRUE
configure.ac:    AC_MSG_CHECKING([which PDF import backend to use])
configure.ac:    AC_DEFINE([ENABLE_PDFIMPORT],1)
configure.ac:AC_SUBST(ENABLE_PDFIMPORT)
configure.ac:    if test -n "$ENABLE_PDFIMPORT"; then
configure.ac:            AC_MSG_ERROR([need to disable PDF import via poppler or use system library])

EDIT: fix typo in title re: poppler.

geki · Post by **geki** » Wed May 25, 2016 12:01 pm

good idea to rip poppler out of the dependency list for its subslot hell. I will do that in my overlay.

Post by **asturm** » Wed May 25, 2016 1:02 pm

eh, you just gotta time these updates with any upcoming libreoffice version bump - either mask poppler/icu for a few days, or unmask the next libreoffice version in advance of its probable stabilisation.

that's how I'm doing it on 7-year old lowvoltage hardware.

geki · Post by **geki** » Wed May 25, 2016 4:19 pm

actually, that configure flag did not change since openoffice times. this post takes as much time.

Post by **dilfridge** » Fri May 27, 2016 8:15 pm

geki wrote:actually, that configure flag did not change since openoffice times. this post takes as much time.

Please try it and tell us if it works again. The useflag disappeared since upstream made the dependency unconditional at some point.

geki · Post by **geki** » Sat May 28, 2016 7:24 am

well, I do not remember, if there was a system poppler flag or not.

but the flag '--enable-pdfimport' is still present, which is the only consumer of poppler within open/libreoffice.

see: https://github.com/geki-yaba/gekis-play ... 0930b25891

jeffk · Post by **jeffk** » Mon Aug 01, 2016 12:27 pm

I'm now using geki's modified libreoffice build with use=-pdfimport, and it is working well for me. No more libreoffice rebuilds when poppler updates land.

Would you consider asking Gentoo devs to include this change in the portage version of libreoffice?

Naib · Post by **Naib** » Mon Aug 01, 2016 4:50 pm

This would be great! got myself into a perpetual build mess due to a particular poppler was removed BUT that was the one the libre was built with and then a nice circular mess...

jeffk · Post by **jeffk** » Mon Aug 01, 2016 11:13 pm

dilfridge wrote:
geki wrote:actually, that configure flag did not change since openoffice times. this post takes as much time.
Please try it and tell us if it works again. The useflag disappeared since upstream made the dependency unconditional at some point.

Can you elaborate? I'm not clear on what USE var (if not pdfimport) you're suggesting geki or others try again. Is it something inherited from one of the eclasses?