vmware-modules-279.1 failed to build

Message

sQu1rr · Post by **sQu1rr** » Sun Jan 26, 2014 1:22 am

This worked for me

--- work/vmnet-only/filter.c	2013-08-27 20:29:04.000000000 +0100
+++ patched/vmnet-only/filter.c	2014-01-26 01:09:05.184893854 +0000
@@ -27,6 +27,7 @@
 #include "compat_module.h"
 #include <linux/mutex.h>
 #include <linux/netdevice.h>
+#include <linux/version.h>
 #if COMPAT_LINUX_VERSION_CHECK_LT(3, 2, 0)
 #   include <linux/module.h>
 #else
@@ -203,7 +204,11 @@
 #endif
 
 static unsigned int
+#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 13, 0)
 VNetFilterHookFn(unsigned int hooknum,                 // IN:
+#else
+VNetFilterHookFn(const struct nf_hook_ops *ops,        // IN:
+#endif
 #ifdef VMW_NFHOOK_USES_SKB
                  struct sk_buff *skb,                  // IN:
 #else
@@ -252,7 +257,12 @@
 
    /* When the host transmits, hooknum is VMW_NF_INET_POST_ROUTING. */
    /* When the host receives, hooknum is VMW_NF_INET_LOCAL_IN. */
-   transmit = (hooknum == VMW_NF_INET_POST_ROUTING);
+
+   #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 13, 0)
+      transmit = (hooknum == VMW_NF_INET_POST_ROUTING);
+   #else
+      transmit = (ops->hooknum == VMW_NF_INET_POST_ROUTING);
+   #endif
 
    packetHeader = compat_skb_network_header(skb);
    ip = (struct iphdr*)packetHeader;

Though on version 279.0, it should work for 279.1 too

piccolo · Post by **piccolo** » Tue Jan 28, 2014 11:29 am

Hi,
are the patches going to be stored in the portage tree soon?
Or is there a overlay that stores them?
Thanks and greetings,
piccolo

padoor · Post by **padoor** » Fri Jan 31, 2014 2:15 pm

sQu1rr

how to apply the patch you have shown ?

sQu1rr · Post by **sQu1rr** » Mon Mar 03, 2014 2:57 pm

sorry for the late reply, i hope it is still useful info

you put these files in /usr/portage/app-emulation/vmware-modules/files
http://pastebin.com/s61qzMHT
http://pastebin.com/isUeadVf
http://pastebin.com/LXX87Gx6
Note you might have trailing spaces in the end of every line, so delete them somehow if that is the case, in VIM it's :%s/\s\+$//

Then you change ebuild (I'm using vmware-modules-279.0.ebuild, but 279.1 should work too, haven't tested though) file by adding
kernel_is ge 3 11 0 && epatch "${FILESDIR}/${PV_MAJOR}-vmblock-3.11.patch"
kernel_is ge 3 12 0 && epatch "${FILESDIR}/${PV_MAJOR}-vmblock-3.12.patch"
kernel_is ge 3 13 0 && epatch "${FILESDIR}/${PV_MAJOR}-vmnet-3.13.patch"
right after
kernel_is ge 3 10 0 && epatch "${FILESDIR}/${PV_MAJOR}-vmblock.patch" (line #68)

Then you execute
sudo ebuild vmware-modules-279.0.ebuild digest
in /usr/portage/app-emulation/vmware-modules folder

and you are all set
sudo emerge -av vmware-modules should go without errors (tested on every kernel version >= 3.13.0-r1 <= 3.13.5 from gentoo-sources)

radio_flyer · Post by **radio_flyer** » Sat Mar 08, 2014 10:37 pm

Massimo B. wrote:As explained here copying both patches into /etc/portage/patches/app-emulation/vmware-modules solved to emerge app-emulation/vmware-modules-279.1 with running sys-kernel/ck-sources-3.12.5 here.

It appears kernel 3.12.13 just hit the stable amd64 tree. Massimo B's approach worked just fine for me, although I used the directory '/etc/portage/patches/app-emulation/vmware-modules-279.1', as I only want these two patches applied to the currently available ebuild. With any luck the developers will have a new version of vmware-modules available soon to match the now-stable kernel.

gordonp · Post by **gordonp** » Wed Mar 26, 2014 10:04 pm

OUCH - I am bitten by this

I just upgraded my work/production desktop to kernel 3.12.13 (stable), and vmware-modules-279.1 does not build

-GordP

sQu1rr · Post by **sQu1rr** » Mon Mar 31, 2014 5:59 pm

Fix for new kernel (3.14.0), actually this should work with every kernel below this version too

https://drive.google.com/folderview?id= ... sp=sharing

just run
sudo ./fix.sh
sudo emerge vmware-modules

Marlo · Post by **Marlo** » Wed Apr 02, 2014 12:57 pm

Thank you sQu1rr!

It works on Kernel 3.14.
If you expand your script with these commands it is perfect.

Code: Select all

cd /usr/portage/app-emulation/vmware-player
cp vmware-player-6.0.0.1295980.ebuild vmware-player-6.0.1.1379776.ebuild
ebuild vmware-player-6.0.1.1379776.ebuild digest
emerge --config vmware-player

See bug 494960

padoor · Post by **padoor** » Thu Apr 03, 2014 5:14 am

Code: Select all

                from /usr/src/linux-3.14.0-gentoo/include/linux/preempt.h:18,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/spinlock.h:50,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/seqlock.h:35,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/time.h:5,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/stat.h:18,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/module.h:10,
                 from /var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.c:27:
/usr/src/linux-3.14.0-gentoo/include/linux/printk.h:96:0: note: this is the location of the previous definition
 #define DEPRECATED "[Deprecated]: "
 ^
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.c: In function ‘InodeOpLookup’:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.c:138:32: error: incompatible types when assigning to type ‘kgid_t’ from type ‘int’
    inode->i_uid = inode->i_gid = 0;
                                ^
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/inode.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/vmblockInt.h:41:0,
                 from /var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/dentry.c:30:
/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/./shared/vm_assert.h:259:0: warning: "DEPRECATED" redefined [enabled by default]
    #define DEPRECATED(_fix) do {} while (0)
 ^
In file included from /usr/src/linux-3.14.0-gentoo/include/linux/kernel.h:13:0,
                 from /usr/src/linux-3.14.0-gentoo/arch/x86/include/asm/percpu.h:44,
                 from /usr/src/linux-3.14.0-gentoo/arch/x86/include/asm/preempt.h:5,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/preempt.h:18,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/spinlock.h:50,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/wait.h:8,
                 from /usr/src/linux-3.14.0-gentoo/include/linux/fs.h:6,
                 from /var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only/linux/dentry.c:28:
/usr/src/linux-3.14.0-gentoo/include/linux/printk.h:96:0: note: this is the location of the previous definition
 #define DEPRECATED "[Deprecated]: "
 ^
make[2]: *** [_module_/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only] Error 2
make[1]: *** [sub-make] Error 2
make[1]: Leaving directory `/usr/src/linux-3.14.0-gentoo'
make: *** [vmblock.ko] Error 2
 * ERROR: app-emulation/vmware-modules-279.1::x-portage failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=app-emulation/vmware-modules-279.1::x-portage'`,
 * the complete build log and the output of `emerge -pqv '=app-emulation/vmware-modules-279.1::x-portage'`.
 * The complete build log is located at '/var/tmp/portage/app-emulation/vmware-modules-279.1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/app-emulation/vmware-modules-279.1/temp/environment'.
 * Working directory: '/var/tmp/portage/app-emulation/vmware-modules-279.1/work/vmblock-only'
 * S: '/var/tmp/portage/app-emulation/vmware-modules-279.1/work'

>>> Failed to emerge app-emulation/vmware-modules-279.1, Log file:

>>>  '/var/tmp/portage/app-emulation/vmware-modules-279.1/temp/build.log'
tux vmware-modules #

this is what i got when i copied the ppatches to /usr/local/portage/app-emulation/vmware-modules/files
and made the digest.
did not use the fix.sh
but after commenting out the /usr/local/portage path in make.conf
fix.sh worked and vmware-modules merged.
now after next emerge-sync the usr/portage files will change no ?
then what happens ?

sQu1rr · Post by **sQu1rr** » Fri Apr 04, 2014 12:17 am

basically you'll have to copy patches, fix .ebuild and redigest every time before merging vmware-modules. as you said, emerge sync will restore the changed files. That's why i made fix.sh. Every time before merging vmware-modules (after new kernel version released) i run it.

padoor · Post by **padoor** » Fri Apr 04, 2014 3:47 am

kernel versions seem to be coming up faster these days. soon we will find 3.15
this time 3.14 patch came up real soon.

thanks. sQu1rr

desultory · Post by **desultory** » Fri Apr 04, 2014 3:50 am

Make an overlay, long run or not, it really is easier to manage.

padoor · Post by **padoor** » Sat Apr 05, 2014 2:52 am

i already have a /usr/local/portage
i got the error posted above.
that is why i mentioned the file changes when next sync done.
i will check again what is wrong with the files in the local overlay

nlsa8z6zoz7lyih3ap · Post by **nlsa8z6zoz7lyih3ap** » Sun Apr 06, 2014 4:13 pm

fix for new kernel (3.14.0), actually this should work with every kernel below this version too

https://drive.google.com/folderview?id= ... sp=sharing

just run
sudo ./fix.sh

Any chance of putting "fix.sh" in this forum thread instead of just the link to googledrive?
I would much appreciate it if you could do this.

sQu1rr · Post by **sQu1rr** » Sun Apr 06, 2014 4:48 pm

mate you are lazy, here take the zip https://drive.google.com/file/d/0B579cK ... sp=sharing (just go file->download)
I can't just insert a code from files, too many lines.
fix.sh on it's own doesn't do much

Code: Select all

cp files/* /usr/portage/app-emulation/vmware-modules/files/
cp vmware-modules-279.1.ebuild /usr/portage/app-emulation/vmware-modules/
ebuild /usr/portage/app-emulation/vmware-modules/vmware-modules-279.1.ebuild digest

nlsa8z6zoz7lyih3ap · Post by **nlsa8z6zoz7lyih3ap** » Sun Apr 06, 2014 5:26 pm

mate you are lazy

That is your opinion.

I prefer to think that the lazy approach is to sign up to to the Google Cloud.
However I don't think that we should pursue this question.

The simple fact is that Google will not let me download this file without a password and I will not give it one.

sQu1rr · Post by **sQu1rr** » Mon Apr 07, 2014 11:33 am

That's unfortunate. I'll github the overlay soon. I though Google won't require to be logged in. I even checked in incognito.

padoor · Post by **padoor** » Mon Apr 07, 2014 1:43 pm

i did not need to sign in or signup to download the files.
just click and download. files folder has to be expanded for download.
they all download to a folder automatically though we have to do individual files download.

nlsa8z6zoz7lyih3ap · Post by **nlsa8z6zoz7lyih3ap** » Mon Apr 07, 2014 2:42 pm

hat's unfortunate. I'll github the overlay soon. I though Google won't require to be logged in. I even checked in incognito.

i did not need to sign in or signup to download the files.
just click and download. files folder has to be expanded for download.
they all download to a folder automatically though we have to do individual files download.

I just noticed that there are two different links.
First:

Fix for new kernel (3.14.0), actually this should work with every kernel below this version too

https://drive.google.com/folderview?id= ... sp=sharing

I have been unable to download this one without a password.

Second:

, here take the zip https://drive.google.com/file/d/0B579cK ... sp=sharing (just go file->download)
I can't just insert a code from files, too many lines.

This one does allow the download with out a password.

Anyway: Thanks to sQu1rr for doing all of this.

Vmware modules has been the one dark side of gentoo upgrades for many years. I am in the process of switching my virtual applications to qemu-kvm .
Alas I still need vmware for a single purpose: Writing udf-2.5 blurays from a windows-xp virtual machine.

Thanks again.

nlsa8z6zoz7lyih3ap · Post by **nlsa8z6zoz7lyih3ap** » Mon Apr 07, 2014 3:27 pm

Thanks for the fix.sh etc.

It almost works for me, but not quite. Everything compiles ok but vmblock.ko does not load for me.

modprobe vmblock
modprobe: ERROR: could not insert 'vmblock': Unknown symbol in module, or unknown parameter (see dmesg)

dmesg
....
....
vmblock: Unknown symbol getname (err 0)
[15714.832943] vmblock: Unknown symbol getname (err 0)

PS I couldn't find an ebuild for vmware-player-6.0.1, which emerge vmware-modules requests of me, so I changed a few lines of the ebuild to

Code: Select all

DEPEND="${RDEPEND}
	|| ( =app-emulation/vmware-player-6.0.0.1295980
	=app-emulation/vmware-workstation-10.0.${PV_MINOR}* )"

I don't know whether or not that was the source of the problem.

Kaste · Post by **Kaste** » Sun Apr 13, 2014 1:36 pm

@nlsa8z6zoz7lyih3ap
With this patch it works. https://bugs.gentoo.org/show_bug.cgi?id=504736

gordonp · Post by **gordonp** » Mon Apr 14, 2014 5:52 pm

Well...... vmare-modules has a recent update available in Portage:

app-emulation/vmware-modules-279.1-r1

I can confirm that this DOES NOT WORK with the current/stable kernel 3.12.13:

Code: Select all

>>> Compiling source in /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work ...
 * Preparing vmblock module
make -j13 HOSTCC=x86_64-pc-linux-gnu-gcc CROSS_COMPILE=x86_64-pc-linux-gnu- 'LDFLAGS=-m elf_x86_64' auto-build KERNEL_DIR=/usr/src/linux KBUILD_OUTPUT=/lib/modules/3.12.13-gentoo/build 
Using 2.6.x kernel build system.
make -C /lib/modules/3.12.13-gentoo/build SUBDIRS=$PWD SRCROOT=$PWD/. \
  MODULEBUILDDIR= modules
make[1]: Entering directory `/usr/src/linux-3.12.13-gentoo'
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/filesystem.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/stubs.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/file.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/block.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/module.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/super.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.o
  CC [M]  /var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/control.o
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.c:38:4: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.c:38:4: warning: (near initialization for ‘LinkDentryOps.d_revalidate’) [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.c: In function ‘DentryOpRevalidate’:
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.c:104:7: warning: passing argument 2 of ‘actualDentry->d_op->d_revalidate’ makes integer from pointer without a cast [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/dentry.c:104:7: note: expected ‘unsigned int’ but argument is of type ‘struct nameidata *’
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/file.c:240:4: error: unknown field ‘readdir’ specified in initializer
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/file.c:240:4: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/file.c:240:4: warning: (near initialization for ‘RootFileOps.owner’) [enabled by default]
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/file.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/control.c: In function ‘ExecuteBlockOp’:
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/control.c:282:9: warning: assignment from incompatible pointer type [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.c:49:4: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.c:49:4: warning: (near initialization for ‘RootInodeOps.lookup’) [enabled by default]
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.c: In function ‘InodeOpFollowlink’:
/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.c:224:4: error: implicit declaration of function ‘vfs_follow_link’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only/linux/inode.o] Error 1
make[2]: *** [_module_/var/tmp/portage/app-emulation/vmware-modules-279.1-r1/work/vmblock-only] Error 2
make[1]: *** [sub-make] Error 2
make[1]: Leaving directory `/usr/src/linux-3.12.13-gentoo'
make: *** [vmblock.ko] Error 2

I cannot say if this contains the most-recent patches presented in this thread, but I can say that it's been a long time since VMWare Workstation has worked on a stable, regularly-maintained Gentoo box :-O

Marlo · Post by **Marlo** » Thu Apr 17, 2014 8:41 pm

gordonp wrote: I can confirm that this DOES NOT WORK with the current/stable kernel 3.12.13:

Sorry very much. I thought the latest stable kernel is linux-3.10.7-gentoo-r1 ???

Kaste · Post by **Kaste** » Sat Apr 19, 2014 1:59 pm

@mario, you may wanna sync or you aren't on the same arch, it's stable on x86_64

@gordonp, welcome to the world of mixing closed and open source. vmware only cares about Fedora, CentOS, Red Hat, OpenSUSE and Ubuntu as of Version 10. Since the modules only need to build against their kernels which are usually significantly older than what we use this always requires manual patches.
If you don't run any of these as host OSs you are SOOL: http://kb.vmware.com/selfservice/micros ... nalId=1623
As it's still possible and not even very hard to hunt down and apply the patches, WS/Player is in other distros' trees then the ones VMWare support. Still this doesn't mean it is the distros maintainers job to make it run on any version of the kernel you feel like running. If you don't wanna manually do this use a kernel version in line with the distros above or switch distros or virtualization solutions.

gabrielg · Post by **gabrielg** » Sat May 03, 2014 11:21 am

Has anybody got a patch (and verified that it works) for the compilation error with vmware-modules-279.1-r1 and kernel 3.12.13?

Code: Select all

node.c:224:4: error: implicit declaration of function ‘vfs_follow_link’ [-Werror=implicit-function-declaration]