
This would actually be abuse of the vanilla flag and you only need the branding USE-flag anyway (vanilla USE flag disables patches on packages supporting it).Deathwing00 wrote:Hi fellow users!
An idea of common Gentoo branding on various applications has emerged. Before proceeding with design contests and stuff like that, I'd like to ask you if you would prefer those branding Gentoo images to be on by default or off by default.
If we want branding on by default, the ebuilds will make use of the 'vanilla' USE flag. If the 'vanilla' USE flag is not set, branding will get installed.
On the other hand, if we want branding off by default, ebuilds will check whether the 'branding' use flag is enabled.



+++Kloeri wrote: This would actually be abuse of the vanilla flag and you only need the branding USE-flag anyway (vanilla USE flag disables patches on packages supporting it).
This can all be supported by the branding flag which can be enabled or disabled by users regardless of any default value in profiles.
And I'd definitely like branding to be off by default
I love my branding.Deathwing00 wrote:So far, I am amused at the fact that most Gentoo developers do support the idea on the other hand.
A good example is the gnome-session ebuild. Here are the relevant snippets:Finally, someone commented above that it would be adding unecessary stuff to be downloaded. Well, I have to say that the idea is that branding comes in a separate tarball (as is obvious) and only gets downloaded if the branding use flag is turned on.
Code: Select all
SRC_URI="${SRC_URI}
branding? ( mirror://gentoo/gentoo-splash.png )"
IUSE="branding"
src_install() {
# Our own splash for world domination
if use branding ; then
insinto /usr/share/pixmaps/splash/
doins ${DISTDIR}/gentoo-splash.png
fi
}



No problem here. It is possible to create additional package, kde-gentoo-branding for example, and make our "target" package depend on it when "branding" USE-flag is set.dirtyepic wrote:this has been discussed many many times before, always with the same result: one of our primary policies in Gentoo is to keep our packages as close to upstream as possible. patches that add features or functionality are supposed to be sent upstream for inclusion, rather than being implemented in our tree, and brandings fall under this.

I would go one step further and separate the branding/theme packages completely from the base package (if possible). So `USE="kde emerge" gentoo-branding` will build 'n install the kde-related gentoo branding/themes._ph wrote:No problem here. It is possible to create additional package, kde-gentoo-branding for example, and make our "target" package depend on it when "branding" USE-flag is set.