Hacked mozilla-firefox-1.5-r4 ebuild ?

Message

tuxfan · Post by **tuxfan** » Sat Dec 31, 2005 6:17 pm

Hi,

today I had a look into the mozilla-firefox-1.5-r4.ebuild and found the following line:

CPPFLAGS="${CPPFLAGS} -DARON_WAS_HERE" \

Does it mean that this ebuild was changed by someone named ARON or it is all ok?

jedsen · Post by **jedsen** » Sun Jan 01, 2006 1:21 pm

Looks like Aron Griffs is the ebuild maintainer for mozilla, firefox and thunderbird:
http://planet.gentoo.org/developers/agriffis
I think it has something to do with the branding? That's why the build shows up as Deer Park -- he hasn't the branding working correctly.

frenkel · Post by **frenkel** » Sun Jan 01, 2006 1:24 pm

jedsen wrote:Looks like Aron Griffs is the ebuild maintainer for mozilla, firefox and thunderbird:
http://planet.gentoo.org/developers/agriffis
I think it has something to do with the branding? That's why the build shows up as Deer Park -- he hasn't the branding working correctly.

No, he just isn't allowed to use the official branding.

UncleOwen · Post by **UncleOwen** » Sun Jan 01, 2006 2:13 pm

erm, wtf? why???

Voltago · Post by **Voltago** » Sun Jan 01, 2006 3:01 pm

Because the mozilla people don't allow the usage of their trademarked names for anything that isn't built by themselves. You can fix this by using this extension
https://addons.mozilla.org/extensions/m ... on=firefox
and brand your browser Mozilla Moongoose or whatever.

nxsty · Post by **nxsty** » Sun Jan 01, 2006 3:19 pm

What? So all distributions that packs firefox will have to create their own names?

EDIT:
Would it be illegal to change the ebuild to pass --enable-official-branding? Would the mozilla foundation sue me?

frenkel · Post by **frenkel** » Sun Jan 01, 2006 3:23 pm

nxsty wrote:What? So all distributions that packs firefox will have to create their own names?

EDIT:
Would it be illegal to change the ebuild to pass --enable-official-branding? Would the mozilla foundation sue me?

It would be illegal if it was put in the official portage tree. However, you can put your own ebuild in an overlay and use that (I do).

nxsty · Post by **nxsty** » Sun Jan 01, 2006 3:37 pm

I think this is a weird move by the mozilla foundation. It will just cause confusion if the browser has different names in each distribution that ships it. Just imagine redhat shipping with "redhat explorer", mandriva shipping with "mandriva browser" etc.

I wonder if the mozilla foundation would take leagal actions against gentoo if they enabled official branding.

chunderbunny · Post by **chunderbunny** » Mon Jan 02, 2006 12:19 am

Only source-based distros have to use different names. Mandrake, Redhat etc usually use the official binary from the Mozilla.org site, so no re-branding is necessary.

satanskin · Post by **satanskin** » Wed Jan 04, 2006 12:35 am

So hypothetically speaking, if one were to want to use the official branding, where would one put said --enable-official-branding (or whatever flag is required) in the ebuild? This all being hypothetical ofcourse

Arno · Post by **Arno** » Wed Jan 04, 2006 12:50 am

Add mozconfig_annotate '' --enable-official-branding in the mozconfig section:

Code: Select all

src_compile() {
[...]
   mozconfig_init
   mozconfig_config
   mozconfig_annotate '' --enable-official-branding
[...]

xtaski · Post by **xtaski** » Wed Jan 04, 2006 2:45 am

just out of curiousity... do the gentoo downloads of Deer Park source get counted in the "X Million Downloads" of Firefox?

Cl1mh4224rd · Post by **Cl1mh4224rd** » Wed Jan 04, 2006 3:55 am

It is kind of weird... Excluding hugely modified source code, Firefox is Firefox no matter who builds it. Additionally, the name that shows up in the title bar is "Mozilla Firefox". That right there identifies who built this particular instance of Firefox. If Mozilla is going to be specified in the official builds, why not just allow something like "Gentoo Firefox" for the unofficial builds?

xtaski wrote:just out of curiousity... do the gentoo downloads of Deer Park source get counted in the "X Million Downloads" of Firefox?

I seriously doubt it. How would the Mozilla Foundation keep track of that?

MmmmJoel · Post by **MmmmJoel** » Wed Jan 04, 2006 6:29 am

You'd think they'd want credit for all that code, ya know? Doesn't pain me at all -- it'll stay Deer Park for me.

wjb · Post by **wjb** » Thu Jan 05, 2006 1:24 am

I just do the enable official branding thing cos I truly hate the blue on blue icon you get if you don't. Anyone know if there is any relatively easy way to change the icon to something else other than the official one?

nxsty · Post by **nxsty** » Thu Jan 05, 2006 12:41 pm

chunderbunny wrote:Only source-based distros have to use different names. Mandrake, Redhat etc usually use the official binary from the Mozilla.org site, so no re-branding is necessary.

No they don't. They build their own patched versions. But they probably have agreements with the mozilla foundation, or they consider themselves large enough to do whatever they want. At least redhat enabled official branding, mandriva haven't updated to 1.5 yet.