View previous topic :: View next topic |
Should we remove FEATURES="candy" |
yes |
|
58% |
[ 255 ] |
no |
|
41% |
[ 184 ] |
|
Total Votes : 439 |
|
Author |
Message |
antarus Retired Dev
Joined: 16 May 2005 Posts: 77 Location: Michigan
|
Posted: Sat Apr 08, 2006 6:54 am Post subject: FEATURES="candy" |
|
|
We have a silly feature for emerge that changes the output spinner from a -\|/- repeating type deal, to a random string of characters that form a sentence. However it's rather old and I don't think it's very useful and it's rather large in terms of code. I'm wondering if anyone actually uses it or cares about it. Otherwise I was planning on just taking it out. It doesn't really affect emerge at all ( it's merely cosmetic ), so either way isn't a big deal. Mostly looking to cut out crufty code. |
|
Back to top |
|
|
placeholder Advocate
Joined: 07 Feb 2004 Posts: 2500
|
Posted: Sat Apr 08, 2006 7:33 am Post subject: |
|
|
I do not use Gentoo now, but I say remove it because I never used it when I did. |
|
Back to top |
|
|
pjp Administrator
Joined: 16 Apr 2002 Posts: 20086
|
Posted: Sat Apr 08, 2006 7:35 am Post subject: |
|
|
If removing it helps maintain useful code, then I say remove it. If it is popular enough, maybe modularize it, so it's off in a dark corner by itself. _________________ Quis separabit? Quo animo? |
|
Back to top |
|
|
Monkeh Veteran
Joined: 06 Aug 2005 Posts: 1656 Location: England
|
Posted: Sat Apr 08, 2006 7:57 am Post subject: |
|
|
If it just gets in the way, might as well get rid of it. I can't really imagine anyone wanting it anyway. |
|
Back to top |
|
|
Q-collective Advocate
Joined: 22 Mar 2004 Posts: 2071
|
Posted: Sat Apr 08, 2006 8:25 am Post subject: |
|
|
Didn't knew it existed, but now I do I'm not really interested either.
Kick it. |
|
Back to top |
|
|
amne Bodhisattva
Joined: 17 Nov 2002 Posts: 6378 Location: Graz / EU
|
Posted: Sat Apr 08, 2006 8:35 am Post subject: |
|
|
I think it's quite nice (even though i also like the spinner), what's the problem with it apart from some lines of code that aren't absolutely necessary? Does it need much maintenance or affect your work negatively in any other way? If so, scrap it. If it only annoys you by being there, but doesn't actually cause trouble, try to let it live. _________________ Dinosaur week! (Ok, this thread is so last week) |
|
Back to top |
|
|
brims Guru
Joined: 19 Apr 2004 Posts: 492 Location: Arizona
|
|
Back to top |
|
|
tsunam Retired Dev
Joined: 23 Feb 2004 Posts: 343
|
Posted: Sat Apr 08, 2006 8:51 am Post subject: |
|
|
/me puts it on the chopping block, and sneaks emerge moo out the back entrance.
*whistle* _________________ I'm not afraid of happy endings, just afraid my life wont work that way. |
|
Back to top |
|
|
Shadow Skill Veteran
Joined: 04 Dec 2004 Posts: 1023
|
Posted: Sat Apr 08, 2006 9:16 am Post subject: |
|
|
I think its kind of nice, no need to remove it unless it affects the quality of portage. _________________ Ware wa mutekinari.
Wa ga kage waza ni kanau mono nashi.
Wa ga ichigeki wa mutekinari.
"First there was nothing, so the lord gave us light. There was still nothing, but at least you could see it." |
|
Back to top |
|
|
meax Tux's lil' helper
Joined: 21 Jul 2004 Posts: 88 Location: Babylon
|
Posted: Sat Apr 08, 2006 10:54 am Post subject: |
|
|
amne wrote: | I think it's quite nice (even though i also like the spinner), what's the problem with it apart from some lines of code that aren't absolutely necessary? Does it need much maintenance or affect your work negatively in any other way? If so, scrap it. If it only annoys you by being there, but doesn't actually cause trouble, try to let it live. | +1 _________________ Bullshit makes the flowers grow and that's beautiful. |
|
Back to top |
|
|
amne Bodhisattva
Joined: 17 Nov 2002 Posts: 6378 Location: Graz / EU
|
Posted: Sat Apr 08, 2006 2:57 pm Post subject: |
|
|
tsunam wrote: | ...and sneaks emerge moo out the back entrance. |
Lynchmob, ever heard of it? _________________ Dinosaur week! (Ok, this thread is so last week) |
|
Back to top |
|
|
beatryder Veteran
Joined: 08 Apr 2005 Posts: 1138
|
Posted: Sat Apr 08, 2006 5:39 pm Post subject: |
|
|
I'd say if it makes maintaining it easier, toss it in the bit bucket. _________________ Dont make it idiot proof, make it work.
Neucode.org
<suppressed key> |
|
Back to top |
|
|
antarus Retired Dev
Joined: 16 May 2005 Posts: 77 Location: Michigan
|
Posted: Sat Apr 08, 2006 7:36 pm Post subject: |
|
|
tsunam wrote: | /me puts it on the chopping block, and sneaks emerge moo out the back entrance.
*whistle* |
haha, how many times have I been modifying emerge and just wanted to 'oopsee' delete that. I think I would get eaten alive by hundreds of users and developers alike though |
|
Back to top |
|
|
SirYes Apprentice
Joined: 15 Jan 2006 Posts: 282 Location: Lodz, Poland
|
Posted: Sat Apr 08, 2006 8:14 pm Post subject: |
|
|
No problem. Remove it if it's worth it.
Anyway, sometimes spinner grinds soo fast that nobody would be able to read any sentence during its activity. So for today's computers said functionality is near to useless. Just my opinion, though.
But OTOH, I really like this one:
Don't remove it if possible, please? _________________ My blog: In search for ultimate programming language
Last edited by SirYes on Sun Apr 09, 2006 1:43 pm; edited 2 times in total |
|
Back to top |
|
|
darker Apprentice
Joined: 24 Mar 2005 Posts: 221
|
Posted: Sat Apr 08, 2006 9:35 pm Post subject: |
|
|
Q-collective wrote: | Didn't knew it existed, but now I do I'm not really interested either.
Kick it. |
++ _________________ "I saw the code for your computer program yesterday. It looked easy. Its just a bunch of typing. And half of the words were spelt wrong. And dont get me started on your over-use of colons."
- The Pointy Haired Boss sees some actual code |
|
Back to top |
|
|
brims Guru
Joined: 19 Apr 2004 Posts: 492 Location: Arizona
|
|
Back to top |
|
|
Monkeh Veteran
Joined: 06 Aug 2005 Posts: 1656 Location: England
|
Posted: Sat Apr 08, 2006 9:45 pm Post subject: |
|
|
brims wrote: | SirYes wrote: |
I LIKE IT! Don't remove this one if possible, please? |
That is hilarious, we need a listing of all these little easter eggs. |
Code: | less /usr/bin/emerge |
|
|
Back to top |
|
|
brims Guru
Joined: 19 Apr 2004 Posts: 492 Location: Arizona
|
Posted: Sat Apr 08, 2006 11:53 pm Post subject: |
|
|
Monkeh wrote: | brims wrote: | SirYes wrote: |
I LIKE IT! Don't remove this one if possible, please? |
That is hilarious, we need a listing of all these little easter eggs. |
Code: | less /usr/bin/emerge |
|
That's not exactly a listing, it's the python code for emerge. Ya I could sit there and read through the 3,400 lines of code, but I'd rather not. _________________ Adopt an Unanswered Post
Report violations, duplicates, misplaced, etc |
|
Back to top |
|
|
Archangel1 Veteran
Joined: 21 Apr 2004 Posts: 1212 Location: Work
|
Posted: Sun Apr 09, 2006 7:06 am Post subject: |
|
|
I'm using it because I put "candy" in make.conf once to see what it looked like and never got around to removing it. If it's bloating the code a bit then I don't care.
It never actually worked *that* well anyway, it's a neat idea but it either goes far too fast or far too slowly. _________________ What are you, stupid? |
|
Back to top |
|
|
codergeek42 Bodhisattva
Joined: 05 Apr 2004 Posts: 5142 Location: Anaheim, CA (USA)
|
Posted: Sun Apr 09, 2006 7:24 am Post subject: |
|
|
I never used it. The spinner is actually rather cool. _________________ ~~ Peter: Programmer, Mathematician, STEM & Free Software Advocate, Enlightened Agent, Transhumanist, Fedora contributor
Who am I? :: EFF & FSF |
|
Back to top |
|
|
Monkeh Veteran
Joined: 06 Aug 2005 Posts: 1656 Location: England
|
Posted: Sun Apr 09, 2006 10:29 am Post subject: |
|
|
brims wrote: | Monkeh wrote: | brims wrote: | SirYes wrote: |
I LIKE IT! Don't remove this one if possible, please? |
That is hilarious, we need a listing of all these little easter eggs. |
Code: | less /usr/bin/emerge |
|
That's not exactly a listing, it's the python code for emerge. Ya I could sit there and read through the 3,400 lines of code, but I'd rather not. |
meh. emerge moo and FEATURES=candy are easy to find in it |
|
Back to top |
|
|
codergeek42 Bodhisattva
Joined: 05 Apr 2004 Posts: 5142 Location: Anaheim, CA (USA)
|
Posted: Sun Apr 09, 2006 10:32 am Post subject: |
|
|
Eek! Please don't start such large quote pyramids. Thanks. _________________ ~~ Peter: Programmer, Mathematician, STEM & Free Software Advocate, Enlightened Agent, Transhumanist, Fedora contributor
Who am I? :: EFF & FSF |
|
Back to top |
|
|
Monkeh Veteran
Joined: 06 Aug 2005 Posts: 1656 Location: England
|
Posted: Sun Apr 09, 2006 11:03 am Post subject: |
|
|
codergeek42 wrote: | Eek! Please don't start such large quote pyramids. Thanks. |
Large? That? pff.. |
|
Back to top |
|
|
PaveQ Apprentice
Joined: 11 Feb 2005 Posts: 225 Location: Finland
|
Posted: Sun Apr 09, 2006 2:20 pm Post subject: |
|
|
Quote pyramids looks fun
Once I saw something like >100 quotes inside, looked weird. Yeah, but make separate thread for those things. |
|
Back to top |
|
|
96140 Retired Dev
Joined: 23 Jan 2005 Posts: 1324
|
Posted: Sun Apr 09, 2006 3:54 pm Post subject: Re: FEATURES="candy" |
|
|
antarus wrote: | We have a silly feature for emerge that changes the output spinner from a -\|/- repeating type deal, to a random string of characters that form a sentence. |
It's not "random"; the effect is like a flashlight rapidly moving back and forth to illuminate one character at a time of the sentence "Thank you for using Gentoo" -- and there's no harm in it. (Especially since you can modify the source if you want a different message). Keep it! |
|
Back to top |
|
|
|