vlc 0.8.1 merge fails despite -mozilla

[deanpence]

I use the following in /etc/portage/package.use:

Code: Select all

media-video/vlc -xvid -mozilla dvd nls xv bidi truetype wxwindows imlib matroska faad png

And in vlc-0.8.1's ebuild, I see:

Code: Select all

# reason why:
# looks for xpidl in /usr/lib/mozilla/xpidl
# and doesn't find it there because it's
# in /usr/bin! - ChrisWhite
use mozilla && \
sed -e "s:^XPIDL = .*:XPIDL = /usr/bin/xpidl:" -i mozilla/Makefile \
|| die "could not fix XPIDL path"

Yet vlc-0.8.1's ebuild fails:

Code: Select all

vlc configuration
--------------------
vlc version           : 0.8.1
system                : linux
architecture          : i686 mmx
build flavour         : optim devel
vlc aliases           : wxvlc

You can tune the compiler flags in vlc-config.
To build vlc and its plugins, type `make'.


!!! ERROR: media-video/vlc-0.8.1 failed.
!!! Function src_compile, Line 176, Exitcode 1
!!! could not fix XPIDL path
!!! If you need support, post the topmost build error, NOT this status message.

But `use mozilla` should return a non-zero value in the ebuild. I don't understand why this is happening unless portage has deprecated (and no longer uses) /etc/portage/package.use. But I can find nothing in the man pages that say this. In fact, portage(5) still lists /etc/portage/package.use in its configuration.

Anyone know why this is happening?

[deanpence]

Well, it appears there's a bug in the ebuild:

Code: Select all

use mozilla && \
sed -e "s:^XPIDL = .*:XPIDL = /usr/bin/xpidl:" -i mozilla/Makefile \
|| die "could not fix XPIDL path"

When `use mozilla` returns non-zero, this will always execute `die "could not fix XPIDL path"`. Better to be sure about operator precedence. Here's my fix (testing now):

Code: Select all

if use mozilla ;  then
    if ! sed -e "s:^XPIDL = .*:XPIDL = /usr/bin/xpidl:" -i mozilla/Makefile
    then
        die "could not fix XPIDL path"
    fi
fi

[plate]

Cf. vlc 0.8.1 now in portage