Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
why does epatch_user does not work for syslog-ng-3.6.2 ?
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Portage & Programming
View previous topic :: View next topic  
Author Message
toralf
Advocate
Advocate


Joined: 01 Feb 2004
Posts: 2980
Location: Hamburg/Germany

PostPosted: Wed May 27, 2015 6:14 pm    Post subject: why does epatch_user does not work for syslog-ng-3.6.2 ? Reply with quote

Putting https://github.com/ihrwein/syslog-ng/commit/75dc0c6d4fffeac7a7b0461a6cdc6edd7a62c22c.patch into /etc/portage/patches/app-admin/syslog-ng-3.6.2/75dc0c6.patch won't work ( https://bpaste.net/show/2de64ad2762b ). The patch itself is fine.
But putting it into /usr/portage/app-admin/syslog-ng/files and changing the ebuild by adding
Code:
epatch "${FILESDIR}"/75dc0c6.patch
works.

(BTW it is a nasty bug which might be fixed hereby, look here for details : https://github.com/balabit/syslog-ng/issues/121#issuecomment-105953803 )
Back to top
View user's profile Send private message
czanik
n00b
n00b


Joined: 16 Jul 2012
Posts: 4

PostPosted: Thu May 28, 2015 5:36 am    Post subject: Reply with quote

syslog-ng 3.6.3 is expected to be released in the coming days and contain this fix.
--
Peter Czanik (CzP)
BalaBit IT Security / syslog-ng upstream
http://czanik.blogs.balabit.com/
https://twitter.com/PCzanik
Back to top
View user's profile Send private message
toralf
Advocate
Advocate


Joined: 01 Feb 2004
Posts: 2980
Location: Hamburg/Germany

PostPosted: Thu May 28, 2015 1:31 pm    Post subject: Reply with quote

Yep - but I still curious, why that ebuild won't work as nearly every other EAPI5 ebuild I have patches for.
Back to top
View user's profile Send private message
charles17
Veteran
Veteran


Joined: 02 Mar 2008
Posts: 1030

PostPosted: Thu May 28, 2015 2:31 pm    Post subject: Reply with quote

Did you try with /etc/portage/patches/app-admin/syslog-ng without version number?
Back to top
View user's profile Send private message
toralf
Advocate
Advocate


Joined: 01 Feb 2004
Posts: 2980
Location: Hamburg/Germany

PostPosted: Thu May 28, 2015 2:38 pm    Post subject: Reply with quote

charles17 wrote:
Did you try with /etc/portage/patches/app-admin/syslog-ng without version number?
No. The emerge log shows, that the patch was found, it just couldn't be applied.
Back to top
View user's profile Send private message
John R. Graham
Administrator
Administrator


Joined: 08 Mar 2005
Posts: 8534
Location: Somewhere over Atlanta, Georgia

PostPosted: Thu May 28, 2015 2:40 pm    Post subject: Reply with quote

toralf wrote:
Yep - but I still curious, why that ebuild won't work as nearly every other EAPI5 ebuild I have patches for.
epatch_user is a feature that must be explicitly supported by the individual ebuild. Apparently syslog-ng's ebuild does not. I suspect that epatch_user will be internalized in a future EAPI.

Edit: Correction! The call to epatch_user is there in the src_prepare() phase of the ebuild so something more complex is going on.

- John
_________________
I can confirm that I have received between 0 and 999 National Security Letters.
Back to top
View user's profile Send private message
John R. Graham
Administrator
Administrator


Joined: 08 Mar 2005
Posts: 8534
Location: Somewhere over Atlanta, Georgia

PostPosted: Thu May 28, 2015 3:44 pm    Post subject: Reply with quote

Yep; it's a bug in the ebuild. Reported to Bugzilla just now: app-admin/syslog-ng-3.6.2 ebuild bug prevents epatch_user from working.

- John
_________________
I can confirm that I have received between 0 and 999 National Security Letters.
Back to top
View user's profile Send private message
toralf
Advocate
Advocate


Joined: 01 Feb 2004
Posts: 2980
Location: Hamburg/Germany

PostPosted: Thu May 28, 2015 4:01 pm    Post subject: Reply with quote

John R. Graham wrote:
Yep; it's a bug in the ebuild. Reported to Bugzilla just now: app-admin/syslog-ng-3.6.2 ebuild bug prevents epatch_user from working.

- John
Thx John, BTW would this point to a possible improvement of epatch_user too ?
Back to top
View user's profile Send private message
John R. Graham
Administrator
Administrator


Joined: 08 Mar 2005
Posts: 8534
Location: Somewhere over Atlanta, Georgia

PostPosted: Thu May 28, 2015 4:57 pm    Post subject: Reply with quote

Possibly; however I expect the likely response to such an enhancement request would be something like, "Resolved / Wont Fix: Devs should just use it the right way." After all, the correct usage is not in any way onerous.

- John
_________________
I can confirm that I have received between 0 and 999 National Security Letters.
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Portage & Programming All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum