| View previous topic :: View next topic |
| Author |
Message |
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
 Posted: Sat Apr 01, 2006 10:36 pm Post subject: |
 |
|
| abhay wrote: | | I just compiled KDE 3.5.2 from your overlay but the side bar doesn't seem to be coming up. SidebarStyle is not working. Has someone else got it working? |
Oh, sorry. I looked at the patch again, and I found that the new sidebar was only in there half way. -_-' oops. I need to add some parts to the patch and fix a few other things with it. I'll do that when I have time.  The important thing is that the konqueror patch adds special rubberband options that were not there before.
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
 |
roderick
l33t
Joined: 11 Jul 2005
Posts: 908
Location: St. John's, NL CANADA
|
| Posted: Wed Apr 05, 2006 12:57 pm Post subject: |
|
|
| StifflerStealth wrote: | | abhay wrote: | | I just compiled KDE 3.5.2 from your overlay but the side bar doesn't seem to be coming up. SidebarStyle is not working. Has someone else got it working? |
Oh, sorry. I looked at the patch again, and I found that the new sidebar was only in there half way. -_-' oops. I need to add some parts to the patch and fix a few other things with it. I'll do that when I have time. The important thing is that the konqueror patch adds special rubberband options that were not there before.
Cheers. |
Any update on when this will be added/fixed?
Thanks.
_________________
If God were a pickle, I'd still say "no pickle on my burger".
http://roderick-greening.blogspot.com/ |
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Thu Apr 06, 2006 1:30 am Post subject: |
|
|
I have a lot in the queue of things to do. -_-' I am hoping to get to everything tomorrow night, or the weekend. I don't know when I will get to this particular patch and putting in the sidebar.
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
nbensa
l33t
Joined: 10 Jul 2002
Posts: 799
Location: Buenos Aires, Argentina
|
| Posted: Sun Apr 09, 2006 5:04 pm Post subject: |
|
|
On kdesktop:
| Code: | @@ -101,6 +95,8 @@ class KFileIVIDesktop : public KFileIVI
*/
virtual QImage *buildShadow(QPainter *p, const int align, QColor &shadowColor);
+ void FKileIVIDesktop::paintFocus(QPainter*, const QColorGroup&);
+
protected:
void setNormalImage(QImage *newImage) { delete m_normalImage; m_normalImage = newImage; };
void setSelectedImage(QImage *newImage) { delete m_selectedImage; m_selectedImage = newImage; };
|
won't compile with gcc-4.1. You need to replace it with:
| Code: | @@ -101,6 +95,8 @@ class KFileIVIDesktop : public KFileIVI
*/
virtual QImage *buildShadow(QPainter *p, const int align, QColor &shadowColor);
+ virtual void paintFocus(QPainter*, const QColorGroup&);
+
protected:
void setNormalImage(QImage *newImage) { delete m_normalImage; m_normalImage = newImage; };
void setSelectedImage(QImage *newImage) { delete m_selectedImage; m_selectedImage = newImage; };
|
I haven't had the time to test it since I still have 50+ ebuilds left  |
|
| Back to top |
|
|
smithjd15
Tux's lil' helper
Joined: 12 Mar 2003
Posts: 130
Location: Edmonton, AB, CA
|
| Posted: Sun Apr 09, 2006 9:16 pm Post subject: |
|
|
| nbensa wrote: | On kdesktop:
| Code: | @@ -101,6 +95,8 @@ class KFileIVIDesktop : public KFileIVI
*/
virtual QImage *buildShadow(QPainter *p, const int align, QColor &shadowColor);
+ void FKileIVIDesktop::paintFocus(QPainter*, const QColorGroup&);
+
protected:
void setNormalImage(QImage *newImage) { delete m_normalImage; m_normalImage = newImage; };
void setSelectedImage(QImage *newImage) { delete m_selectedImage; m_selectedImage = newImage; };
|
won't compile with gcc-4.1. You need to replace it with:
| Code: | @@ -101,6 +95,8 @@ class KFileIVIDesktop : public KFileIVI
*/
virtual QImage *buildShadow(QPainter *p, const int align, QColor &shadowColor);
+ virtual void paintFocus(QPainter*, const QColorGroup&);
+
protected:
void setNormalImage(QImage *newImage) { delete m_normalImage; m_normalImage = newImage; };
void setSelectedImage(QImage *newImage) { delete m_selectedImage; m_selectedImage = newImage; };
|
I haven't had the time to test it since I still have 50+ ebuilds left |
Can we get that in patch form so it can be included in the ebuild?
Thanks.  |
|
| Back to top |
|
|
nbensa
l33t
Joined: 10 Jul 2002
Posts: 799
Location: Buenos Aires, Argentina
|
| Posted: Mon Apr 10, 2006 2:19 am Post subject: |
|
|
Just edit | Code: | | kdesktop/files/kdebase-3.5.2-kdesktop-pertty.patch |
and change | Code: | | + void FKileIVIDesktop::paintFocus(QPainter*, const QColorGroup&); |
with | Code: | | + virtual void paintFocus(QPainter*, const QColorGroup&); |
Then run | Code: | | ebuild kdesktop-3.5.2.ebuild digest |
That's all. |
|
| Back to top |
|
|
smithjd15
Tux's lil' helper
Joined: 12 Mar 2003
Posts: 130
Location: Edmonton, AB, CA
|
| Posted: Mon Apr 10, 2006 4:30 am Post subject: |
|
|
Thanks, worked a charm.  |
|
| Back to top |
|
|
StringCheesian
l33t
Joined: 21 Oct 2003
Posts: 887
|
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Fri Apr 28, 2006 1:29 am Post subject: |
|
|
This weekend I need to update the patches, so I will include these patches. They seem to add lines as specified by the icon standards, so all icons, not just tango, would benefit from this. The bug report is confirmed, so this may be added in a later KDE version. ^^
Come to think of it. These patches should be in the main Gentoo packages, since it helps Tango work better. I think Tango is in Portage for KDE, so this should be filed under a bug report there, so it works better. Maybe you could fill a bug for tango and point to these patches and say these are needed to make tango and other ico sets work better, and this bug is confirmed on the KDE bug report ... They may include it then. ^^
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
StringCheesian
l33t
Joined: 21 Oct 2003
Posts: 887
|
| Posted: Fri Apr 28, 2006 10:42 pm Post subject: |
|
|
| StifflerStealth wrote: | | Maybe you could fill a bug for tango and point to these patches and say these are needed to make tango and other ico sets work better, and this bug is confirmed on the KDE bug report ... They may include it then. ^^ |
Looks like somebody already did: Gentoo bug #119839.
"This will be left for upstream to decide." |
|
| Back to top |
|
|
seren
Guru
Joined: 27 Aug 2005
Posts: 448
Location: Wisconsin
|
| Posted: Fri May 05, 2006 6:51 pm Post subject: |
|
|
| StifflerStealth wrote: | This weekend I need to update the patches, so I will include these patches. They seem to add lines as specified by the icon standards, so all icons, not just tango, would benefit from this. The bug report is confirmed, so this may be added in a later KDE version. ^^
Come to think of it. These patches should be in the main Gentoo packages, since it helps Tango work better. I think Tango is in Portage for KDE, so this should be filed under a bug report there, so it works better. Maybe you could fill a bug for tango and point to these patches and say these are needed to make tango and other ico sets work better, and this bug is confirmed on the KDE bug report ... They may include it then. ^^
Cheers. |
any prorgress? would be nice to use the ebuilds again, i stoped because pf sp many problems... wonder if taskara could contribute? |
|
| Back to top |
|
|
abhay
Apprentice
Joined: 30 Jul 2005
Posts: 161
|
| Posted: Thu Jun 01, 2006 2:25 pm Post subject: |
|
|
Well just a heads up. KDE 3.5.3 has been released. I hope that someone is still maintaining these patches and will bump them to the new version
http://dot.kde.org/1149112734/ |
|
| Back to top |
|
|
kmare
l33t
Joined: 20 Nov 2004
Posts: 619
Location: Thessaloniki, Greece
|
| Posted: Fri Jun 02, 2006 3:23 pm Post subject: |
|
|
The pertty patch for kdelibs applied just fine in 3.5.3 (with the xgl-kicker patch as well) and I'm compiling right now. I don't know about the other patches like konqueror, kdesktop, etc... gonna try and report back soon..
_________________
Never argue with an idiot. They will only pull you down to their level, then beat you with experience. |
|
| Back to top |
|
|
roderick
l33t
Joined: 11 Jul 2005
Posts: 908
Location: St. John's, NL CANADA
|
| Posted: Fri Jun 02, 2006 4:09 pm Post subject: |
|
|
| kmare wrote: | | The pertty patch for kdelibs applied just fine in 3.5.3 (with the xgl-kicker patch as well) and I'm compiling right now. I don't know about the other patches like konqueror, kdesktop, etc... gonna try and report back soon.. |
Just upgraded to 3.5.3 and patched kdelibs with above 2 patches. Works good from here.
I'm going to apply the patches to the rest of the as well... will report back.
_________________
If God were a pickle, I'd still say "no pickle on my burger".
http://roderick-greening.blogspot.com/ |
|
| Back to top |
|
|
kmare
l33t
Joined: 20 Nov 2004
Posts: 619
Location: Thessaloniki, Greece
|
| Posted: Fri Jun 02, 2006 4:36 pm Post subject: |
|
|
ok, every previous pertty patch (from kde 3.5.2) applied and compiled fine! Time to compile the rest of kde now...
_________________
Never argue with an idiot. They will only pull you down to their level, then beat you with experience. |
|
| Back to top |
|
|
Proton
Apprentice
Joined: 16 Mar 2003
Posts: 195
Location: Estoril, Portugal
|
| Posted: Fri Jun 02, 2006 9:23 pm Post subject: |
|
|
| kmare wrote: | | The pertty patch for kdelibs applied just fine in 3.5.3 (with the xgl-kicker patch as well) and I'm compiling right now. I don't know about the other patches like konqueror, kdesktop, etc... gonna try and report back soon.. |
I've looked everywhere for this xgl-kicker patch and I can't find it... Could anyone please point me to it? Thanks!
_________________
Sérgio @ Portugal
IST - LEIC |
|
| Back to top |
|
|
kmare
l33t
Joined: 20 Nov 2004
Posts: 619
Location: Thessaloniki, Greece
|
| Posted: Sat Jun 03, 2006 12:22 am Post subject: |
|
|
sorry.. the name of the patch is: ksystemtray-xgl.patch
I'm using it from the xgl-coffee overlay. It is mostly intended to be used on top of Xgl (else kicker doesn't behave really well) but it should work just fine on normal X as well...
PS: everything compiled just fine with pertty and kde 3.5.3! yay!
_________________
Never argue with an idiot. They will only pull you down to their level, then beat you with experience. |
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Sat Jun 03, 2006 4:10 pm Post subject: |
|
|
WARNING: Remove the kde.eclass file from your overlay.
Invisibility support has been added to the latest version of this eclass in portage. The support is very well done. Cheers to the KDE team for adding that. However, it will only work if you are using KDE 3.5.x and gcc 4.1.x. The patched eclass allows this with all versions of gcc and kde, which is really not right. So, it's best of you remove this.
I am busy working on the pertty patches right now. I will get them out later. Just thought I should mention this. I need to put the developer test on hold for this. 
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
abhay
Apprentice
Joined: 30 Jul 2005
Posts: 161
|
| Posted: Sat Jun 03, 2006 5:05 pm Post subject: |
|
|
| StifflerStealth wrote: | | I am busy working on the pertty patches right now. I will get them out later. Just thought I should mention this. I need to put the developer test on hold for this. |
Are you adding something new in these patches? Should we wait for the new patches before going for the long compile or should we go with the old patches? Will be really thankful if you could post an anticipated changelog or something |
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Sat Jun 03, 2006 11:18 pm Post subject: |
|
|
| abhay wrote: | | StifflerStealth wrote: | | I am busy working on the pertty patches right now. I will get them out later. Just thought I should mention this. I need to put the developer test on hold for this. |
Are you adding something new in these patches? Should we wait for the new patches before going for the long compile or should we go with the old patches? Will be really thankful if you could post an anticipated changelog or something |
Just use the old patches. They work fine. That will get you in the new version and then once I release it you can recompile with the new patches if you wish. The only major difference planned is the inclusion of the tango patch. I am mainly going through the patches line by line and checking the code. I am cleaning it up and making it neater and gcc 4.1.x friendly *cough*.
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Sun Jun 04, 2006 5:51 pm Post subject: |
|
|
Note: There is a bug in binutils. It makes compiling with --as-needed very difficult with this release, so therefore I included a patched binutils from flameeyes overlay. He says that it's suppose to cure the problem. So, be very careful and exercise caution when using --as-needed. This only applies to the new pre-releases of binutils. If you are using stable you should have no trouble. So, if you are using the pre-releases of 2.17, then recompile that first.
Okay, the tango patches are in. If you want support for icon sets that use the tango standard naming scheme then you need to make sure to recompile the packages that include tango: kdelibs and kdialog.
Also, I have good news. I was looking at the code for that new sidebar thing and it looks possible to rewrite it a bit to be 3.5.x compatible. This is why it has taken this long to release this package. I wanted to get that done for this release, but I tired. I want to upgrade to the new kde. It will take a bit to rewrite the code. -_-
I don't know how well the patches work since my machine is not done compiling yet.
http://sourceforge.net/project/showfiles.php?group_id=126070
Enjoy
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
vipernicus
Veteran
Joined: 17 Jan 2005
Posts: 1462
Location: Your College IT Dept.
|
| Posted: Sun Jun 04, 2006 10:00 pm Post subject: |
|
|
| StifflerStealth wrote: | Note: There is a bug in binutils. It makes compiling with --as-needed very difficult with this release, so therefore I included a patched binutils from flameeyes overlay. He says that it's suppose to cure the problem. So, be very careful and exercise caution when using --as-needed. This only applies to the new pre-releases of binutils. If you are using stable you should have no trouble. So, if you are using the pre-releases of 2.17, then recompile that first.
Okay, the tango patches are in. If you want support for icon sets that use the tango standard naming scheme then you need to make sure to recompile the packages that include tango: kdelibs and kdialog.
Also, I have good news. I was looking at the code for that new sidebar thing and it looks possible to rewrite it a bit to be 3.5.x compatible. This is why it has taken this long to release this package. I wanted to get that done for this release, but I tired. I want to upgrade to the new kde. It will take a bit to rewrite the code. -_-
I don't know how well the patches work since my machine is not done compiling yet.
http://sourceforge.net/project/showfiles.php?group_id=126070
Enjoy |
About your binutils patch, that wasn't the final version they ended up using, use this one instead:
| Code: | --- ld/emultempl/elf32.em 30 May 2006 16:45:32 -0000 1.165
+++ ld/emultempl/elf32.em 2 Jun 2006 16:20:18 -0000
@@ -148,7 +148,7 @@ cat >>e${EMULATION_NAME}.c <<EOF
static struct bfd_link_needed_list *global_needed;
static struct stat global_stat;
-static bfd_boolean global_found;
+static lang_input_statement_type *global_found;
static struct bfd_link_needed_list *global_vercheck_needed;
static bfd_boolean global_vercheck_failed;
@@ -229,12 +229,14 @@ gld${EMULATION_NAME}_stat_needed (lang_i
const char *suffix;
const char *soname;
- if (global_found)
+ if (global_found != NULL)
return;
if (s->the_bfd == NULL)
return;
- if (s->as_needed
- && (bfd_elf_get_dyn_lib_class (s->the_bfd) & DYN_AS_NEEDED) != 0)
+
+ /* If this input file was an as-needed entry, and wasn't found to be
+ needed at the stage it was linked, then don't say we have loaded it. */
+ if ((bfd_elf_get_dyn_lib_class (s->the_bfd) & DYN_AS_NEEDED) != 0)
return;
if (bfd_stat (s->the_bfd, &st) != 0)
@@ -254,7 +256,7 @@ gld${EMULATION_NAME}_stat_needed (lang_i
&& st.st_ino == global_stat.st_ino
&& st.st_ino != 0)
{
- global_found = TRUE;
+ global_found = s;
return;
}
@@ -398,9 +400,9 @@ cat >>e${EMULATION_NAME}.c <<EOF
if (trace_file_tries)
info_msg (_("found %s at %s\n"), soname, name);
- global_found = FALSE;
+ global_found = NULL;
lang_for_each_input_file (gld${EMULATION_NAME}_stat_needed);
- if (global_found)
+ if (global_found != NULL)
{
/* Return TRUE to indicate that we found the file, even though
we aren't going to do anything with it. */
@@ -809,49 +811,45 @@ cat >>e${EMULATION_NAME}.c <<EOF
static void
gld${EMULATION_NAME}_check_needed (lang_input_statement_type *s)
{
- if (global_found)
+ const char *soname;
+
+ /* Stop looking if we've found a loaded lib. */
+ if (global_found != NULL
+ && (bfd_elf_get_dyn_lib_class (global_found->the_bfd)
+ & DYN_AS_NEEDED) == 0)
return;
- /* If this input file was an as-needed entry, and wasn't found to be
- needed at the stage it was linked, then don't say we have loaded it. */
- if (s->as_needed
- && (s->the_bfd == NULL
- || (bfd_elf_get_dyn_lib_class (s->the_bfd) & DYN_AS_NEEDED) != 0))
+ if (s->filename == NULL || s->the_bfd == NULL)
+ return;
+
+ /* Don't look for a second non-loaded as-needed lib. */
+ if (global_found != NULL
+ && (bfd_elf_get_dyn_lib_class (s->the_bfd) & DYN_AS_NEEDED) != 0)
return;
- if (s->filename != NULL)
+ if (strcmp (s->filename, global_needed->name) == 0)
{
- const char *f;
+ global_found = s;
+ return;
+ }
- if (strcmp (s->filename, global_needed->name) == 0)
+ if (s->search_dirs_flag)
+ {
+ const char *f = strrchr (s->filename, '/');
+ if (f != NULL
+ && strcmp (f + 1, global_needed->name) == 0)
{
- global_found = TRUE;
+ global_found = s;
return;
}
-
- if (s->search_dirs_flag)
- {
- f = strrchr (s->filename, '/');
- if (f != NULL
- && strcmp (f + 1, global_needed->name) == 0)
- {
- global_found = TRUE;
- return;
- }
- }
}
- if (s->the_bfd != NULL)
+ soname = bfd_elf_get_dt_soname (s->the_bfd);
+ if (soname != NULL
+ && strcmp (soname, global_needed->name) == 0)
{
- const char *soname;
-
- soname = bfd_elf_get_dt_soname (s->the_bfd);
- if (soname != NULL
- && strcmp (soname, global_needed->name) == 0)
- {
- global_found = TRUE;
- return;
- }
+ global_found = s;
+ return;
}
}
@@ -904,9 +902,11 @@ gld${EMULATION_NAME}_after_open (void)
/* See if this file was included in the link explicitly. */
global_needed = l;
- global_found = FALSE;
+ global_found = NULL;
lang_for_each_input_file (gld${EMULATION_NAME}_check_needed);
- if (global_found)
+ if (global_found != NULL
+ && (bfd_elf_get_dyn_lib_class (global_found->the_bfd)
+ & DYN_AS_NEEDED) == 0)
continue;
n.by = l->by;
@@ -915,6 +915,13 @@ gld${EMULATION_NAME}_after_open (void)
if (trace_file_tries)
info_msg (_("%s needed by %B\n"), l->name, l->by);
+ if (global_found != NULL)
+ {
+ nn.name = global_found->filename;
+ if (gld${EMULATION_NAME}_try_needed (&nn, TRUE))
+ continue;
+ }
+
/* We need to find this file and include the symbol table. We
want to search for the file in the same way that the dynamic
linker will search. That means that we want to use |
This is the patch they commited to binutils-2.17.x
_________________
Viper-Sources Maintainer || nesl247 Projects || vipernicus.org blog |
|
| Back to top |
|
|
StifflerStealth
Retired Dev
Joined: 03 Jul 2002
Posts: 968
|
| Posted: Sun Jun 04, 2006 11:05 pm Post subject: |
|
|
Ah!!! Thanks. I will add that as soon as all the things are done compiling. I am on Windows now. <_< For some reason KDE crashes when I compile certain programs but not others. :S So I need to be in the console to compile. -_- Ah well. Thanks again.
So, for now, use the the -r archive, copy over this patch, and redigest. I am trying to include everything one needs for this. Since there is that bug in Binutils, I would like to help people out with the binutils overlay, which is why I included this. Once it's fixed, I can remove it. So, that's why it's there. I hope that explains why I did that. ^^
Cheers.
_________________
Nothing to read in this sig. Move along. |
|
| Back to top |
|
|
abhay
Apprentice
Joined: 30 Jul 2005
Posts: 161
|
| Posted: Mon Jun 05, 2006 3:59 am Post subject: |
|
|
this new patch for binutils doesn't apply here with 2.16.93. it bails out with an error at the time of patching. the patch from flameeye's overlay applied fine and compiled fine.
also, all the older patches (some minor adjustment in kdesktop patch for GCC 4.1.1) applied and compiled fine with -Bdirect, --as-needed and -fvisibility=hidden. Kaffeine doesn't seem to be compiling with visibility hidden so i have left it alone for now |
|
| Back to top |
|
|
vipernicus
Veteran
Joined: 17 Jan 2005
Posts: 1462
Location: Your College IT Dept.
|
|
| Back to top |
|
|
|
|
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
|
|
Unsupported Software
