Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
www-client/firefox-124.0.1 PGO build failing
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Portage & Programming
View previous topic :: View next topic  
Author Message
Wadewilson
n00b
n00b


Joined: 09 Nov 2022
Posts: 31

PostPosted: Fri Mar 29, 2024 11:34 am    Post subject: www-client/firefox-124.0.1 PGO build failing Reply with quote

www-client/firefox-124.0.1 build is failing. Started facing this issue with firefox 123.

Crash stack trace:
Code:
97:04.09  #0 0x00007f18537624fe llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xb1d4fe)
97:04.09  #1 0x00007f185372c4ab llvm::sys::RunSignalHandlers() (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xae74ab)
97:04.09  #2 0x00007f185372c619 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xae7619)
97:04.09  #3 0x00007f1852809b50 (/lib64/libc.so.6+0x3bb50)
97:04.09  #4 0x00007f18548e8dab llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::slpvectorizer::BoUpSLP::TreeEntry*) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1ca3dab)
97:04.09  #5 0x00007f18548eb8fb llvm::slpvectorizer::BoUpSLP::vectorizeOperand(llvm::slpvectorizer::BoUpSLP::TreeEntry*, unsigned int) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1ca68fb)
97:04.10  #6 0x00007f18548e938d llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::slpvectorizer::BoUpSLP::TreeEntry*) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1ca438d)
97:04.10  #7 0x00007f18548ec268 llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::MapVector<llvm::Value*, llvm::SmallVector<llvm::Instruction*, 2u>, llvm::DenseMap<llvm::Value*, unsigned int, llvm::DenseMapInfo<llvm::Value*, void>, llvm::detail::DenseMapPair<llvm::Value*, unsigned int>>, llvm::SmallVector<std::pair<llvm::Value*, llvm::SmallVector<llvm::Instruction*, 2u>>, 0u>> const&, llvm::SmallVectorImpl<std::pair<llvm::Value*, llvm::Value*>>&, llvm::Instruction*) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1ca7268)
97:04.10  #8 0x00007f18548eec8d llvm::slpvectorizer::BoUpSLP::vectorizeTree() (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1ca9c8d)
97:04.10  #9 0x00007f18548f1379 llvm::SLPVectorizerPass::tryToVectorizeList(llvm::ArrayRef<llvm::Value*>, llvm::slpvectorizer::BoUpSLP&, bool) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1cac379)
97:04.10 #10 0x00007f185654fc4e (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x390ac4e)
97:04.11 #11 0x00007f18548fa31a llvm::SLPVectorizerPass::vectorizeChainsInBlock(llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1cb531a)
97:04.11 #12 0x00007f18548fbc1b llvm::SLPVectorizerPass::runImpl(llvm::Function&, llvm::ScalarEvolution*, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo*, llvm::AAResults*, llvm::LoopInfo*, llvm::DominatorTree*, llvm::AssumptionCache*, llvm::DemandedBits*, llvm::OptimizationRemarkEmitter*) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1cb6c1b)
97:04.11 #13 0x00007f18548fbef1 llvm::SLPVectorizerPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1cb6ef1)
97:04.11 #14 0x00007f18563c98f1 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x37848f1)
97:04.11 #15 0x00007f18538e24bf llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xc9d4bf)
97:04.12 #16 0x00007f18555394a1 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x28f44a1)
97:04.12 #17 0x00007f18538eb33a llvm::ModuleToFunctionPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xca633a)
97:04.12 #18 0x00007f1855539451 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x28f4451)
97:04.12 #19 0x00007f18538e1ad2 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xc9cad2)
97:04.12 #20 0x00007f1854be06b8 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1f9b6b8)
97:04.12 #21 0x00007f1854be1af0 llvm::lto::opt(llvm::lto::Config const&, llvm::TargetMachine*, unsigned int, llvm::Module&, bool, llvm::ModuleSum
97:04.12 #22 0x00007f1854be28ae (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1f9d8ae)
97:04.13 #23 0x00007f1854be58e8 llvm::lto::thinBackend(llvm::lto::Config const&, unsigned int, std::function<llvm::Expected<std::unique_ptr<llvm::CachedFileStream, std::default_delete<llvm::CachedFileStream>>> (unsigned int, llvm::Twine const&)>, llvm::Module&, llvm::ModuleSummaryIndex const&, llvm::StringMap<std::unordered_set<unsigned long, std::hash<unsigned long>, std::equal_to<unsigned long>, std::allocator<unsigned long>>, llvm::MallocAllocator> const&, llvm::DenseMap<unsigned long, llvm::GlobalValueSummary*, llvm::DenseMapInfo<unsigned long, void>, llvm::detail::DenseMapPair<unsigned long, llvm::GlobalValueSummary*>> const&, llvm::MapVector<llvm::StringRef, llvm::BitcodeModule, llvm::DenseMap<llvm::StringRef, unsigned int, llvm::DenseMapInfo<llvm::StringRef, void>, llvm::detail::DenseMapPair<llvm::StringRef, unsigned int>>, llvm::SmallVector<std::pair<llvm::StringRef, llvm::BitcodeModule>, 0u>>*, std::vector<unsigned char, std::allocator<unsigned char>> const&) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1fa08e8)
97:04.13 #24 0x00007f1854be5c92 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1fa0c92)
97:04.13 #25 0x00007f1854be61dd (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0x1fa11dd)
97:04.13 #26 0x00007f185367efc2 (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xa39fc2)
97:04.13 #27 0x00007f18536d1884 llvm::ThreadPool::processTasks(llvm::ThreadPoolTaskGroup*) (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xa8c884)
97:04.13 #28 0x00007f185370ed6e (/usr/lib/llvm/17/bin/../lib64/libLLVM-17.so+0xac9d6e)
97:04.13 #29 0x00007f1852856b61 (/lib64/libc.so.6+0x88b61)
97:04.13 #30 0x00007f18528d2898 (/lib64/libc.so.6+0x104898)
97:04.18 Failed to hack libxul.so: basic_ios::clear: iostream error
97:04.18 x86_64-pc-linux-gnu-clang++-17: error: linker command failed with exit code 1 (use -v to see invocation)
97:04.18 gmake[4]: *** [/var/tmp/portage/www-client/firefox-124.0.1/work/firefox-124.0.1/config/rules.mk:541: libxul.so] Error 1
97:04.18 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-124.0.1/work/firefox_build/toolkit/library/build'
97:04.18 gmake[3]: *** [/var/tmp/portage/www-client/firefox-124.0.1/work/firefox-124.0.1/config/recurse.mk:72: toolkit/library/build/target] Error 2
97:04.18 gmake[3]: Leaving directory '/var/tmp/portage/www-client/firefox-124.0.1/work/firefox_build'
97:04.18 gmake[2]: *** [/var/tmp/portage/www-client/firefox-124.0.1/work/firefox-124.0.1/config/recurse.mk:34: compile] Error 2
97:04.18 gmake[2]: Leaving directory '/var/tmp/portage/www-client/firefox-124.0.1/work/firefox_build'
97:04.18 gmake[1]: *** [/var/tmp/portage/www-client/firefox-124.0.1/work/firefox-124.0.1/config/rules.mk:361: default] Error 2
97:04.18 gmake[1]: Leaving directory '/var/tmp/portage/www-client/firefox-124.0.1/work/firefox_build'
97:04.18 gmake: *** [client.mk:60: build] Error 2
97:04.18 W 179 compiler warnings present.
 * ERROR: www-client/firefox-124.0.1::gentoo failed (compile phase):
 *   Failed to run './mach build --verbose'
 *
 * Call stack:
 *     ebuild.sh, line  136:  Called src_compile
 *   environment, line 5180:  Called virtx './mach' 'build' '--verbose'
 *   environment, line 6659:  Called die
 * The specific snippet of code:
 *       [[ ${retval} -ne 0 ]] && die "Failed to run '$@'";
 *




Quote:
emerge --info '=www-client/firefox-124.0.1::gentoo'

Code:

Portage 3.0.63 (python 3.11.8-final-0, default/linux/amd64/17.1/desktop, gcc-13, glibc-2.39-r2, 6.8.0-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-6.8.0-gentoo-x86_64-Intel-R-_Core-TM-_i5-10300H_CPU_@_2.50GHz-with-glibc2.39
KiB Mem:    24491392 total,   1781932 free
KiB Swap:   16777212 total,  16741116 free
Timestamp of repository gentoo: Fri, 29 Mar 2024 02:00:00 +0000
Head commit of repository gentoo: 0ff7a9af7dc83572df7a8244a19b86f2b8723a15
Timestamp of repository guru: Thu, 28 Mar 2024 22:48:29 +0000
Head commit of repository guru: c5e79fe81af3fe8b7c90123a482acdd6fe7196ab

Timestamp of repository waffle-builds: Tue, 26 Mar 2024 18:03:36 +0000
Head commit of repository waffle-builds: 16f11fbd5174d4c4c6930ec8f29029dd5473a463

sh bash 5.2_p26
ld GNU ld (Gentoo 2.42 p3) 2.42.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.72-r1::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.29.0::gentoo
dev-build/libtool:         2.4.7-r4::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.4.0-r1::gentoo
dev-lang/perl:             5.38.2-r2::gentoo
dev-lang/python:           3.11.8_p1::gentoo, 3.12.2_p1::gentoo
dev-lang/rust-bin:         1.76.0::gentoo
sys-apps/baselayout:       2.15::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.42-r1::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo, 18.1.2::gentoo
sys-devel/gcc:             13.2.1_p20240210::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             17.0.6::gentoo, 18.1.2::gentoo
sys-devel/llvm:            17.0.6::gentoo, 18.1.2::gentoo
sys-kernel/linux-headers:  6.7-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.39-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts:
    sync-rsync-verify-metamanifest: yes

greninja
    location: /var/db/repos/greninja
    masters: gentoo
    volatile: False

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo
    volatile: False

waffle-builds
    location: /var/db/repos/waffle-builds
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/waffle-builds.git
    masters: gentoo
    volatile: False

Binary Repositories:

gentoobinhost
    priority: 1
    sync-uri: https://gentoo.osuosl.org/releases/amd64/binpackages/17.1/x86-64

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=skylake -mtune=skylake -O2 -pipe -fomit-frame-pointer -flto"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=skylake -mtune=skylake -O2 -pipe -fomit-frame-pointer -flto"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=skylake -mtune=skylake -O2 -pipe -fomit-frame-pointer -flto"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync merge-wait multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync warn-on-large-env xattr"
FFLAGS="-march=skylake -mtune=skylake -O2 -pipe -fomit-frame-pointer -flto"
GENTOO_MIRRORS="https://mirrors.nxtgen.com/gentoo-mirror/gentoo-source/     https://ftp.jaist.ac.jp/pub/Linux/Gentoo/     https://mirror.yandex.ru/gentoo-distfiles/     https://gentoo.osuosl.org/     https://mirrors.mit.edu/gentoo-distfiles/"
LANG="en_IN.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j9"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl acpi alsa amd64 bluetooth branding bzip2 cairo cli crypt dbus dri dts elogind encode exif flac fortran gdbm gif gtk gui iconv icu intel ipv6 jpeg lcms libinput libnotify libtirpc lto mad mng mp3 mp4 mpeg multilib ncurses nvenc ogg opengl openmp pam pango pcre pdf pgo png policykit pulseaudio readline sdl seccomp sound spell split-usr ssl startup-notification svg test-rust truetype udev udisks unicode upower usb vaapi vdpau vorbis vulkan wxwidgets x264 xattr xcb xft xml xv xvid zlib zsh-completion zstd" ABI_X86="64" ADA_TARGET="gcc_12" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="intel nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS




Quote:
emerge -pqv '=www-client/firefox-124.0.1::gentoo'

Code:
[ebuild     U ] www-client/firefox-124.0.1 [123.0.1-r1] USE="X clang dbus gmp-autoupdate hardened hwaccel jumbo-build lto pgo* pulseaudio system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-webp -debug -eme-free -geckodriver -jack -libproxy -openh264 (-selinux) -sndio -system-png (-system-python-libs) -telemetry (-valgrind) -wayland -wifi" L10N="hi kn ru ta te -ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -de -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fur -fy -ga -gd -gl -gn -gu -he -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ro -sc -sco -si -sk -sl -son -sq -sr -sv -szl -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW" LLVM_SLOT="17 -16"

 * IMPORTANT: 2 news items need reading for repository 'gentoo'.
 * Use eselect news read to view new items.




Before that I had never faced this issue. I had installed lutris before the update to firefox 123 and removed it (lutris) and its dependencies after some days. After that when I tried to install firefox I am facing this issue. I don't think this has some connection but multiple packages were upgraded to support 32 bit when I installed lutris and when I uninstalled I made sure they were switched back to supporting only 64 bit as it was originally done before installing lutris.


Since, this was a major change I did, I thought it might have something to do with the compilation error.


There is also a bug raised for this on firefox 123 : https://bugs.gentoo.org/925101

But not much progress it seems.

Any idea what could be the issue?

I have a very identical system to the user on whose system the build is not failing as mentioned in the above bug. https://bugs.gentoo.org/attachment.cgi?id=887474&action=edit
Back to top
View user's profile Send private message
Kresni
n00b
n00b


Joined: 30 Apr 2023
Posts: 22
Location: 46E 53N

PostPosted: Fri Mar 29, 2024 7:47 pm    Post subject: Reply with quote

The following patch (also mentioned in the gentoo bug report) used to work for me on the version 123.0 , have you tried compiling with this?

https://raw.githubusercontent.com/canonical/firefox-snap/stable/patches/pgo-with-software-webrender.patch

You can manually patch it yourself or put it inside /etc/portage/patches.

Also, if performance is not the main concern, I believe that it can be compiled with +pgo with using GCC, which would require you to disable the clang use flag.
_________________
~~~~
Back to top
View user's profile Send private message
Wadewilson
n00b
n00b


Joined: 09 Nov 2022
Posts: 31

PostPosted: Sat Mar 30, 2024 2:54 am    Post subject: Reply with quote

I did do some research on WebRender and what is its functionality. If Webrender is moved to CPU, instead of GPU (Webrender does not always use GPU) wouldn't there be a significant performance impact. Isn't this what hardware acceleration means?

So, basically all this patch is doing is making sure any hardware acceleration is not used even though enabled as rendering is now done by CPU? Correct?

If this is all it does, I would sacrifice the PGO and its performance gain(5%).
Back to top
View user's profile Send private message
Kresni
n00b
n00b


Joined: 30 Apr 2023
Posts: 22
Location: 46E 53N

PostPosted: Sat Mar 30, 2024 10:55 am    Post subject: Reply with quote

To a some degree, yes. But PGO is not just about your GPU or graphical rendering, you may look here for more information.

If you really want the performance boost, it is still there. In my honest opinion, for daily usage the difference is not worth the double compile time, but that's a different topic :D
_________________
~~~~
Back to top
View user's profile Send private message
Wadewilson
n00b
n00b


Joined: 09 Nov 2022
Posts: 31

PostPosted: Sun Mar 31, 2024 11:27 am    Post subject: Reply with quote

Hi Kresni,

Thanks, for the article on PGO. Given, that the patch is the only way to get PGO build working, I think I would settle for a build without PGO for now given the performance gain for the build time, I feel, is not worth it.

What is really bugging me is that mozilla official build use PGO, and if a build (firefox-bin) exists, how are they compiling it without issues? Certainly, they are not using the patch as that would cause hardware accel to never be used. I have cross checked with the source code for version 124.0.1, this patch is not applied.
Back to top
View user's profile Send private message
Kresni
n00b
n00b


Joined: 30 Apr 2023
Posts: 22
Location: 46E 53N

PostPosted: Sun Mar 31, 2024 11:34 am    Post subject: Reply with quote

Wadewilson wrote:
Hi Kresni,

Thanks, for the article on PGO. Given, that the patch is the only way to get PGO build working, I think I would settle for a build without PGO for now given the performance gain for the build time, I feel, is not worth it.

What is really bugging me is that mozilla official build use PGO, and if a build (firefox-bin) exists, how are they compiling it without issues? Certainly, they are not using the patch as that would cause hardware accel to never be used. I have cross checked with the source code for version 124.0.1, this patch is not applied.


This is something that I thought about as well. As they are the ones that wrote the software, they probably have a workaround to make it work with pgo, but it looks like they did not make that information public?

I have seen some package maintainers on other distributions struggle as well, very weird.
_________________
~~~~
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Portage & Programming All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum