additional-cpu-opts missing in 4.20.11 gentoo-sources???

wrc1944 · Last edited by wrc1944 on Wed Feb 20, 2019 8:41 pm; edited 1 time in total

The Patch #5010_enable-additional-cpu-optimizations-for-gcc-4.9.patch is missing in today's gentoo-sources update to 4.20.11.

Is this just an oversight, or has it actually been dropped after years of really making these opts convenient in gentoo-sources?

This is a must have patch! :roll:

Lots of us have come to rely on this just being there.

https://github.com/graysky2/kernel_gcc_patch/tree/c9779b8a43e1355f6a95a889661ff707e707234e (This is wrong link, see below)

https://dev.gentoo.org/~mpagano/genpatches/patches-4.20-10.html

Or, does it no longer correctly apply in 4.20.11? Worked fine in 4.20.10, as usual.

wrc1944 · Posted: Wed Feb 20, 2019 8:36 pm Post subject:

I downloaded the correct patch from graysky, and applied it myself, and it worked, as usual.

Compiling kernel now. I'm assuming leaving it out was just an oversight.

I expect all to be well, but will post back if not. BTW, the correct link is: https://github.com/graysky2/kernel_gcc_patch/blob/master/enable_additional_cpu_optimizations_for_gcc_v4.9%2B_kernel_v4.13%2B.patch
The other link above was an old version.

CaptainBlood · Advocate Joined: 24 Jan 2010 Posts: 3041

wrc1944 · Posted: Wed Feb 20, 2019 10:24 pm Post subject:

Sorry I had the old link posted first.
Hopefully, Mike Pagano (the genpatches dev) will add the gcc opts 5010 patch. IIRC, this happened once before about 2 years ago. No big deal, as one can always DIY.

Here's where I got the final link to the newest 5010 patch. https://dev.gentoo.org/~mpagano/genpatches/patches-4.20-10.html (at bottom of page.
_________________
Main box- AsRock x370 Gaming K4
Ryzen 7 3700x, 3.6GHz, 16GB GSkill Flare DDR4 3200mhz
Samsung SATA 1000GB, Radeon HD R7 350 2GB DDR5
OpenRC Gentoo ~amd64 plasma, glibc-2.36-r7, gcc-12.2.1_p20230304
kernel-6.2.2 USE=experimental python3_11

mpagano · Developer Joined: 27 Apr 2004 Posts: 194 Location: USA

So here's the mess...

The 5010 patch is still there, but won't apply if you are using gcc v8.

This change was made because I had committed the cpu optimization patch for >= gcc v8 and both
can't be applied at the same time. (Obviously)

Then...
I found out that the gcc v8 patch does not apply to 4.20.11 as I was releasing it.

Fun times.

I'll probably end up just seeing if I can fix the problems with the gcc v8 patch tomorrow and then commit for 4.20.12 or 4.20.11-r1. There might even be pull requests upstream to fix it. I have to check.

Sorry about the mess.

Either way, this will be fixed at least over this weekend.

mpagano · Developer Joined: 27 Apr 2004 Posts: 194 Location: USA

Test results from anyone interested welcome:

https://gitweb.gentoo.org/proj/linux-patches.git/diff/5011_enable-cpu-optimizations-for-gcc8.patch?h=4.20

wrc1944 · Posted: Fri Feb 22, 2019 10:58 pm Post subject:

Mike,
Thanks very much! The 5011 patch looks great. I assume this will be in the next 4.20.12 gentoo-sources and beyond the upcoming 5.0.0, but NOT for when gcc-9.x.x is available. Is this correct?

I'm also curious about the 5010 patch and why I was able to use it successfully on 3 Gentoo installs with kernel 4.20.11 and gcc-8.2.
I guess what confuses me is:
mpagano wrote:

mpagano · Developer Joined: 27 Apr 2004 Posts: 194 Location: USA