epatch_user question

Anon-E-moose · Posted: Mon Oct 22, 2018 12:17 pm Post subject: epatch_user question

I was looking at adding a user patch for gtk+ and have a question.

The ebuilds don't call it within them, but in looking around I saw that it's part of base.eclass,
so the question is, does that mean that ALL ebuilds implicitly call epatch_user, or does it still have to be explicitly called in the ebuild itself?
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

Every ebuild >=EAPI-6 has eapply_user.

Anon-E-moose · Posted: Mon Oct 22, 2018 12:28 pm Post subject:

Thanks for the clarification, I had assumed that to be the case, but we all know about assume. :lol:

Is there any way to have the ebuild modified without copying to local repository and hand editing?
In other words could I add a use flag or change something in the ebuild programmatically?
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

No, for changes to the ebuild itself you need to do it in your local overlay. Conditional patches are bad anyway, so there is a way around that by writing them unconditional, but as soon as you want to introduce USE flags etc., then to the local overlay it goes.

Anon-E-moose · Posted: Mon Oct 22, 2018 12:34 pm Post subject:

Thanks, I assumed that too, but never hurts to ask.
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

fedeliallalinea · Posted: Mon Oct 22, 2018 12:39 pm Post subject:

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

Yes, but the much better option is to fix ebuilds and bump them to EAPI-6++

fedeliallalinea · Posted: Mon Oct 22, 2018 1:32 pm Post subject:

Anon-E-moose · Posted: Mon Oct 22, 2018 2:47 pm Post subject:

I want the patch applied before eautoconf, is that possible, or can I tell it to reconfig somehow?

Some of the changes are to configure.ac and config.h.in
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

eautoreconf is what you need, from autotools.eclass, if it is not already run after default

Anon-E-moose · Posted: Mon Oct 22, 2018 2:57 pm Post subject:

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

In that case, unfortunately the user patch won't suffice. The ebuild calls eautoreconf before gnome2_src_prepare, which relies on xdg_src_prepare to call default (that is when your user patch is applied).

Anon-E-moose · Posted: Mon Oct 22, 2018 3:13 pm Post subject:

I was afraid of that.

I can have it apply to just configure, but that's less portable from version to version.
It still saves me from having to have a local ebuild, I think.
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

Or you may file a bug to reverse order of eautoreconf and gnome2_src_prepare.

Anon-E-moose · Posted: Mon Oct 22, 2018 3:58 pm Post subject:

asturm · Developer Joined: 05 Apr 2007 Posts: 8935

Regular bugs are always 'Current packages', yes it's just about the gtk+ ebuild. After talking to maintainers it seems that the ebuild should not even be calling eautoreconf itself (instead define GNOME2_EAUTORECONF="yes" before inherit).

Anon-E-moose · Posted: Mon Oct 22, 2018 4:19 pm Post subject:

Gotcha

thanks

ETA:
https://bugs.gentoo.org/669320
_________________
PRIME x570-pro, 3700x, 6.1 zen kernel
gcc 13, profile 17.0 (custom bare multilib), openrc, wayland

Anon-E-moose · Posted: Tue Oct 23, 2018 11:11 am Post subject:

The dev modified the latest, gtk+-3.24.1 and the user patch applies cleanly, with configure.ac and the configure works properly.

With 2 changes, the normal gentoo ebuild (this is with gtk+-3.24.1 only, at the moment) can be used to generate gtk+-3 without at-spi.
1. add "app-accessibility/at-spi2-atk-2.5.3" to /etc/portage/profile/package.provided (satisfy the dependency in ebuild)
2. put patch in /etc/portage/patches, I used this directory "/etc/portage/patches/x11-libs/gtk+:3" so that it would only apply to gtk+-3, you could intead of :3 use the version number.

Patch (call it what you want when you save it)
https://paste.pound-python.org/show/5GvXpgllAGfrjGNX8REC/

NOTE: to use with something like gtk+-3.22.30 then you would need to modify the ebuild like this and then do the 2 steps above.