| View previous topic :: View next topic |
| Author |
Message |
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
 Posted: Mon Jul 16, 2018 10:39 am Post subject: Wait time for submit package |
 |
|
| Hello, i have just little question. Is it normal wait time is too long when i post new package on bugzilla for gentoo ? |
|
| Back to top |
|
 |
John R. Graham
Administrator
Joined: 08 Mar 2005
Posts: 10589
Location: Somewhere over Atlanta, Georgia
|
| Posted: Mon Jul 16, 2018 10:43 am Post subject: |
|
|
Short answer, yes it is.
The longer answer is that it really depends on the interest of some developer to maintain the package. Some questions:- Did you write an ebuild? (What's the bug number, by the way?)
- If so, does your ebuild pass all of the repoman QA checks?
- Did you by chance offer to proxy maintain your new package?
- John
_________________
I can confirm that I have received between 0 and 499 National Security Letters. |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Mon Jul 16, 2018 5:18 pm Post subject: |
|
|
Yes, i have written two ebuild, and i'm agree to be proxy maintainer. I have doing all check with repoman. But it's strange, my post for msi-keyboard is tagged with sentence "maintainer-wanted", but i'm agree to maintain him ... error ?
Post:
https://bugs.gentoo.org/646522
https://bugs.gentoo.org/656714 |
|
| Back to top |
|
|
fedeliallalinea
Administrator
Joined: 08 Mar 2003
Posts: 30915
Location: here
|
| Posted: Mon Jul 16, 2018 5:21 pm Post subject: |
|
|
| https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers wrote: | | Patience: The package maintenance involves communicating with developers, users and upstream programmers. Sometimes your submissions may require a lot of work to meet the Gentoo QA standards. This can be frustrating, but the Proxy Maintainers will do their best to aid a Proxied Maintainer throughout the process. |
_________________
Questions are guaranteed in life; Answers aren't. |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Mon Jul 16, 2018 5:26 pm Post subject: |
|
|
No problem  I'm just pressed to contribute. 
I just would like to understand ! |
|
| Back to top |
|
|
Juippisi
Developer
Joined: 30 Sep 2005
Posts: 724
Location: /home
|
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Fri Jul 20, 2018 3:57 pm Post subject: |
|
|
| Do you think its good idea i duplicate my submitting package post to github ? |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Sat Nov 24, 2018 11:23 am Post subject: |
|
|
Sorry i post again a message, but i have maked my package since 2017, do you think is it normal i have no more news to gentoo about my submitting ebuild ?  |
|
| Back to top |
|
|
Dwosky
Tux's lil' helper
Joined: 07 Nov 2018
Posts: 135
|
| Posted: Sat Nov 24, 2018 9:08 pm Post subject: |
|
|
Hello Fulgurance,
I've seen you've created an overlay with some ebuilds, but I don't see in your repos that you have requested a Pull Request over Gentoo's git repository for them. Since Juippisi mentioned that no one adds ebuilds from bugzilla anymore, it might be a better aproach to clone the Gentoo's repo, patch it and submit a Pull Request to include the ebuild you're working on. |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Sun Nov 25, 2018 12:52 pm Post subject: |
|
|
@Fulgurance
I've seen your Bugzilla and overlay and took the liberty to make a PR with it.
Have not committed to portage before myself, so lets see what happens.
https://github.com/gentoo/gentoo/pull/10476 |
|
| Back to top |
|
|
asturm
Developer
Joined: 05 Apr 2007
Posts: 8936
|
| Posted: Sun Nov 25, 2018 2:20 pm Post subject: |
|
|
| Not sure that makes sense, unless you yourself want to go through review and maintain the package? |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Sun Nov 25, 2018 3:23 pm Post subject: |
|
|
| Don't mind the review, can't proxy-maintainership not be set to him? |
|
| Back to top |
|
|
asturm
Developer
Joined: 05 Apr 2007
Posts: 8936
|
| Posted: Sun Nov 25, 2018 4:11 pm Post subject: |
|
|
| That's kind of a non-starter if the initial review does not even include them. It is supposed to show to proxy-maint that the submitter is capable of working on the ebuild. |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Sun Nov 25, 2018 4:30 pm Post subject: |
|
|
OK, fair.
Thought he is capable since it was 9 months old and made the necessary adjustments. |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Sun Nov 25, 2018 10:02 pm Post subject: |
|
|
Hello, i have seen your replies.
If i understand good, now, post new package on bugzilla is useless ?
I thinking it's impossible i post pull request because Gentoo don't have give me access on Gentoo repository, no ? Or is it possible to submit suggested package ?
(I'm not git pro, i begin to use it)
Thanks to have made PR Maitreya 
I have already made necessary adjustment, but gentoo developper don't have posted any reply, but i imagine it's because i have posted on bugzilla ? Can you explain me how i post pull request on Gentoo repository? Can i must fork the master branch and make pull request ? I don't need special access on gentoo repository ? I search to understand |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Sun Nov 25, 2018 10:22 pm Post subject: |
|
|
| Fulgurance wrote: | Hello, i have seen your replies.
If i understand good, now, post new package on bugzilla is useless ?
I thinking it's impossible i post pull request because Gentoo don't have give me access on Gentoo repository, no ? Or is it possible to submit suggested package ?
(I'm not git pro, i begin to use it)
Thanks to have made PR Maitreya
I have already made necessary adjustment, but gentoo developper don't have posted any reply, but i imagine it's because i have posted on bugzilla ? Can you explain me how i post pull request on Gentoo repository? Can i must fork the master branch and make pull request ? I don't need special access on gentoo repository ? I search to understand |
1. Fork https://github.com/gentoo/gentoo on github
2. clone your fork
3. create branch for adding ebuild
4. checkout your branch
5. add your ebuild
6. let repoman check it
7. commit it
8. push branch back to github
9. create PR
10. profit
(Hope I didn't explain incorrectly) |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Mon Nov 26, 2018 1:54 am Post subject: |
|
|
| Maitreya, you have commited for me, but do you think msi-keyboard package was assigned for me ? |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Mon Nov 26, 2018 7:40 am Post subject: |
|
|
| Fulgurance wrote: | | Maitreya, you have commited for me, but do you think msi-keyboard package was assigned for me ? |
No that is what Asturm was talking about I think.
What I gather from it the process will automatically make me a proxy-maintainer and there is unwillingness to manually fix it. (no technical reason)
The better reason for you to do the PR is that they can "see if you can". Which sounds like a fair "demand".
However I do think it's ridiculous that you have been jumping through hoops for 9 months and there is 0 guidance for you.
I think it be best to just give them what they want. |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Mon Nov 26, 2018 9:34 am Post subject: |
|
|
Okay.
Is it possible I make pull request to ask Gentoo developers I would like to maintain him ?
Just, I have question. I have forked Gentoo repository and I have made new branch. But I need to understand something.
I have multiple package I need to submit. Can I make one branch per package I think ? Or I make one branch for all package would I like to submit ? |
|
| Back to top |
|
|
fedeliallalinea
Administrator
Joined: 08 Mar 2003
Posts: 30915
Location: here
|
| Posted: Mon Nov 26, 2018 9:51 am Post subject: |
|
|
| Fulgurance wrote: | | I have multiple package I need to submit. Can I make one branch per package I think ? Or I make one branch for all package would I like to submit ? |
I'm not sure but I think that better solution is a branch for each package, because if one comes accepted can be merged immediatly without waiting that all packages are accepted
_________________
Questions are guaranteed in life; Answers aren't. |
|
| Back to top |
|
|
Fulgurance
Veteran
Joined: 15 Feb 2017
Posts: 1200
|
| Posted: Mon Nov 26, 2018 10:01 am Post subject: |
|
|
| Okay. How i do that when i have made multiple branch ? (i'm not pro with git, i begin) I just commit package on branch ? But how i ignore other package on specific branch ? |
|
| Back to top |
|
|
Dwosky
Tux's lil' helper
Joined: 07 Nov 2018
Posts: 135
|
| Posted: Mon Nov 26, 2018 10:12 am Post subject: |
|
|
I think something like this might work:
| Code: | git checkout <branch_1>
< do changes for the package of this branch_1 >
git checkout <branch_2>
< do changes for the package of this branch_2 >
...
git checkout <branch_N>
< do changes for the package of this branch_N > |
Then go to GitHub and create a Pull Request for each branch. Or if you prefer a safer way, go one by one, waiting until the package you've PR its accepted until you proceed with the next one. |
|
| Back to top |
|
|
fedeliallalinea
Administrator
Joined: 08 Mar 2003
Posts: 30915
Location: here
|
| Posted: Mon Nov 26, 2018 10:14 am Post subject: |
|
|
| Fulgurance wrote: | | Okay. How i do that when i have maked multiple branch ? (i'm not pro with git, i begin) I just commit package on branch ? |
When you create multiple branch you can swith through these with command git checkout <bransh_name> (you should commit all change before change branch) and to check in which branch you are using the command git branch
For push, after commit, you can use git push origin <branch_name>
_________________
Questions are guaranteed in life; Answers aren't. |
|
| Back to top |
|
|
Maitreya
Guru
Joined: 11 Jan 2006
Posts: 441
|
| Posted: Mon Nov 26, 2018 10:35 am Post subject: |
|
|
@Fulgurancce
Someone took the time to review the PR, learn whatever you can from the feedback there as well |
|
| Back to top |
|
|
asturm
Developer
Joined: 05 Apr 2007
Posts: 8936
|
| Posted: Mon Nov 26, 2018 10:54 am Post subject: |
|
|
| Maitreya wrote: | | However I do think it's ridiculous that you have been jumping through hoops for 9 months and there is 0 guidance for you. |
What hoops to jump through do you see there? As I see it, both bugs received good input from bug wrangler/dev to improve style and basic QA. There are many examples of bugs with ebuild submissions (of variable quality) sitting there for years. The final step towards proxy-maint is missing yet, it just needs basic skills for git and some adapting to our git workflow. It is a give-and-take and certainly a great way to improve your knowledge.
@Fulgurance: Feel free to visit #gentoo-proxy-maint if you need help with repoman, git, etc. But please note that depending on your timezone, as always with IRC, you may need some patience while waiting for response. Also check /topic for relevant topics (like working with git). |
|
| Back to top |
|
|
|
Portage & Programming
