Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
[solved] kde-frameworks/kjsembed fails to include qt5
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Desktop Environments
View previous topic :: View next topic  
Author Message
ztom
n00b
n00b


Joined: 30 Mar 2006
Posts: 12

PostPosted: Sun Feb 04, 2018 9:53 pm    Post subject: [solved] kde-frameworks/kjsembed fails to include qt5 Reply with quote

After 'emerge -e world' rebuild various kde frameworks components depending on qt5 components like QSvgWidget and others fail to compile.

I have tried gcc 6.4 and 7.3, repeated partial world updates and am at the end of my wits( as in minutes away from another clean install ).

I know for sure kde-frameworks 5.40.0 compiled with qt 5.9.3 before. Now they do not.

At the time of rebuild kde-frameworks updated to 5.42.0 and qt to 5.9.4, but downgrading back to previously working versions does not change the error messages, so I suspect something else went wrong.

typical error messages are: ( kde-frameworks 5.42.0, qt 5.9.4, gcc 7.3.0 )

Code:
[ 70%] Building CXX object src/kjsembed/CMakeFiles/KF5JsEmbed.dir/brush.cpp.o
cd /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0_build/src/kjsembed && /usr/bin/x86_64-pc-linux-gnu-g++ -DKF5JsEmbed_EXPORTS -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"kjsembed5\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0_build/src/kjsembed -I/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed -I/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0_build/src/kjsembed/KF5JsEmbed_autogen/include -I/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/.. -I/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0_build/src/kjsembed/.. -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtUiTools -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtSvg   -DQT_NO_DEBUG -DNDEBUG -march=znver1 -mtune=znver1 -O2 -pipe -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -pedantic -Wsuggest-override -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -o CMakeFiles/KF5JsEmbed.dir/brush.cpp.o -c /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/brush.cpp
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.cpp: In member function ‘virtual void KJSEmbed::QObjectBinding::put(KJS::ExecState*, const KJS::Identifier&, KJS::JSValue*, int)’:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.cpp:337:18: warning: variable ‘propSet’ set but not used [-Wunused-but-set-variable]
             bool propSet = false;
                  ^~~~~~~
In file included from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/../kjsembed/static_binding.h:29:0,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/../kjsembed/variant_binding.h:32,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/url.h:26,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/url.cpp:22:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/../kjsembed/binding_support.h:473:1: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if COMPILER(MSVC) || __GNUC__ == 3
 ^~~~~~~~~~~~~~~~~
In file included from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/kjsembed.cpp:23:0:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.h:34:25: error: ‘QSvgWidget’ has not been declared
 KJSO_BINDING(SvgWidget, QSvgWidget, QWidgetBinding)
                         ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/binding_support.h:54:36: note: in definition of macro ‘KJSO_BINDING’
         NAME(KJS::ExecState *exec, TYPE * obj); \
                                    ^~~~
In file included from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:32:0,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qwidget_binding.h:28,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.h:28,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:22:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.h:34:25: error: ‘QSvgWidget’ has not been declared
 KJSO_BINDING(SvgWidget, QSvgWidget, QWidgetBinding)
                         ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/binding_support.h:54:36: note: in definition of macro ‘KJSO_BINDING’
         NAME(KJS::ExecState *exec, TYPE * obj); \
                                    ^~~~
In file included from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qwidget_binding.h:28:0,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.h:28,
                 from /var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:22:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp: In function ‘KJS::JSValue* SvgWidgetNS::renderer(KJS::ExecState*, KJS::JSObject*, const KJS::List&)’:
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:89:32: error: ‘QSvgWidget’ was not declared in this scope
 START_QOBJECT_METHOD(renderer, QSvgWidget)
                                ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:49:13: note: in definition of macro ‘START_QOBJECT_METHOD’
             TYPE *object = imp->qobject<TYPE>(); \
             ^~~~
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:89:32: note: suggested alternative: ‘QGLWidget’
 START_QOBJECT_METHOD(renderer, QSvgWidget)
                                ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:49:13: note: in definition of macro ‘START_QOBJECT_METHOD’
             TYPE *object = imp->qobject<TYPE>(); \
             ^~~~
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:49:19: error: ‘object’ was not declared in this scope
             TYPE *object = imp->qobject<TYPE>(); \
                   ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:89:1: note: in expansion of macro ‘START_QOBJECT_METHOD’
 START_QOBJECT_METHOD(renderer, QSvgWidget)
 ^~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:49:19: note: suggested alternative: ‘QObject’
             TYPE *object = imp->qobject<TYPE>(); \
                   ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:89:1: note: in expansion of macro ‘START_QOBJECT_METHOD’
 START_QOBJECT_METHOD(renderer, QSvgWidget)
 ^~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/qobject_binding.h:49:47: error: no matching function for call to ‘KJSEmbed::QObjectBinding::qobject<QSvgWidget>()’
             TYPE *object = imp->qobject<TYPE>(); \
                                               ^
/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/work/kjsembed-5.42.0/src/kjsembed/svg_binding.cpp:89:1: note: in expansion of macro ‘START_QOBJECT_METHOD’
 START_QOBJECT_METHOD(renderer, QSvgWidget)
 ^~~~~~~~~~~~~~~~~~~~

...


Which suggest qt headers don't get included correctly. The reason for this completely escapes me. The files are there, following the include chain manually I reach full class definitions.

My package.accept_keywords is copied from another working install, so there's noting too crazy there. Mostly just
Code:
kde-base/* ~amd64
kde-apps/* ~amd64
kde-frameworks/* ~amd64
kde-plasma/* ~amd64
dev-qt/* ~amd64


and whatever they pull in.

Is there an obvious fix for the situation or I'll just rebuild a clean system from stage3 and rid everybody from this mystery?

Thanks,
Tom

Code:

Portage 2.3.19 (python 3.5.4-final-0, default/linux/amd64/17.0/desktop/plasma/systemd, gcc-7.3.0, glibc-2.25-r9, 4.15.0-gentoo x86_64)
=================================================================
System uname: Linux-4.15.0-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-gentoo-2.4.1
KiB Mem:    32944656 total,  24122428 free
KiB Swap:   18874356 total,  18874356 free
Timestamp of repository gentoo: Sun, 04 Feb 2018 18:30:01 +0000
Head commit of repository gentoo: 006ef8ebc516129dea96a6ca1f8184beef6f3719
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
distcc 3.2rc1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.5.4-r1::gentoo
dev-util/cmake:           3.10.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/sandbox:         2.12::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r1::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            6.4.0-r1::gentoo, 7.2.0-r1::gentoo, 7.3.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.15::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r9::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://192.168.0.1/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:

steam-overlay
    location: /var/lib/layman/steam-overlay
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=znver1 -mtune=znver1 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=znver1 -mtune=znver1 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="-j16 --load-average=17.0"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j32 -l35"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg flac fortran gdbm gif glamor gpm gtk iconv icu ipv6 ithreads jpeg kde kipi kwallet lcms ldap libnotify mad mmx mng modules mp3 mp4 mpeg multilib ncurses nls nptl nptlonly ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds qml qt3support qt5 readline sdl seccomp semantic-desktop spell sse sse2 ssl startup-notification svg systemd tcpd threads tiff truetype udev udisks unicode upower usb user-session vdpau vorbis widgets wxwidgets x264 xattr xcb xcomposite xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="hda-intel usb-audio" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse joystick evdev" KERNEL="linux" L10N="en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby22 ruby23" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


Last edited by ztom on Sun Feb 04, 2018 10:13 pm; edited 3 times in total
Back to top
View user's profile Send private message
nasaiya
Tux's lil' helper
Tux's lil' helper


Joined: 17 May 2007
Posts: 147

PostPosted: Sun Feb 04, 2018 9:57 pm    Post subject: Re: kde-frameworks/kjsembed and others fail to include qt5 Reply with quote

Same problem with (supposedly) missing QSvgWidget here on a full ~amd46 clean install. The include does exist... I'm stuck on this one too.

I even tried adding an explicit
Code:
include_directories(/usr/include/qt5/QtSvg)
to the cmake file just to see what would happen and it still didn't work...

I see in the qsvgwidget.h file the class declaration is conditionally compiled with
Code:
#ifndef QT_NO_WIDGETS
Maybe that is getting mistakenly set somewhere? Still investigating...
_________________
If it ain't broke - fix it till it is!


Last edited by nasaiya on Sun Feb 04, 2018 10:06 pm; edited 1 time in total
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6824
Location: Austria

PostPosted: Sun Feb 04, 2018 10:01 pm    Post subject: Reply with quote

https://bugs.gentoo.org/646504
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
wrc1944
Advocate
Advocate


Joined: 15 Aug 2002
Posts: 3210
Location: Gainesville, Florida

PostPosted: Mon Feb 05, 2018 11:37 pm    Post subject: Reply with quote

asturm,
Just so I'm sure, I looked at the 646504 bug and on one Gentoo install where I'm having problems after the qt-5.9.4 update with:
Code:
* The following 3 packages have failed to build, install, or execute
 * postinst:
 *
 *  (kde-frameworks/kjsembed-5.42.0:5/5.42::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/kde-frameworks/kjsembed-5.42.0/temp/build.log'
 *  (kde-apps/svgpart-17.12.1:5/5::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/kde-apps/svgpart-17.12.1/temp/build.log'
 *  (kde-apps/gwenview-17.12.1:5/5::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/kde-apps/gwenview-17.12.1/temp/build.log'

I thought doing what comment 1 on the bug page suggested (commenting out these two lines):
Code:
/usr/include/qt5/QtCore/qconfig.h:#define QT_NO_WIDGETS true
/usr/include/qt5/QtSvg/qgraphicssvgitem.h:#if !defined(QT_NO_GRAPHICSVIEW) && !defined(QT_NO_WIDGETS)
and them completely rebuilding qt-5.9.4, then a complete kde rebuild might be worth a shot.

Not being a coder, I'm asking if this is the correct way to comment in C header files?
Quote:
/* #define QT_NO_WIDGETS true */

Or, is doing all this really unnecessary, and just wait for it to be sorted out in portage?
_________________
Main box- AsRock x370 Gaming K4
Ryzen 1700, 3.0GHz, 16GB GSkill Flare DDR4 3200mhz
Samsung SATA 1000GB, Radeon HD R7 350 2GB DDR5
Gentoo ~amd64 plasma, glibc-2.29-r2, gcc-8.3.0-r1 kernel-5.0.7-gentoo USE=experimental
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6824
Location: Austria

PostPosted: Mon Feb 05, 2018 11:45 pm    Post subject: Reply with quote

Qt needs to be fixed in tree.
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
wrc1944
Advocate
Advocate


Joined: 15 Aug 2002
Posts: 3210
Location: Gainesville, Florida

PostPosted: Tue Feb 06, 2018 1:04 am    Post subject: Reply with quote

Thanks much asturm,
I already started on my testing box, and it's on the final kde rebuild right now, but I guess I'll just wait on the other two systems.

If the kde rebuild successfully compiles the three packages that failed (with the two edited files and after the qt rebuild), I'll post back.
_________________
Main box- AsRock x370 Gaming K4
Ryzen 1700, 3.0GHz, 16GB GSkill Flare DDR4 3200mhz
Samsung SATA 1000GB, Radeon HD R7 350 2GB DDR5
Gentoo ~amd64 plasma, glibc-2.29-r2, gcc-8.3.0-r1 kernel-5.0.7-gentoo USE=experimental
Back to top
View user's profile Send private message
Hu
Moderator
Moderator


Joined: 06 Mar 2007
Posts: 13493

PostPosted: Tue Feb 06, 2018 3:32 am    Post subject: Reply with quote

wrc1944 wrote:
Not being a coder, I'm asking if this is the correct way to comment in C header files?
Code:
/* #define QT_NO_WIDGETS true */
That is correct for the limited example shown. Two potential pitfalls if you choose to use comments like this:
  1. C comments cannot be nested. If the area you need to comment contains a C comment, the end of that comment will prematurely terminate yours. (Work around this by disabling the end-comment marker of the pre-existing comment, or by adding another open-comment marker immediately after the pre-existing end-comment.)
  2. Take care not to unbalance control structures. Preprocessor conditionals imply particular scoping, so this is wrong:
    Code:
    /* #if SOME_CONDITION */
    C_code_to_enable
    #endif /* oops, should have commented this out when #if was commented out */
    Work around it by instead rewriting the first line to
    Code:
    #if 1 /* SOME_CONDITION */
Back to top
View user's profile Send private message
wrc1944
Advocate
Advocate


Joined: 15 Aug 2002
Posts: 3210
Location: Gainesville, Florida

PostPosted: Tue Feb 06, 2018 5:56 pm    Post subject: Reply with quote

Hu,
Thanks for the tips! After all these years I really need to spend a little time and learn some very basic C & C++ so I don't resort to having to ask about the basics. :roll:

BTW, my two edits and a recompile didn't resolve the problem.

Luckily, kensington is back and posted his version bump on the 646504 bug page using Psi's patch. It was a bit more involved than what I was trying to do, and it's now in the tree as 5.9.4-r1 revision bump. Currently giving it a try, with just to be sure a complete qt and kde rebuild. Details are on the bug page for anyone interested.

Thanks to Psi & kensington!
_________________
Main box- AsRock x370 Gaming K4
Ryzen 1700, 3.0GHz, 16GB GSkill Flare DDR4 3200mhz
Samsung SATA 1000GB, Radeon HD R7 350 2GB DDR5
Gentoo ~amd64 plasma, glibc-2.29-r2, gcc-8.3.0-r1 kernel-5.0.7-gentoo USE=experimental
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Desktop Environments All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum