Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
phpBB 2.0.3
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Networking & Security
View previous topic :: View next topic  
Author Message
rac
Bodhisattva
Bodhisattva


Joined: 30 May 2002
Posts: 6553
Location: Japanifornia

PostPosted: Thu Oct 03, 2002 9:28 pm    Post subject: phpBB 2.0.3 Reply with quote

I'm in the middle of upgrading a fairly heavily hacked phpBB board from 2.0.2 to 2.0.3. It looks like there are some fixes for moved threads in update_to_203.php, but no DB schema changes. The 2.0.3 patch has some spurious diffs in it, especially includes/page_header.php, which failed on my board. klieber, if you're reading this, I suspect the forums will have problems here too, thanks to the kanuslupus mark_read patch.

I tried reading through the patch file and matching lines up, but I started getting crosseyed, so I just unpacked a virgin 2.0.2, applied the patch and diff -ub'ed includes/page_header.php, which confirmed my suspicions that most of the patch (including the hunks that were failing on me) is just whitespace. The only interesting part of this file (except maybe for the version header comment) that gets patched is here:
Code:
@@ -85,7 +85,7 @@
 // Get basic (usernames + totals) online
 // situation
 //
-$user_forum_sql = ( !empty($forum_id) ) ? "AND s.session_page = $forum_id" : '';
+$user_forum_sql = ( !empty($forum_id) ) ? "AND s.session_page = " . intval($forum_id) : '';
 $sql = "SELECT u.username, u.user_id, u.user_allow_viewonline, u.user_level, s.session_logged_in, s.session_ip
        FROM ".USERS_TABLE." u, ".SESSIONS_TABLE." s
        WHERE u.user_id = s.session_user_id

Patches to the other files (login.php, includes/usercp_register.php, db/msaccess.php) went in fairly clean, with a little fuzz.
_________________
For every higher wall, there is a taller ladder
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Networking & Security All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum