Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
[erl]nordvpn-3.18.1.ebuild - könnte das bitte jemand prüfen?
View unanswered posts
View posts from last 24 hours
View posts from last 7 days

 
Reply to topic    Gentoo Forums Forum Index Deutsches Forum (German)
View previous topic :: View next topic  
Author Message
flammenflitzer
Advocate
Advocate


Joined: 25 Nov 2003
Posts: 3501
Location: Berlin

PostPosted: Sun May 12, 2024 7:03 am    Post subject: [erl]nordvpn-3.18.1.ebuild - könnte das bitte jemand prüfen? Reply with quote

Hallo, nordvpn ist in der Version 18.* verfügbar. Hier gibt es einige Änderungen zu den letzten Versionen.
Ich würde mich freuen, wenn jemand mein ebuild auf Fehler/ Optimierungen überprüft. Danke.
Code:
# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

EAPI=7

inherit unpacker

MY_PV=$(ver_rs 3 '-')

DESCRIPTION="NordVPN native client"
HOMEPAGE="https://nordvpn.com"
SRC_URI="https://repo.nordvpn.com/deb/nordvpn/debian/pool/main/nordvpn_${MY_PV}_amd64.deb"

LICENSE="NordVPN"
SLOT="0"
KEYWORDS="-* ~amd64"
IUSE="ipsymlink"

# TODO: verify that list of RDEPEND is complete
RDEPEND="net-misc/networkmanager
      net-vpn/networkmanager-openvpn
      sys-apps/iproute2
      acct-group/nordvpn"


RESTRICT="strip"
S="${WORKDIR}"



#nordvpn_3.18.1_amd64#

#nordvpn_3.18.1_amd64/data/usr/lib/tmpfiles.d/
#   nordvpn.conf

#nordvpn_3.18.1_amd64/data/usr/share/applications/
#   nordvpn.desktop

#nordvpn_3.18.1_amd64/data/var/lib/nordvpn/
#   openvpn

#nordvpn_3.18.1_amd64/data/var/lib/nordvpn/data:
#   countries.dat  cybersec.dat  insights.dat  ovpn_template.xslt  ovpn_xor_template.xslt  servers.dat


#nordvpn_3.18.1_amd64/data/usr/lib/systemd/system:
#   nordvpnd.service  nordvpnd.socket

#nordvpn_3.18.1_amd64/data/usr/share/bash-completion/completions:
#   nordvpn

#nordvpn_3.18.1_amd64/data/usr/share/doc/nordvpn:
#   changelog.Debian.gz

#nordvpn_3.18.1_amd64/data/usr/share/icons/hicolor/scalable/apps
#   nordvpn.svg  nordvpn-tray-black.svg  nordvpn-tray-blue.svg  nordvpn-tray-gray.svg  nordvpn-tray-white.svg

#nordvpn_3.18.1_amd64/data/usr/share/licenses/nordvpn:
#   LICENSE.md  THIRD-PARTY-NOTICES.md

#nordvpn_3.18.1_amd64/data/usr/share/man/man1:
#   nordvpn.1.gz

#nordvpn_3.18.1_amd64/data/usr/share/zsh/functions/Completion/Unix
#   _nordvpn_auto_complete


src_unpack() {
   # Unpack Debian package containing application's files
   unpack_deb ${A}
#   gzip "${S}"/usr/share/doc/nordvpn/changelog.gz -d "${S}"
   gzip "${S}"/usr/share/man/man1/nordvpn.1.gz -d "${S}"
}

src_install() {
   cd ${S}

#   doinitd>etc/init.d/nordvpn
   newinitd "${FILESDIR}/nordvpn.initd" ${PN}

#   into<-->/usr
   dobin usr/bin/nordfileshare
   dobin usr/bin/norduserd
   dobin usr/bin/nordvpn
   dosbin usr/sbin/nordvpnd

   insinto /var/lib/
   doins -r var/lib/nordvpn/data/countries.dat
   doins -r var/lib/nordvpn/data/cybersec.dat
   doins -r var/lib/nordvpn/data/insights.dat
   doins -r var/lib/nordvpn/data/ovpn_template.xslt
   doins -r var/lib/nordvpn/data/ovpn_xor_template.xslt
   doins -r var/lib/nordvpn/data/servers.dat
   
   
   fowners root:nordvpn /var/lib/nordvpn/openvpn
   fperms 0550 /var/lib/nordvpn/openvpn

   
   insinto /usr/share/bash-completion/completions
   doins usr/share/bash-completion/completions/nordvpn
   
   insinto /usr/share/licenses/nordvpn/
   doins usr/share/licenses/nordvpn/LICENSE.md
   doins usr/share/licenses/nordvpn/THIRD-PARTY-NOTICES.md

   
       insinto /usr/lib/systemd/system
       doins usr/lib/systemd/system/nordvpnd.service
   
   insinto /usr/lib/systemd/system
       doins usr/lib/systemd/system/nordvpnd.socket


   
#/usr/share/zsh/functions/Completion/Unix/_nordvpn_auto_complete   
      insinto /usr/share/zsh/functions/Completion/Unix
      doins usr/share/zsh/functions/Completion/Unix/_nordvpn_auto_complete


    insinto /usr/share/icons/hicolor/scalable/apps
    doins usr/share/icons/hicolor/scalable/apps/nordvpn.svg
    doins usr/share/icons/hicolor/scalable/apps/nordvpn-tray-black.svg
    doins usr/share/icons/hicolor/scalable/apps/nordvpn-tray-blue.svg
    doins usr/share/icons/hicolor/scalable/apps/nordvpn-tray-gray.svg
    doins usr/share/icons/hicolor/scalable/apps/nordvpn-tray-white.svg
   
   dodoc usr/share/doc/nordvpn/changelog.Debian.gz
   doman usr/share/man/man1/nordvpn.1
   

#   if use ipsymlink ; then
#      dosym /bin/ip /sbin/ip
#j   fi

   insinto /usr/lib/tmpfiles.d
   doins "${FILESDIR}/nordvpn.conf"
}

pkg_postinst (){
   if use !ipsymlink ; then
      elog "nordvpnd expects to find ip command in /sbin folder iproute2 package installs it in /bin please make sure to create a symlink: ln -s /bin/ip /sbin/ip"
    fi
   xdg_desktop_database_update
   xdg_icon_cache_update
   tmpfiles_process nordvpn.conf
}

pkg_postrm (){
   xdg_desktop_database_update
   xdg_icon_cache_update
}


Last edited by flammenflitzer on Sun May 19, 2024 8:16 am; edited 1 time in total
Back to top
View user's profile Send private message
Christian99
Veteran
Veteran


Joined: 28 May 2009
Posts: 1674

PostPosted: Mon May 13, 2024 6:51 am    Post subject: Reply with quote

da du den "if use ipsymlink" teil auskommentiert hast, würde ich noch das IUSE="ipsymlink" entfernen, da es sowieso nichts macht und ebenso die postinstallinfo zu ip symlink.

Persönlich finde ich so viel auskommentiertes "altes Zeug" nicht schön, vor allem kann das nach mehreren iterationen zu ziemlichen durcheinander führen. Wenn man alte Sachen nicht verlieren will ist ein versionsverwaltungstool (git...) der bessere weg, mMn, aber das ist wohl ein bisschen geschmackssache.
Back to top
View user's profile Send private message
flammenflitzer
Advocate
Advocate


Joined: 25 Nov 2003
Posts: 3501
Location: Berlin

PostPosted: Mon May 13, 2024 1:23 pm    Post subject: Reply with quote

Code:
   insinto /var/lib/
   doins -r var/lib/nordvpn/data/countries.dat
   doins -r var/lib/nordvpn/data/cybersec.dat
   doins -r var/lib/nordvpn/data/insights.dat
   doins -r var/lib/nordvpn/data/ovpn_template.xslt
   doins -r var/lib/nordvpn/data/ovpn_xor_template.xslt
   doins -r var/lib/nordvpn/data/servers.dat
Fehler:
Code:
>>> Source compiled.
>>> Test phase [not enabled]: net-vpn/nordvpn-3.18.1

>>> Install net-vpn/nordvpn-3.18.1 into /var/tmp/portage/net-vpn/nordvpn-3.18.1/image
chown: cannot access '/var/tmp/portage/net-vpn/nordvpn-3.18.1/image/var/lib/nordvpn/openvpn': No such file or directory
 * ERROR: net-vpn/nordvpn-3.18.1::local failed (install phase):
 *   fowners failed
Richtig ist
Code:

   insinto /var/lib/
   doins -r var/lib/nordvpn
Wenn ich IUSE="ipsymlink"entferne:
Code:
 * QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!
 * Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst.
 * QA Notice: One or more compressed files were found in docompress-ed
 * directories. Please fix the ebuild not to install compressed files
 * (manpages, documentation) when automatic compression is used:
 *
 *   /usr/share/doc/nordvpn-3.18.1/changelog.Debian.gz
 * ERROR: net-vpn/nordvpn-3.18.1::local failed (postinst phase):
 *   USE Flag 'ipsymlink' not in IUSE for net-vpn/nordvpn-3.18.1
 *
 * Call stack:
 *          ebuild.sh, line  136:  Called pkg_postinst
 *        environment, line 1378:  Called use '!ipsymlink'
 *   phase-helpers.sh, line  256:  Called die
 * The specific snippet of code:
 *                              die "USE Flag '${u}' not in IUSE for ${CATEGORY}/${PF}"
Sonst ist fast alles da gelandet, wo es hin soll, außer
Code:
/usr/share/applications/nordvpn.desktop
Back to top
View user's profile Send private message
Christian99
Veteran
Veteran


Joined: 28 May 2009
Posts: 1674

PostPosted: Mon May 13, 2024 1:41 pm    Post subject: Reply with quote

flammenflitzer wrote:
Wenn ich IUSE="ipsymlink"entferne:
Code:
 * QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!
 * Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst.
 * QA Notice: One or more compressed files were found in docompress-ed
 * directories. Please fix the ebuild not to install compressed files
 * (manpages, documentation) when automatic compression is used:
 *
 *   /usr/share/doc/nordvpn-3.18.1/changelog.Debian.gz
 * ERROR: net-vpn/nordvpn-3.18.1::local failed (postinst phase):
 *   USE Flag 'ipsymlink' not in IUSE for net-vpn/nordvpn-3.18.1
 *
 * Call stack:
 *          ebuild.sh, line  136:  Called pkg_postinst
 *        environment, line 1378:  Called use '!ipsymlink'
 *   phase-helpers.sh, line  256:  Called die
 * The specific snippet of code:
 *                              die "USE Flag '${u}' not in IUSE for ${CATEGORY}/${PF}"


dann hast du in pkg_postinst nicht den 'if use !ipsymlink ;...' block entfernt
Back to top
View user's profile Send private message
flammenflitzer
Advocate
Advocate


Joined: 25 Nov 2003
Posts: 3501
Location: Berlin

PostPosted: Mon May 13, 2024 7:38 pm    Post subject: Reply with quote

Danke.
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Deutsches Forum (German) All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum