double free detected in tcache 2 inat-tables.c [SOLVED]

Message

costel78 · Post by **costel78** » Mon Sep 05, 2022 7:22 am

After binutils update from 2.39 to 2.39-r1 I can no longer compile the kernel.
It fail with:

  DESCEND objtool
  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  GEN     arch/x86/lib/inat-tables.c
free(): double free detected in tcache 2
  LDS     scripts/module.lds
  CC      arch/x86/lib/insn-eval.o
make[1]: *** [arch/x86/lib/Makefile:36: arch/x86/lib/inat-tables.c] Error 134
make[1]: *** Deleting file 'arch/x86/lib/inat-tables.c'
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1847: arch/x86/lib] Error 2
make: *** Waiting for unfinished jobs....

I am not a C/C++ developer, but, as I understand, this is a binutils issue.
make clean and start fresh does not help.

Anybody have this issue, also ? Fix ideas ?

Thank you!

logrusx · Post by **logrusx** » Mon Sep 05, 2022 7:55 am

Current stable is 2.38-r2. Is there any reason to run testing?

Fix idea is to downgrade to stable or at least to previous know good version.

p.s. you didn't say which version of the kernel you're trying to compile. This may very well be a real issue in the kernel. A quick search reveal this kind of mistake is something related to undefined behavior and I don't see how that might be related to binutils. Did you try with an older kernel?

Regards,
Georgi

costel78 · Post by **costel78** » Mon Sep 05, 2022 8:16 am

The kernel version is 5.19.6 compiled four days ago with binutils 3.39.

Code: Select all

Linux nas 5.19.6-gentoo-nas #1 SMP PREEMPT_DYNAMIC Thu Sep 1 12:31:37 EEST 2022 x86_64 Intel(R) Celeron(R) J4125 CPU @ 2.00GHz GenuineIntel GNU/Linux

iwd was complaining about few missing kernel options and I set them. Now, I am unable to compile kernel neighter with new config version or older.
I will try with binutils 2.38. I hoped that some one find the source of the double free.

Thank you!

costel78 · Post by **costel78** » Mon Sep 05, 2022 8:43 am

Well, this is interesting...

Code: Select all

rm -rf /usr/src/*
emerge -1 gentoo-sources
binutils-config -l
 [1] aarch64-unknown-linux-gnu-2.39 *

 [2] x86_64-pc-linux-gnu-2.38 *
 [3] x86_64-pc-linux-gnu-2.39
source /etc/profile
cd /usr/src/linux
zcat /proc/config.gz > .config
make menuconfig && make -j10 all && make modules_install

  HOSTCC  scripts/basic/fixdep
  UPD     scripts/kconfig/mconf-cfg
  HOSTCC  scripts/kconfig/mconf.o
  HOSTCC  scripts/kconfig/lxdialog/checklist.o
  HOSTCC  scripts/kconfig/lxdialog/inputbox.o
  HOSTCC  scripts/kconfig/lxdialog/menubox.o
  HOSTCC  scripts/kconfig/lxdialog/textbox.o
  HOSTCC  scripts/kconfig/lxdialog/util.o
  HOSTCC  scripts/kconfig/lxdialog/yesno.o
  HOSTCC  scripts/kconfig/confdata.o
  HOSTCC  scripts/kconfig/expr.o
  LEX     scripts/kconfig/lexer.lex.c
  YACC    scripts/kconfig/parser.tab.[ch]
  HOSTCC  scripts/kconfig/lexer.lex.o
  HOSTCC  scripts/kconfig/menu.o
  HOSTCC  scripts/kconfig/parser.tab.o
  HOSTCC  scripts/kconfig/preprocess.o
  HOSTCC  scripts/kconfig/symbol.o
  HOSTCC  scripts/kconfig/util.o
  HOSTLD  scripts/kconfig/mconf
configuration written to .config

*** End of the configuration.
*** Execute 'make' to start the build or try 'make help'.

  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
  SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
  SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
  WRAP    arch/x86/include/generated/uapi/asm/bpf_perf_event.h
  WRAP    arch/x86/include/generated/uapi/asm/errno.h
  WRAP    arch/x86/include/generated/uapi/asm/fcntl.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctl.h
  WRAP    arch/x86/include/generated/uapi/asm/ipcbuf.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctls.h
  WRAP    arch/x86/include/generated/uapi/asm/param.h
  WRAP    arch/x86/include/generated/uapi/asm/poll.h
  WRAP    arch/x86/include/generated/uapi/asm/resource.h
  WRAP    arch/x86/include/generated/uapi/asm/socket.h
  WRAP    arch/x86/include/generated/uapi/asm/sockios.h
  WRAP    arch/x86/include/generated/uapi/asm/termbits.h
  WRAP    arch/x86/include/generated/uapi/asm/termios.h
  WRAP    arch/x86/include/generated/uapi/asm/types.h
  HOSTCC  arch/x86/tools/relocs_32.o
  HOSTCC  arch/x86/tools/relocs_64.o
  HOSTCC  arch/x86/tools/relocs_common.o
  UPD     include/config/kernel.release
  WRAP    arch/x86/include/generated/asm/early_ioremap.h
  WRAP    arch/x86/include/generated/asm/export.h
  WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
  WRAP    arch/x86/include/generated/asm/irq_regs.h
  WRAP    arch/x86/include/generated/asm/kmap_size.h
  WRAP    arch/x86/include/generated/asm/mmiowb.h
  WRAP    arch/x86/include/generated/asm/module.lds.h
  WRAP    arch/x86/include/generated/asm/local64.h
  WRAP    arch/x86/include/generated/asm/rwonce.h
  WRAP    arch/x86/include/generated/asm/platform-feature.h
  WRAP    arch/x86/include/generated/asm/unaligned.h
  UPD     include/generated/uapi/linux/version.h
  UPD     include/generated/utsrelease.h
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/asn1_compiler
  HOSTCC  scripts/sorttable
  YACC    scripts/genksyms/parse.tab.[ch]
  HOSTCC  scripts/genksyms/genksyms.o
  LEX     scripts/genksyms/lex.lex.c
  HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so
  DESCEND objtool
  HOSTCC  scripts/genksyms/parse.tab.o
  HOSTCC  scripts/genksyms/lex.lex.o
  HOSTLD  arch/x86/tools/relocs
  HOSTCC  /usr/src/linux-5.19.6-gentoo/tools/objtool/fixdep.o
  HOSTLD  /usr/src/linux-5.19.6-gentoo/tools/objtool/fixdep-in.o
  LINK    /usr/src/linux-5.19.6-gentoo/tools/objtool/fixdep
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/weak.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/exec-cmd.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/check.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/arch/x86/special.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/special.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/help.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/pager.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/builtin-check.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/elf.o
  GEN     /usr/src/linux-5.19.6-gentoo/tools/objtool/arch/x86/lib/inat-tables.c
free(): double free detected in tcache 2
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/objtool.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/parse-options.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/orc_gen.o
make[4]: *** [arch/x86/Build:9: /usr/src/linux-5.19.6-gentoo/tools/objtool/arch/x86/lib/inat-tables.c] Error 134
make[4]: *** Deleting file '/usr/src/linux-5.19.6-gentoo/tools/objtool/arch/x86/lib/inat-tables.c'
make[3]: *** [/usr/src/linux-5.19.6-gentoo/tools/build/Makefile.build:139: arch/x86] Error 2
make[3]: *** Waiting for unfinished jobs....
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/run-command.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/sigchain.o
  CC      /usr/src/linux-5.19.6-gentoo/tools/objtool/subcmd-config.o
  HOSTLD  scripts/genksyms/genksyms
  LD      /usr/src/linux-5.19.6-gentoo/tools/objtool/libsubcmd-in.o
  AR      /usr/src/linux-5.19.6-gentoo/tools/objtool/libsubcmd.a
  CC      scripts/mod/empty.o
  HOSTCC  scripts/mod/mk_elfconfig
  CC      scripts/mod/devicetable-offsets.s
  UPD     scripts/mod/devicetable-offsets.h
  MKELF   scripts/mod/elfconfig.h
  HOSTCC  scripts/mod/modpost.o
  HOSTCC  scripts/mod/file2alias.o
  HOSTCC  scripts/mod/sumversion.o
  HOSTLD  scripts/mod/modpost
  CC      kernel/bounds.s
  CALL    scripts/atomic/check-atomics.sh
  UPD     include/generated/timeconst.h
  UPD     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
make[2]: *** [Makefile:54: /usr/src/linux-5.19.6-gentoo/tools/objtool/objtool-in.o] Error 2
make[1]: *** [Makefile:73: objtool] Error 2
make: *** [Makefile:1348: tools/objtool] Error 2
make: *** Waiting for unfinished jobs....
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh

It fails earlier with same error and different binutils version.
Don't know if is a kernel error since it compiled fine few days ago. I'll wait for kernel 5.19.7 to see if something change as don't know where the real error is.

j_c_p · Post by **j_c_p** » Mon Sep 05, 2022 10:03 am

5.19.7 and 6.0-RC4 and the same error for me.
I will have a look at the binutils package upgrade.

edit : binutils-2.39 bugzilla.

costel78 · Post by **costel78** » Mon Sep 05, 2022 11:42 am

It fails with all versions from 5.19.2-r1 to 5.19.6. I haven't synced yet portage, so I don't have 5.19.7.
Tested with binutils 2.38-r1, 2.38-r2 and 2.39-r1.

costel78 · Post by **costel78** » Mon Sep 05, 2022 12:52 pm

It seems that issue is solved.
It's not binutils, but gawk the one that generate a bad /usr/src/linux/tools/objtool/arch/x86/lib/inat-tables.c Using V=1 helped me to see the error.
So, gawk-5.1.1-r2 works, and the new sys-apps/gawk-5.2.0::gentoo [5.1.1-r2::gentoo] USE="nls readline -mpfr -pma% -verify-sig" 0 KiB does not.

I'll try gawk-5.2.0 with pma to see if there is a difference.

Thank you, all, for support!

j_c_p · Post by **j_c_p** » Mon Sep 05, 2022 1:07 pm

Thanks to you, I will try as soon as possible gawk-5.1.1-r2 package.
Otherwise, you're welcome.

edit : that's ok for me too

.

costel78 · Post by **costel78** » Mon Sep 05, 2022 2:14 pm

It's gawk 5.2.0. USE FLAGS make no difference.

j_c_p · Post by **j_c_p** » Mon Sep 05, 2022 3:35 pm

Indeed, the downgrade is the right solution.

edit : gawk-5.2.0 with pma enable doesn't do the job.

eeckwrk99 · Post by **eeckwrk99** » Mon Sep 05, 2022 3:50 pm

Downgrading sys-apps/gawk to 5.1.1-r2 fixed the issue for me, thanks for the heads up. I didn't try sys-apps/gawk-5.2.0 with pma USE flag enabled, maybe that works too.

Edit: I managed to compile 5.15.65 and 5.19.7 kernels but compiling 5.10.141 still fails and now gives the following errors:

Code: Select all

cd /usr/src/linux/
% sudo make oldconfig
% sudo make -j$(nproc)
% sudo make -j$(nproc) modules_install
% sudo make -j$(nproc) install

Code: Select all

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  HOSTCC  scripts/kconfig/confdata.o
  HOSTCC  scripts/kconfig/expr.o
  LEX     scripts/kconfig/lexer.lex.c
  YACC    scripts/kconfig/parser.tab.[ch]
  HOSTCC  scripts/kconfig/lexer.lex.o
  HOSTCC  scripts/kconfig/parser.tab.o
  HOSTCC  scripts/kconfig/preprocess.o
  HOSTCC  scripts/kconfig/symbol.o
  HOSTCC  scripts/kconfig/util.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
  SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
  SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
  WRAP    arch/x86/include/generated/uapi/asm/bpf_perf_event.h
  WRAP    arch/x86/include/generated/uapi/asm/errno.h
  WRAP    arch/x86/include/generated/uapi/asm/fcntl.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctl.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctls.h
  WRAP    arch/x86/include/generated/uapi/asm/ipcbuf.h
  WRAP    arch/x86/include/generated/uapi/asm/poll.h
  WRAP    arch/x86/include/generated/uapi/asm/param.h
  WRAP    arch/x86/include/generated/uapi/asm/resource.h
  WRAP    arch/x86/include/generated/uapi/asm/socket.h
  WRAP    arch/x86/include/generated/uapi/asm/sockios.h
  WRAP    arch/x86/include/generated/uapi/asm/termbits.h
  WRAP    arch/x86/include/generated/uapi/asm/types.h
  WRAP    arch/x86/include/generated/uapi/asm/termios.h
  HOSTCC  arch/x86/tools/relocs_32.o
  HOSTCC  arch/x86/tools/relocs_64.o
  HOSTCC  arch/x86/tools/relocs_common.o
  WRAP    arch/x86/include/generated/asm/early_ioremap.h
  WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
  WRAP    arch/x86/include/generated/asm/irq_regs.h
  WRAP    arch/x86/include/generated/asm/export.h
  WRAP    arch/x86/include/generated/asm/mm-arch-hooks.h
  WRAP    arch/x86/include/generated/asm/local64.h
  WRAP    arch/x86/include/generated/asm/mmiowb.h
  WRAP    arch/x86/include/generated/asm/module.lds.h
  WRAP    arch/x86/include/generated/asm/rwonce.h
  UPD     include/generated/uapi/linux/version.h
  UPD     include/config/kernel.release
  HOSTCC  scripts/bin2c
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/recordmcount
  HOSTCC  scripts/sorttable
  HOSTCC  scripts/asn1_compiler
  UPD     include/generated/utsrelease.h
  HOSTCC  scripts/extract-cert
  DESCEND  objtool
  HOSTCC   /usr/src/linux-5.10.141-gentoo/tools/objtool/fixdep.o
  HOSTLD   /usr/src/linux-5.10.141-gentoo/tools/objtool/fixdep-in.o
  LINK     /usr/src/linux-5.10.141-gentoo/tools/objtool/fixdep
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/weak.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/exec-cmd.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/arch/x86/special.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/help.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/pager.o
  HOSTLD  arch/x86/tools/relocs
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/parse-options.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/run-command.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/sigchain.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/arch/x86/decode.o
In file included from arch/x86/decode.c:11:
arch/x86/../../../arch/x86/lib/inat.c: In function ‘inat_get_opcode_attribute’:
arch/x86/../../../arch/x86/lib/inat.c:15:16: error: ‘inat_primary_table’ undeclared (first use in this function)
   15 |         return inat_primary_table[opcode];
      |                ^~~~~~~~~~~~~~~~~~
arch/x86/../../../arch/x86/lib/inat.c:15:16: note: each undeclared identifier is reported only once for each function it appears in
arch/x86/../../../arch/x86/lib/inat.c: In function ‘inat_get_escape_attribute’:
arch/x86/../../../arch/x86/lib/inat.c:34:17: error: ‘inat_escape_tables’ undeclared (first use in this function); did you mean ‘inat_escape_id’?
   34 |         table = inat_escape_tables[n][0];
      |                 ^~~~~~~~~~~~~~~~~~
      |                 inat_escape_id
arch/x86/../../../arch/x86/lib/inat.c:30:13: error: variable ‘n’ set but not used [-Werror=unused-but-set-variable]
   30 |         int n;
      |             ^
arch/x86/../../../arch/x86/lib/inat.c: In function ‘inat_get_group_attribute’:
arch/x86/../../../arch/x86/lib/inat.c:53:17: error: ‘inat_group_tables’ undeclared (first use in this function); did you mean ‘inat_group_id’?
   53 |         table = inat_group_tables[n][0];
      |                 ^~~~~~~~~~~~~~~~~
      |                 inat_group_id
arch/x86/../../../arch/x86/lib/inat.c:49:13: error: variable ‘n’ set but not used [-Werror=unused-but-set-variable]
   49 |         int n;
      |             ^
arch/x86/../../../arch/x86/lib/inat.c: In function ‘inat_get_avx_attribute’:
arch/x86/../../../arch/x86/lib/inat.c:72:17: error: ‘inat_avx_tables’ undeclared (first use in this function)
   72 |         table = inat_avx_tables[vex_m][0];
      |                 ^~~~~~~~~~~~~~~
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/subcmd-config.o
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/check.o
arch/x86/../../../arch/x86/lib/inat.c: In function ‘inat_get_opcode_attribute’:
arch/x86/../../../arch/x86/lib/inat.c:16:1: error: control reaches end of non-void function [-Werror=return-type]
   16 | }
      | ^
  CC       /usr/src/linux-5.10.141-gentoo/tools/objtool/special.o
cc1: all warnings being treated as errors
make[4]: *** [/usr/src/linux-5.10.141-gentoo/tools/build/Makefile.build:96: /usr/src/linux-5.10.141-gentoo/tools/objtool/arch/x86/decode.o] Error 1
make[3]: *** [/usr/src/linux-5.10.141-gentoo/tools/build/Makefile.build:139: arch/x86] Error 2
make[3]: *** Waiting for unfinished jobs....
  CC      scripts/mod/empty.o
  HOSTCC  scripts/mod/mk_elfconfig
  CC      scripts/mod/devicetable-offsets.s
  UPD     scripts/mod/devicetable-offsets.h
  MKELF   scripts/mod/elfconfig.h
  HOSTCC  scripts/mod/modpost.o
  HOSTCC  scripts/mod/file2alias.o
  HOSTCC  scripts/mod/sumversion.o
  LD       /usr/src/linux-5.10.141-gentoo/tools/objtool/libsubcmd-in.o
  AR       /usr/src/linux-5.10.141-gentoo/tools/objtool/libsubcmd.a
  HOSTLD  scripts/mod/modpost
  CC      kernel/bounds.s
  CALL    scripts/atomic/check-atomics.sh
  UPD     include/generated/timeconst.h
  UPD     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
make[2]: *** [Makefile:55: /usr/src/linux-5.10.141-gentoo/tools/objtool/objtool-in.o] Error 2
make[1]: *** [Makefile:68: objtool] Error 2
make: *** [Makefile:1958: tools/objtool] Error 2
make: *** Waiting for unfinished jobs....
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh

That's with sys-apps/gawk-5.1.1-r2. I'm not sure if that's related but I didn't get these errors before with 5.2.0.

logrusx · Post by **logrusx** » Mon Sep 05, 2022 4:41 pm

eeckwrk99 wrote: Edit: I managed to compile 5.15.65 and 5.19.7 kernels but compiling 5.10.141 still fails and now gives the following errors:

I can't imagine why would you run 5.10 on a ~ system. I'll try it on my stable system and will let you know if it works.

EDIT: It compiled just fine.

Regards,
Georgi

eeckwrk99 · Post by **eeckwrk99** » Mon Sep 05, 2022 5:07 pm

logrusx wrote:
eeckwrk99 wrote: Edit: I managed to compile 5.15.65 and 5.19.7 kernels but compiling 5.10.141 still fails and now gives the following errors:
I can't imagine why would you run 5.10 on a ~ system. I'll try it on my stable system and will let you know if it works.

EDIT: It compiled just fine.

Regards,
Georgi

Thanks for letting me know, I'll investigate further then.

Edit: Re-emerging =gentoo-sources-5.10.141 solved the issue. I guess that was required after downgrading gawk to 5.1.1-r2.

j_c_p · Post by **j_c_p** » Mon Sep 05, 2022 6:57 pm

The bug : here.
The patch : here.

costel78 · Post by **costel78** » Mon Sep 05, 2022 7:20 pm

eeckwrk99 wrote: Edit: Re-emerging =gentoo-sources-5.10.141 solved the issue. I guess that was required after downgrading gawk to 5.1.1-r2.

It seems that inat-tables.c it is not regenerated if exists. make clean does not help, just make mrproper, clean sources install or manually file remove.

shevy_new · Post by **shevy_new** » Fri Sep 16, 2022 10:47 pm

I ran into the same problem. I am not using gentoo but I found this thread here via
Google. That is the first useful one I found. I thought my new computer's RAM was broken
because the free() error showed up. Already thought I need to run memtest or buy new RAM
or something.

I also thought the fault is with binutils.

Edit: I just finished compiling a new kernel and I can confirm that, at the least for my
situation, awk/gawk was the issue. The error now went away with awk/gawk 5.1.1.