Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
blender:3.0[standalone] build error patch fix...
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Other Things Gentoo
View previous topic :: View next topic  
Author Message
CaptainBlood
Advocate
Advocate


Joined: 24 Jan 2010
Posts: 3625

PostPosted: Mon Dec 06, 2021 6:06 pm    Post subject: blender:3.0[standalone] build error patch fix... Reply with quote

Code:
amd64 ~ $ eix blender
     Installed versions:  3.0.0(3.0)^t(17:12:40 06/12/2021)(alembic bullet collada color-management cycles dds embree ffmpeg fftw fluid gmp jack jemalloc jpeg2k oidn openexr openimageio openmp opensubdiv openvdb osl pugixml sndfile system-numpy system-python tbb tiff -cuda -debug -doc -headless -man -ndof -nls -openal -pdf -potrace -pulseaudio -sdl -standalone -test -valgrind PYTHON_SINGLE_TARGET="python3_9")
Here the following patches were required to enable [standalone] USE flag:
Code:
amd64 ~ # for i in /etc/portage/patches/media-gfx/blender-3.0.0/*;do echo $i;cat $i;done
/etc/portage/patches/media-gfx/blender-3.0.0/blender-3.0.0-001-cycles-standalone-progress_val.patch
--- a/intern/cycles/app/cycles_standalone.cpp   2021-10-27 21:46:32.000000000 +0300
+++ b/intern/cycles/app/cycles_standalone.cpp   2021-12-06 19:24:53.175730347 +0300
@@ -183,7 +183,7 @@
 
   progress.get_time(total_time, sample_time);
   progress.get_status(status, substatus);
-  float progress_val = progress.get_progress();
+  double progress_val = progress.get_progress();
 
   if (substatus != "")
     status += ": " + substatus;
@@ -200,7 +200,7 @@
       status.c_str(),
       total_time,
       latency,
-      (double)progress_val * 100,
+      progress_val * 100,
       sample_time,
       interactive.c_str());
 
/etc/portage/patches/media-gfx/blender-3.0.0/blender-3.0.0-002-cycles-standalone-progress.patch
--- a/intern/cycles/app/cycles_standalone.cpp   2021-12-06 19:43:09.247696237 +0300
+++ b/intern/cycles/app/cycles_standalone.cpp   2021-12-06 20:01:11.599561237 +0300
@@ -82,14 +82,14 @@
   string status, substatus;
 
   /* get status */
-  float progress = options.session->progress.get_progress();
+  double progress = options.session->progress.get_progress();
   options.session->progress.get_status(status, substatus);
 
   if (substatus != "")
     status += ": " + substatus;
 
   /* print status */
-  status = string_printf("Progress %05.2f   %s", (double)progress * 100, status.c_str());
+  status = string_printf("Progress %05.2f   %s", progress * 100, status.c_str());
   session_print(status);
 }
Thks 4 ur attention, interest & support.
_________________
USE="-* ..." in /etc/portage/make.conf here.
LT: "I've been doing a passable imitation of the Fontana di Trevi, except my medium is mucus. Sooo much mucus. "
Back to top
View user's profile Send private message
Hu
Moderator
Moderator


Joined: 06 Mar 2007
Posts: 21635

PostPosted: Mon Dec 06, 2021 7:12 pm    Post subject: Reply with quote

What error(s) are fixed by this? Is there an upstream bug report for this?
Back to top
View user's profile Send private message
sam_
Developer
Developer


Joined: 14 Aug 2020
Posts: 1678

PostPosted: Mon Dec 06, 2021 8:17 pm    Post subject: Reply with quote

Hu wrote:
What error(s) are fixed by this? Is there an upstream bug report for this?


Yes, please do actually file a bug report both downstream and possibly upstream. Dumping patches into a forum with no background information is just confusing...
Back to top
View user's profile Send private message
CaptainBlood
Advocate
Advocate


Joined: 24 Jan 2010
Posts: 3625

PostPosted: Mon Dec 06, 2021 8:33 pm    Post subject: Reply with quote

Implicit double to float cast conflicts with -Werror=float-conversion.
Patches are free to use by anyone willing to.
Thks 4 ur attention, interest & support.
_________________
USE="-* ..." in /etc/portage/make.conf here.
LT: "I've been doing a passable imitation of the Fontana di Trevi, except my medium is mucus. Sooo much mucus. "
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Other Things Gentoo All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum