Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
patch: kmail toolbar disappears after qt update
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Desktop Environments
View previous topic :: View next topic  
Author Message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Thu Oct 18, 2018 1:22 pm    Post subject: patch: kmail toolbar disappears after qt update Reply with quote

After update to qt-5.11.1 kmail lost its tool bar at every restart. If the toolbar is activated manually, it is lost after next start of kmail.
This seems to be a known bug:
https://forum.kde.org/viewtopic.php?f=215&t=153138
(a patch can be found there).
If anybody is also hit by this bug:
create a patch file, e.g. /etc/portage/patches/kde-apps/kmail-18.04.3/toolbar.patch with the following contents:
Code:

--- a/src/kmmainwin.cpp
+++ b/src/kmmainwin.cpp
@@ -76,7 +76,7 @@
     createGUI(QStringLiteral("kmmainwin.rc"));
 
     //must be after createGUI, otherwise e.g toolbar settings are not loaded
-    applyMainWindowSettings(KMKernel::self()->config()->group("Main Window"));
+    setAutoSaveSettings(KMKernel::self()->config()->group("Main Window"));
 
     connect(KPIM::BroadcastStatus::instance(), &KPIM::BroadcastStatus::statusMsg,
             this, &KMMainWin::displayStatusMessage);
@@ -94,10 +94,6 @@
     // Avoids a crash if there are any Akonadi jobs running, which may
     // attempt to display a status message when they are killed.
     disconnect(KPIM::BroadcastStatus::instance(), &KPIM::BroadcastStatus::statusMsg, this, nullptr);
-
-    KConfigGroup grp(KMKernel::self()->config()->group("Main Window"));
-    saveMainWindowSettings(grp);
-    KMKernel::self()->config()->sync();
 }
 
 KMMainWidget *KMMainWin::mainKMWidget() const


and recompile kmail. If you now activate the toolbar it stays enabled.
I hope this forum is the right place to share this.

tomtom
Back to top
View user's profile Send private message
Hu
Moderator
Moderator


Joined: 06 Mar 2007
Posts: 12965

PostPosted: Fri Oct 19, 2018 2:24 am    Post subject: Re: patch: kmail toolbar disappears after qt update Reply with quote

tomtom69 wrote:
I hope this forum is the right place to share this.
In my opinion, the right place to put this is a Gentoo bug report so that the ebuild maintainer can fix this for everyone. However, putting it here is a good start, since the maintainer may need a few days to get to the bug report.
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 3:29 am    Post subject: Reply with quote

Forums are not a place for bug reports (and sometimes a place for finding very bad 'solutions'). If it is what I think it is, then the patch is not a correct solution.

First of all, make sure that pressing Ctrl+M does not simply solve your problem.

Then check your config files for the following entry:
Code:
$ grep -R ^MenuBar .config/k*

*Delete* any lines with MenuBar=Disabled (while the corresponding applications are closed).
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Fri Oct 19, 2018 5:46 am    Post subject: Reply with quote

I compiled kmail again without the patch.
Ctrl+M toggles the menu bar, but the tool bar is always hidden after next restart of kmail, regardless of the previous menu bar and tool bar setting.
I deleted 'MenuBar=Disabled' from ~/.config/kmail2rc while kmail was not running. This also made no difference. The toolbar was hidden at every start of kmail, and after closing kmail the entry "MenuBar=Disabled' reappered in ~/.config/kmail2rc
This can be seen on 3 machines (one of them is a recent install from scratch, about 2months old) since the last qt update.
Sorry for the noise. I'll file a bug next time.
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 6:48 am    Post subject: Reply with quote

Could you please try again starting kmail with a completely empty kmail2rc?
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Fri Oct 19, 2018 7:25 am    Post subject: Reply with quote

Same thing with emptied kmail2rc
i backuped and deleted ~/.config/kmail2rc
Start kmail. Then the kmail setup wizard started up. I entered some data, and kmail started normally, including a visible tool bar.
When I then close kmail and restart it, tool bar disappears again. I can enable the toolbar in the menu, but it is lost at every restart of kmail.
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 7:55 am    Post subject: Reply with quote

Are you starting kmail or kontact? Do you reproduce the same problem with different user profile?
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Fri Oct 19, 2018 8:23 am    Post subject: Reply with quote

I am starting kmail (did never start kontact).
Tried with a newly created test user profile, the effect is the same.
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 9:07 am    Post subject: Reply with quote

Is this kmail-18.04.3 or 18.08.2? EDIT: Ah yes, 18.04.3. Unfortunately the patch contains no header, so it is unclear if it was taken from upstream and would already be fixed in 18.08.2...
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Fri Oct 19, 2018 9:56 am    Post subject: Reply with quote

I included the link where the patch came from. Unfortunately I do not know whether this was corrected upstream.
https://phabricator.kde.org/R206:814f0db2a1ae5b15bf91909ce80a5d6792f9aeed
says at least it was committed, and a tag mentiones 18.08.0 so I assumed the patch is from upstream. However I am not familiar with kde development process.
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 9:59 am    Post subject: Reply with quote

Thanks, now that's something.
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Fri Oct 19, 2018 7:34 pm    Post subject: Reply with quote

Please test kmail-18.04.3-r1 as soon as it appears on your system via emerge --sync. You will have to put it into package.accept_keywords on your stable system.
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
asturm
Developer
Developer


Joined: 05 Apr 2007
Posts: 6584
Location: Austria

PostPosted: Sat Oct 20, 2018 2:00 pm    Post subject: Reply with quote

ping, it would be really nice to get a tested-by from someone reproducing the bug.
_________________
backend.cpp:92:2: warning: #warning TODO - this error message is about as useful as a cooling unit in the arctic
Back to top
View user's profile Send private message
tomtom69
Apprentice
Apprentice


Joined: 09 Nov 2010
Posts: 184
Location: Bavaria

PostPosted: Sat Oct 20, 2018 3:12 pm    Post subject: Reply with quote

I can confirm kmail-18.04.3-r1 fixes the bug.
Thank you for the support and package update! :-)
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Desktop Environments All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum