View previous topic :: View next topic |
Author |
Message |
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Thu Jan 11, 2018 1:43 am Post subject: Should knghtbrd be in the offensive fortune set? |
|
|
Hi,
Not sure if I should post this in the Gamers forum (technically it's retro-gaming I guess but in the fortune packages, the knghtbrd file is pretty vulgar and IMO it should go in the offensive set.
Also, in the non-offensive "definitions" file, there is one definition "QFD" which should probably be in off/definitions with the rest of the F-words.
definitions, off/definitions, and knghtbrd are stock fortunes, not third party ones (i.e. they are not part of a separate package like SP or slack-fortunes-*)
Bugzilla says I should discuss on the forum first, and this might be by design (i.e. the choice of the developers). Should I file bugs (1) to move knghtbrd to offensive and (2) to move QFD from definitions to off/definitions?
Thank you!
EDIT: Apparently both issues are true of upstream. Should I take it there instead? |
|
Back to top |
|
|
pjp Administrator
Joined: 16 Apr 2002 Posts: 20067
|
Posted: Thu Jan 11, 2018 3:53 am Post subject: |
|
|
I think "Bugzilla says I should discuss on the forum first" means for a technical problem, to see if there is a known solution.
In this case, your issue is with the ebuild itself, so I think it is reasonable to open a bug at bugs.gentoo.org. Be sure to include examples of why you think the change(s) should be made. _________________ Quis separabit? Quo animo? |
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Thu Jan 11, 2018 9:57 pm Post subject: |
|
|
When asked about knghtbrd, Shlomi told me "pull-reqs are welcome" which I assume means that he isn't interested in combing through it. (I love fortunes, so I just might do a pull request
So the "definitions" issue was fixed by upstream, but I will take the "knghtbrd" issue to Gentoo Bugzilla when I have the chance. |
|
Back to top |
|
|
pjp Administrator
Joined: 16 Apr 2002 Posts: 20067
|
Posted: Thu Jan 11, 2018 10:08 pm Post subject: |
|
|
If upstream is the location where "offensive" is defined, then gentoo devs will unlikely be able to do much about it.
I interpret any "pull requests welcome" to mean "be the change you want to see in the world." _________________ Quis separabit? Quo animo? |
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Thu Jan 11, 2018 10:58 pm Post subject: |
|
|
pjp wrote: | If upstream is the location where "offensive" is defined, then gentoo devs will unlikely be able to do much about it. |
I'd think that now with the fortune in "definitions" moved by upstream, Gentoo will eventually pick it up when fortune-mod is next updated, no? Or is it such a niche package that it's generally left alone and Gentoo works on what they already have themselves? |
|
Back to top |
|
|
pjp Administrator
Joined: 16 Apr 2002 Posts: 20067
|
Posted: Fri Jan 12, 2018 12:34 am Post subject: |
|
|
I'm guessing that Gentoo devs would incorporate upstream changes. But the changes have to exist first, and since upstream said "it would be helpful if you provided the changes," it doesn't sound like it is going to be addressed "quickly" by upstream. _________________ Quis separabit? Quo animo? |
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Fri Jan 12, 2018 1:36 am Post subject: |
|
|
pjp wrote: | I'm guessing that Gentoo devs would incorporate upstream changes. But the changes have to exist first, and since upstream said "it would be helpful if you provided the changes," it doesn't sound like it is going to be addressed "quickly" by upstream. |
This is the Github commit of the "definitions" fix, which upstream did accept: https://github.com/shlomif/fortune-mod/commit/3bb04db1fbaf18f6a4072bdd75e1b374be70414d
I'll eventually, probably tomorrow, file with Bugzilla on both updating the package with upstream's "definitions" fix and my suggestion to Gentoo about "knghtbrd" which upstream rejected, but right now I have a nasty cold and not much sleep |
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Tue Jan 23, 2018 3:04 am Post subject: |
|
|
Sorry for the delay.
I don't think Gentoo should go against the decisions of upstream fortune-mod. Upstream believed the lone definitions fortune should not have been there (and moved it) but doesn't care about knightbrd. So we should instead wait for the next version of fortune-mod to be released, in accordance with the developer's wishes, rather than issue unofficial patches which would only make things unnecessarily complex. I will not be filing a bug with Gentoo for this reason. |
|
Back to top |
|
|
redblade7 Tux's lil' helper
Joined: 11 Jan 2018 Posts: 104
|
Posted: Wed Jun 13, 2018 9:16 pm Post subject: |
|
|
Just an update as I've logged in for the first time in a while, I wound up using the Ubuntu sources/patches for fortune-mod and it's more to my liking. Thank you! |
|
Back to top |
|
|
|