| View previous topic :: View next topic |
| Author |
Message |
cfgauss
l33t
Joined: 18 May 2005
Posts: 688
Location: USA
|
 Posted: Thu Nov 12, 2015 3:36 am Post subject: [SOLVED] vmware-modules-304.2 fails under kernel 4.3.0 |
 |
|
I have vmware-modules-304.2 correctly compiling under kernel-4.2.5-gentoo using these patches. However, under kernel-4.3.0-gentoo I get these errors:
| Code: | $ grep -i error emerge-vmware-modules
/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.c:403:8: error: void value not ignored as it ought to be
make[3]: *** [/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only/linux/driver.o] Error 1
make[2]: *** [_module_/var/tmp/portage/app-emulation/vmware-modules-304.2/work/vmmon-only] Error 2
make[1]: *** [sub-make] Error 2
make: *** [vmmon.ko] Error 2
* ERROR: app-emulation/vmware-modules-304.2::vmware failed (compile phase):
* ERROR: app-emulation/vmware-modules-304.2::vmware failed (compile phase):
|
Any debugging hints will be gratefully received.
[SOLVED] See patch by agix, below. [/SOLVED]
Last edited by cfgauss on Sat Nov 14, 2015 1:22 am; edited 2 times in total |
|
| Back to top |
|
 |
agix
n00b
Joined: 13 Nov 2015
Posts: 1
|
| Posted: Fri Nov 13, 2015 4:26 pm Post subject: |
|
|
misc_deregister doesn't return anything now (void)
here is a quick patch :
| Code: | --- vmmon-only/linux/driver.c 2015-11-13 16:56:44.870183155 +0100
+++ vmmon-only/linux/driver.c.new 2015-11-13 17:13:18.924228241 +0100
@@ -400,9 +400,7 @@
#ifdef VMX86_DEVEL
unregister_chrdev(linuxState.major, linuxState.deviceName);
#else
- if (misc_deregister(&linuxState.misc)) {
- Warning("Module %s: error unregistering\n", linuxState.deviceName);
- }
+ misc_deregister(&linuxState.misc);
#endif
Log("Module %s: unloaded\n", linuxState.deviceName);
--- vmci-only/linux/driver.c 2015-11-13 17:15:37.522234527 +0100
+++ vmci-only/linux/driver.c.new 2015-11-13 17:19:11.561244234 +0100
@@ -2480,12 +2480,7 @@
VMCI_HostCleanup();
- retval = misc_deregister(&linuxState.misc);
- if (retval) {
- Warning(LGPFX "Module %s: error unregistering\n", VMCI_MODULE_NAME);
- } else {
- Log(LGPFX"Module %s: unloaded\n", VMCI_MODULE_NAME);
- }
+ misc_deregister(&linuxState.misc);
hostDeviceInit = FALSE;
}
|
|
|
| Back to top |
|
|
cfgauss
l33t
Joined: 18 May 2005
Posts: 688
Location: USA
|
| Posted: Sat Nov 14, 2015 1:19 am Post subject: |
|
|
| agix wrote: | misc_deregister doesn't return anything now (void)
here is a quick patch :
|
This works! Many thanks. |
|
| Back to top |
|
|
kosgorbunov
n00b
Joined: 23 Nov 2015
Posts: 2
|
| Posted: Mon Nov 23, 2015 12:54 pm Post subject: |
|
|
however working code appeared to be a bit another for overlay "vmware", kernel 4.3.0, vmware-modules-304.2: | Code: | --- vmmon-only/linux/driver.c 2015-11-23 14:12:17.329780992 +0200
+++ vmmon-only/linux/driver.c.new 2015-11-23 14:18:46.159776291 +0200
@@ -400,9 +400,7 @@
#ifdef VMX86_DEVEL
unregister_chrdev(linuxState.major, linuxState.deviceName);
#else
- if (misc_deregister(&linuxState.misc)) {
- Warning("Module %s: error unregistering\n", linuxState.deviceName);
- }
+ misc_deregister(&linuxState.misc);
#endif
Log("Module %s: unloaded\n", linuxState.deviceName);
--- vmci-only/linux/driver.c 2015-11-23 14:35:55.339763849 +0200
+++ vmci-only/linux/driver.c.new 2015-11-23 14:38:57.439761647 +0200
@@ -2484,12 +2484,7 @@
VMCI_HostCleanup();
- retval = misc_deregister(&linuxState.misc);
- if (retval) {
- Warning(LGPFX "Module %s: error unregistering\n", VMCI_MODULE_NAME);
- } else {
- Log(LGPFX"Module %s: unloaded\n", VMCI_MODULE_NAME);
- }
+ misc_deregister(&linuxState.misc);
hostDeviceInit = FALSE;
}
|
Thank you, agix, it really works. |
|
| Back to top |
|
|
praneethng
n00b
Joined: 31 Jan 2017
Posts: 1
Location: bangalore
|
| Posted: Tue Jan 31, 2017 7:38 am Post subject: |
|
|
HI agix,
do i need to replace the dirver.c with the code you have given?
can you please tell me. |
|
| Back to top |
|
|
fedeliallalinea
Administrator
Joined: 08 Mar 2003
Posts: 30917
Location: here
|
| Posted: Tue Jan 31, 2017 7:42 am Post subject: |
|
|
| praneethng wrote: | do i need to replace the dirver.c with the code you have given?
can you please tell me. |
Howto add a user patch
_________________
Questions are guaranteed in life; Answers aren't. |
|
| Back to top |
|
|
|
Portage & Programming
