Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
Typo error in /etc/init.d/clock (baselayout 1.12.10-r5)
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Portage & Programming
View previous topic :: View next topic  
Author Message
VinzC
Watchman
Watchman


Joined: 17 Apr 2004
Posts: 5098
Location: Dark side of the mood

PostPosted: Wed Jan 09, 2008 12:39 pm    Post subject: Typo error in /etc/init.d/clock (baselayout 1.12.10-r5) Reply with quote

Hi.

I think there is a typo error in baselayout 1.12.10-r5; a colon is missing from file /etc/init.d/clock

/etc/init.d/clock:
@@ -57,7 +57,7 @@
        # Make sure people set their timezone ... we do it here
        # even though we don't actually use the variable so that
        # people see the warning on boot.
-       if [[ ${TIMEZONE:-Factory} == "Factory" ]] ; then
+       if [[ ${TIMEZONE-Factory} == "Factory" ]] ; then
                ewarn "Your TIMEZONE in /etc/conf.d/clock is still set to Factory!"
        fi
 }

I think it should be left unchanged; ${TIMEZONE-Factory} is always blank (not sure it is a valid variable though). Can anyone confirm?
_________________
Gentoo addict: tomorrow I quit, I promise!... Just one more emerge...
1739!
Back to top
View user's profile Send private message
Polynomial-C
Retired Dev
Retired Dev


Joined: 01 Jun 2003
Posts: 1432
Location: Germany

PostPosted: Wed Jan 09, 2008 1:31 pm    Post subject: Reply with quote

Did you report this to https://bugs.gentoo.org as well?
_________________
The manual said "Requires Windows10 or better" so I installed GNU/Linux...

my portage overlay

Need a stage1 tarball? (Unofficial builds)
Back to top
View user's profile Send private message
VinzC
Watchman
Watchman


Joined: 17 Apr 2004
Posts: 5098
Location: Dark side of the mood

PostPosted: Wed Jan 09, 2008 1:41 pm    Post subject: Reply with quote

Polynomial-C wrote:
Did you report this to https://bugs.gentoo.org as well?

Nope as I didn't know if it was on purpose or not. (I didn't expect an error in that file.)
_________________
Gentoo addict: tomorrow I quit, I promise!... Just one more emerge...
1739!
Back to top
View user's profile Send private message
Polynomial-C
Retired Dev
Retired Dev


Joined: 01 Jun 2003
Posts: 1432
Location: Germany

PostPosted: Wed Jan 09, 2008 1:54 pm    Post subject: Reply with quote

I think it's really an error in the script. I looked at the bash manpage and there is no ${VAR-string} described, only ${VAR:-string}. I think the gentoo-devs would like to know about this...
_________________
The manual said "Requires Windows10 or better" so I installed GNU/Linux...

my portage overlay

Need a stage1 tarball? (Unofficial builds)
Back to top
View user's profile Send private message
VinzC
Watchman
Watchman


Joined: 17 Apr 2004
Posts: 5098
Location: Dark side of the mood

PostPosted: Wed Jan 09, 2008 2:45 pm    Post subject: Reply with quote

Bugzilla Bug 205075.

EDIT: Not a bug.
_________________
Gentoo addict: tomorrow I quit, I promise!... Just one more emerge...
1739!
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Portage & Programming All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum