Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
Firefox ebuild with symbol visibility support
View unanswered posts
View posts from last 24 hours

Goto page 1, 2, 3  Next  
Reply to topic    Gentoo Forums Forum Index Unsupported Software
View previous topic :: View next topic  
Author Message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Thu Dec 29, 2005 1:46 pm    Post subject: Firefox ebuild with symbol visibility support Reply with quote

Firefox 1.5-r9 in portage contains these patches so this overlay is now obsolete!

This is another atempt at improving performance and now firefox is the victim. :) One of the new features in firfox 1.5 was symbol visibility support. This makes it faster (about 5% page rendering speed) and smaller. The problem is that the way firefox sets visibility by using visibility pragmas is broken on most arches because of compiler bugs so the gentoo devs decided to disable it by default everywhere even on x86 where it's actually working.

I've been able to make firefox 1.5 build with symbol visibility by using two patches, one from the mozilla bugzilla (bug #307168) and one extracted from firefox cvs. The first patch adds a configure check for the visibility pragma bug and enables building with -fvisibility if it's found and the second fixes the exports. With these patches applied and the configure script regenerated firefox 1.5 has no problems building with symbol visibility on previously broken arches like amd64 (though I haven't been able to test on ppc and others since I don't have any). Additionaly this ebuild also fixes the location bar trying to autocomplete invalid URLs (bug #9203). I opened a bug report about it. It's apperantly illegal to enable official branding so it'll say deer park everywhere.

1. Download the overlay from http://snigel.no-ip.com/~nxsty/linux/mozilla-firefox-overlay.tar.bz2.
2. Untar it in /usr/local/portage/www-client
3. Edit make.conf and make sure you have PORTDIR_OVERLAY="/usr/local/portage"
4. Backup your old mozilla-firefox with quickpkg
5. Unmask it if you are runnig stable
6. emerge mozilla-firefox

If you are using gcc 4.0 you should use gcc 4.0.2-r3 or later.

If you are using gcc 4.1 and it still fails you might need to apply this patch to your gcc: http://gcc.gnu.org/bugzilla/attachment.cgi?id=10120
It's already included in the 4.0.2-r1 and later patchsets.

Changelog

2006-01-01 (2)
*Disabled official branding again.

2006-01-01
*Added a patch for mozilla bug #9203.

Enjoy! :)


Last edited by nxsty on Sun Jan 08, 2006 10:51 pm; edited 14 times in total
Back to top
View user's profile Send private message
neenee
Veteran
Veteran


Joined: 20 Jul 2003
Posts: 1786

PostPosted: Thu Dec 29, 2005 2:43 pm    Post subject: Reply with quote

as i enjoy using your xorg-x11 and glibc overlays, i'll try this one too ;-)

i'll report back with how it went.

hm.. i have a question. after reading your post, i was wondering if i
need to use certain CFLAGS to make use of the things those patches
you put in fixed.

i am thinking of: -fvisibility=hidden and -fvisibility-inlines-hidden.

i do not currently use those CFLAGS

hm. i will read the comments at mozilla bugzilla. perhaps i can figure
out the answer to my question on my own.

*update* it compiled fine, but i am not sure i did not forget to
enable regarding fvisibility.
_________________
proud to be a scout and a chronic penguin hugger
Legion of Lore - site


Last edited by neenee on Thu Dec 29, 2005 4:36 pm; edited 1 time in total
Back to top
View user's profile Send private message
Sangeki
Apprentice
Apprentice


Joined: 23 Apr 2005
Posts: 186

PostPosted: Thu Dec 29, 2005 3:56 pm    Post subject: Reply with quote

Just finished compiling (with gcc-4.1.0_beta20051216).

So far it seems to work great and page rendering seems to be faster but I can't test it for sure...

And I successfully enabled the official branding.
You just have to put this line under the other mozconfig_annotate lines.

Code:
mozconfig_annotate '' --enable-official-branding


Last edited by Sangeki on Mon Jan 09, 2006 11:56 pm; edited 1 time in total
Back to top
View user's profile Send private message
bladus
Apprentice
Apprentice


Joined: 27 Jul 2005
Posts: 233

PostPosted: Thu Dec 29, 2005 4:12 pm    Post subject: Reply with quote

Compiled successfully on my amd64, with official branding enabled.

It would be nice to have an rendering-benchmark to test the rendering speed.
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Thu Dec 29, 2005 5:23 pm    Post subject: Reply with quote

Thanks for the tip! I uploaded a new overlay with official branding enabled.
Back to top
View user's profile Send private message
neenee
Veteran
Veteran


Joined: 20 Jul 2003
Posts: 1786

PostPosted: Thu Dec 29, 2005 8:15 pm    Post subject: Reply with quote

hm. perhaps my post was a bit too messy, so
i will ask my question in a separate post:

does this ebuild require specific CFLAGS to make
use of the visibility-related code?
_________________
proud to be a scout and a chronic penguin hugger
Legion of Lore - site
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Thu Dec 29, 2005 8:54 pm    Post subject: Reply with quote

neenee wrote:
does this ebuild require specific CFLAGS to make
use of the visibility-related code?


No the configure script detects visiblity supports and adds the appropriate flags. You don't need to do anything.
Back to top
View user's profile Send private message
neenee
Veteran
Veteran


Joined: 20 Jul 2003
Posts: 1786

PostPosted: Thu Dec 29, 2005 9:48 pm    Post subject: Reply with quote

okidoki - that is what i was hoping. thanks ;-)
_________________
proud to be a scout and a chronic penguin hugger
Legion of Lore - site
Back to top
View user's profile Send private message
mpalencia
n00b
n00b


Joined: 16 Feb 2005
Posts: 51
Location: Colombia

PostPosted: Thu Dec 29, 2005 9:56 pm    Post subject: Reply with quote

nxsty, does your gcc overlay work on this firefox ebuild?.
_________________
Lucky Livecd 32 and 64 bit versions (reiser4 suppport)
http://forums.gentoo.org/viewtopic-p-2986139.html#2986139

There are 2 things infinite: the universe and human stupidity, but I am not sure about the first one. (Einstein)
Back to top
View user's profile Send private message
Cinder6
l33t
l33t


Joined: 05 Aug 2004
Posts: 767
Location: California

PostPosted: Fri Dec 30, 2005 12:26 am    Post subject: Reply with quote

Well, been using the patched glibc since it was originally posted to the Gentoo AMD64 mailing list...I just gotta try this :) Fetching...
_________________
Knowledge is power.
Power corrupts.
Study hard.
Be evil.

Ugly Overload
Back to top
View user's profile Send private message
Cinder6
l33t
l33t


Joined: 05 Aug 2004
Posts: 767
Location: California

PostPosted: Fri Dec 30, 2005 1:38 am    Post subject: Reply with quote

Okay, I compiled it.

Page rendering *does* seem faster.
_________________
Knowledge is power.
Power corrupts.
Study hard.
Be evil.

Ugly Overload
Back to top
View user's profile Send private message
gringo
Advocate
Advocate


Joined: 27 Apr 2003
Posts: 3505

PostPosted: Fri Dec 30, 2005 9:23 am    Post subject: Reply with quote

awesome nxsty, thanks for your efforts !
Will try asap and report back ;)

cheers
Back to top
View user's profile Send private message
feld
Guru
Guru


Joined: 29 Aug 2004
Posts: 593
Location: WI, USA

PostPosted: Fri Dec 30, 2005 10:16 am    Post subject: Reply with quote

wow, NICE!


Dude you're full of it. This *HAS* to be more than 5% performance increase!!!

This is GREAT!



-Feld
_________________
< bmg505> I think the first line in reiserfsck is

if (random(65535)< 65500) { hose(partition); for (i=0;i<100000000;i++) print_crap(); }
Back to top
View user's profile Send private message
martin.k
Guru
Guru


Joined: 28 Nov 2004
Posts: 492
Location: Wylatowo, Polska

PostPosted: Fri Dec 30, 2005 10:37 am    Post subject: Reply with quote

Yeah! Works much faster than std firefox ebuild
Thanx!
_________________
linux-2.6.17 +ck +R4 +lockless +genetic-as +... więcej nie pamiętam :)
LRU #299256
Back to top
View user's profile Send private message
playfool
l33t
l33t


Joined: 01 Jun 2004
Posts: 688
Location: Århus, Denmark

PostPosted: Fri Dec 30, 2005 11:35 am    Post subject: Reply with quote

feld wrote:
wow, NICE!


Dude you're full of it. This *HAS* to be more than 5% performance increase!!!

This is GREAT!

-Feld


I reiterate what is quoted in your sig.
Back to top
View user's profile Send private message
gringo
Advocate
Advocate


Joined: 27 Apr 2003
Posts: 3505

PostPosted: Sat Dec 31, 2005 12:53 pm    Post subject: Reply with quote

good job ! Have no numbers but it really looks snappier !
another happy user here -> running nice on my opterons box and on my powerbook too :D

cheers
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Sat Dec 31, 2005 3:52 pm    Post subject: Reply with quote

mpalencia wrote:
nxsty, does your gcc overlay work on this firefox ebuild?.


Yes, and it's already patched with the bugfix I mentioned.
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Sun Jan 01, 2006 11:27 am    Post subject: Reply with quote

I added a patch for mozilla bug #9203. It's unrelated to this but is a very annoying bug. I also opened a bug in the gentoo bugzilla to get these patches included in portage.
Back to top
View user's profile Send private message
Anarchy
Developer
Developer


Joined: 29 Jun 2005
Posts: 89

PostPosted: Sun Jan 01, 2006 3:36 pm    Post subject: Reply with quote

nxsty wrote:
Thanks for the tip! I uploaded a new overlay with official branding enabled.


Please remove the overlay with official branding support. You nor myself have the right to enable branding for people. As soon as upstream gives me permission I will enable branding until then the branding needs of ebuilds needs to stay off the forums. Sorry but I do not control branding support just have to keep everyone on same page.
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Sun Jan 01, 2006 3:42 pm    Post subject: Reply with quote

Anarchy wrote:
Please remove the overlay with official branding support. You nor myself have the right to enable branding for people. As soon as upstream gives me permission I will enable branding until then the branding needs of ebuilds needs to stay off the forums. Sorry but I do not control branding support just have to keep everyone on same page.


Ok. Done! It now says deer park again.
Back to top
View user's profile Send private message
Anarchy
Developer
Developer


Joined: 29 Jun 2005
Posts: 89

PostPosted: Sun Jan 01, 2006 3:59 pm    Post subject: Reply with quote

nxsty wrote:
Anarchy wrote:
Please remove the overlay with official branding support. You nor myself have the right to enable branding for people. As soon as upstream gives me permission I will enable branding until then the branding needs of ebuilds needs to stay off the forums. Sorry but I do not control branding support just have to keep everyone on same page.


Ok. Done! It now says deer park again.


Appreciate your understanding of the problems that can and would have arouse with official branding being done in ebuild. I am currently testing your patches I will not include the url patch. If all goes well it will be added to tree at same time I add mozextension.eclass which bring us linguas support.
Back to top
View user's profile Send private message
nxsty
Veteran
Veteran


Joined: 23 Jun 2004
Posts: 1556
Location: .se

PostPosted: Sun Jan 01, 2006 5:25 pm    Post subject: Reply with quote

Anarchy wrote:
Appreciate your understanding of the problems that can and would have arouse with official branding being done in ebuild. I am currently testing your patches I will not include the url patch. If all goes well it will be added to tree at same time I add mozextension.eclass which bring us linguas support.


What's the requrements to enable official branding?

Btw, the patch nr1 on the bugzilla is umodified except resynced against firefox 1.5 but the one in the overlay tarball was modified by me to also pass -fvisibility-inlines-hidden along with -fvisibility=hidden as the gcc manual recomends (though I removed it now since it made zero difference). I guess it's a better idea to use the unmodified.
Back to top
View user's profile Send private message
Sangeki
Apprentice
Apprentice


Joined: 23 Apr 2005
Posts: 186

PostPosted: Sun Jan 01, 2006 8:42 pm    Post subject: Reply with quote

nxsty wrote:
What's the requrements to enable official branding?


AFAIK the Package has to be an official package from Mozilla.

It's so people will know that it's not an official Package and not supported or it's not their fault when it doesn't run as great as the official version or whatever.
Back to top
View user's profile Send private message
Anarchy
Developer
Developer


Joined: 29 Jun 2005
Posts: 89

PostPosted: Sun Jan 01, 2006 9:01 pm    Post subject: Reply with quote

If your wondering what changes have been made up to this point that are not in the tree grab my overlay http://dev.gentoo.org/~anarchy/overlay/mozilla-overlay.tar.gz Many issues have been addressed up to this point. If you could please keep this on the sticky tho everything related to firefox/thunderbird-1.5 as that is thread I watch to see what you the user are wanting to see become of portage ebuilds.
Back to top
View user's profile Send private message
StringCheesian
l33t
l33t


Joined: 21 Oct 2003
Posts: 887

PostPosted: Mon Jan 02, 2006 12:33 am    Post subject: Reply with quote

Thank you, nxsty, for the overlay and for bringing these patches to a Gentoo developer's attention. You rock! Even if you're not credited for Anarchy's overlay, know that you are appreciated.

Last edited by StringCheesian on Mon Jan 02, 2006 3:31 am; edited 1 time in total
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Unsupported Software All times are GMT
Goto page 1, 2, 3  Next
Page 1 of 3

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum